From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 673E8330B22 for ; Thu, 7 May 2026 06:06:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778133965; cv=none; b=Elc2nmmUe6NUT9r86cMiujhU0bfs9F2vPjjm7aZrW/oQEtkDM4V53azVPHsUhZz+8X0ubOzsUabdwbXCdp6O8RDvn79kYIoh8sfulQN6FxKU8MxfXpe5TNbnj9cGzkT0bo5WlFrRheemHYvs3f9lxCOblGMtIJXvIf7xHFyWidA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778133965; c=relaxed/simple; bh=RewBgTvMO8Z/qtnMqc+UdYwTZTh0doRKst6GnW3Jz/A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SwZ5W6KwuRdoTPxeZsAmiD6mGHWVBqzme5nFXApBGI/agHaVfiFZXSCs0Fh6fekm3mctXKc4CXuZR7kfw2OP3eLL7Ss+7M3+9AI0+dh+nMEEsfHoryZnsR55ZNT8j3dFkDYe6gPu2URFzVgzViGr3ngdkS2K8an3MVrwVFggYmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n283MIHa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Pb+KjFFA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n283MIHa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Pb+KjFFA" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6475MKK93157534 for ; Thu, 7 May 2026 06:06:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EtlMyNrzMQAok2E0rGfjl5nigCuKBAZtrkK4zXVtiQE=; b=n283MIHaRNlaQ7V0 +esVb2jNb9YmQHw9PF9eycnY3/AMEE3b9YMhOlgK32nYioiMgQDH4FceeOE1IYiK KCXRBdksI6YmFZkiGbDe/ozTjF0MNtrPt+bxpors7S4CG/Q7fDmDFWgnzspGXjjE Gehs9XmeSga+2vJ6c712k+hLlfI5VGUfNEq6G2x3g86i5eRWHE6vaxX5lfGxhCII XKOD0tcfBTeK96i1/xhcUhqtvb+4J1bQThK8xOJTy+tkH+hhJzgM7tizZfn+I713 ZSj0tdUBOdJVDHegj0VOff1a2lTIC6+gRtirmnr0OClRvFP16wZCrSkWRYe49RIQ GJS7BQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0mhf04aw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 06:06:03 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-83544d05c5aso247289b3a.2 for ; Wed, 06 May 2026 23:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778133962; x=1778738762; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EtlMyNrzMQAok2E0rGfjl5nigCuKBAZtrkK4zXVtiQE=; b=Pb+KjFFAkqFMAzCaYl7drEEqhtbqMjBO9vW9Eq7AeG1wiPRebAQ64fe/4L46+NzoiZ XYD8IKtTTXJROj5k8oFcTigqBbZWK9OMfgyrsq3LWjMbCPrc0JQ+pUHFSYjw/oJdmda+ uAg1G2UQmJvt1OWi716n0I50Kjz015gedyUCxT/YPzEkvzwJtzEgaaSuV75olxVYy8Uf Ir2ujWDmV1LWz90dUp2jDMhqk/BWdR9BID7Hho5qRmEmtjmBy2PenNYsDfvqaj3t5oh1 6TQRdDzHy2puq1EJ8ypQ2w7ledZNaN7BrcWpLEki/saZx+B2dCy81vxyECjEGxkkxQ9/ n4/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778133962; x=1778738762; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EtlMyNrzMQAok2E0rGfjl5nigCuKBAZtrkK4zXVtiQE=; b=iFyHkv/HVJVv2JmMkXRweTrAF963RBDCUGz6cTnMdDaZt2UrWkQjuIfLLdn55Ml1dK RKlFBhtq3IQHUXyeZ6FvzYf5HE5YQkb7qd/08Wf8nWBmKUwvQD8wFakhp8X//dzN7ABF 7aPdx1NZUDXepetjj86Wf4Wz/WVXvF5DLqVRO49fDu1O/g5SD9s12Q6OMznmQ9LafczJ aOE2ohruhvnxU4a8/NPAqBHfj1tlur65RwuNWlWm4g5v5lZ01ZENG3GtCCyf4ZU2xGGx JUQRgPhihFlNGhP9Fg/zzZauvYjhEZI3IwQRulL5ztetdrtIWgKKgoP/+NyJ/jrFtM+2 ot8A== X-Forwarded-Encrypted: i=1; AFNElJ+SkvTK5sBNp5buKKNWs3+rLYBBTfxN/O7Ur1ZKeaZ9SuqXGkIOPadqPZlMAEiYaW9fI6VU4ycHQ1jGCTs=@vger.kernel.org X-Gm-Message-State: AOJu0YxdDoewLkJSZRWjIpLVyk0AQA8wDsOZsmrkreMRXmY4mNqNlTxx p2eDvF8996oDJlNRKpNhjrc0r+I5R+gr/5AKAi4FoXtGQz4e3KKeSewFGhSGHs5/BElxxSpxcXK GG1lZWr/O7zZ56x8vBPoV3+qO/YnCb4cQoOSR/RQrMUJZy2rlxuoskUaRh3+R8G0Sebw= X-Gm-Gg: AeBDievJ4wVlIlktECuFVmT7999pZGjsqqDfrv1xBsNNVxRsMgGG96w/WgEI5od6yhG 2CVWnkuaIWO7fWbdm0OOBLThzNQBm0VOXouaS7r6rEYdDf6FZYAb3qkvX6hE0N6d3dguHMe0SCM gWWdnuj60sDtksdATJEN46IylLp0QSnJHehGXVWbOsCc9JbRxZiKhAUPI7lZIvreRehsg4vgffz k6TOn1y2kmGOW8moSi5ym5G1zhhthtlLtse9ADgsfbtCIH9teKwiCI6TooCCCbGE8Bm/+GJF0wK 7gpjdmf8ZhXJEmLKEPKwR05rR8JZxa12WZmdo7mHag1ge2SDQHeFNVGPehmoonIvAxNAMFX1X66 pbsLTS85CaqUbVE+us7ojatvPD9YSYZZNKCQSlJ+PShSeMIsNKnpmc9f/8JHlfp7A9eDjaN7lVE SkjDzW2wHmwz126342VDaf9cnXK3Kq9ts= X-Received: by 2002:a05:6a00:22d5:b0:82a:f02:7355 with SMTP id d2e1a72fcca58-83a5d387595mr6329667b3a.32.1778133962330; Wed, 06 May 2026 23:06:02 -0700 (PDT) X-Received: by 2002:a05:6a00:22d5:b0:82a:f02:7355 with SMTP id d2e1a72fcca58-83a5d387595mr6329646b3a.32.1778133961813; Wed, 06 May 2026 23:06:01 -0700 (PDT) Received: from WANGAOW-LAB01.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839685a3187sm7566187b3a.60.2026.05.06.23.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 23:06:01 -0700 (PDT) From: Wangao Wang Date: Thu, 07 May 2026 14:05:45 +0800 Subject: [PATCH v6 2/5] media: iris: Add hardware power on/off ops for X1P42100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260507-enable_iris_on_purwa-v6-2-48da505e23bf@oss.qualcomm.com> References: <20260507-enable_iris_on_purwa-v6-0-48da505e23bf@oss.qualcomm.com> In-Reply-To: <20260507-enable_iris_on_purwa-v6-0-48da505e23bf@oss.qualcomm.com> To: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Wangao Wang , Bryan O'Donoghue X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778133946; l=1865; i=wangao.wang@oss.qualcomm.com; s=20251021; h=from:subject:message-id; bh=RewBgTvMO8Z/qtnMqc+UdYwTZTh0doRKst6GnW3Jz/A=; b=goj99b2lHdOqR+s7VdrKnlkVD7PpWILoOrnGiJ1dNvMT+t7EqZBmq42Vn7sZWb9Ghpq21y0mK 7u1ZAVKeMsIC9M+4u849z7RjwUS93LBkn4Ec9ghvyJr8cywDF/YKQry X-Developer-Key: i=wangao.wang@oss.qualcomm.com; a=ed25519; pk=bUPgYblBUAsoPyGfssbNR7ZXUSGF8v1VF4FJzSO6/aA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDA1NyBTYWx0ZWRfX0CLG3DqTczZX dKDjzC+PcyDdS9vKFeXF1/MrFxOuGAM6seohHqQ9WhU6ncGa8CBqJXBcCkP3Eb/98EX+1ZYDW8t nBDsKbTrz8SK4F6oauslb4L7GBQ/oXTdurkz/aTc/HD+8OeQaTkqSc+UNZLg8MpfU7S6VaDNs/4 FvrqJaOiBYseWAwhJ9bDrBPgZ9meleWU21VbUgr2Ax5qKN7eNiOYKSZmHBhTd634qmguCvQMrIh ReuKacPBNb+K7liLVcbBpqkEEayvyqJ5j/etDhDCZty3gbaZk/TO2RLgO45h24BRNcsYHEisEqJ QApQJO5zMKHxiXcvfAThhXUI19d/oICtMDEsMD81nEEJJVYL3vLB4cb4I6KowlEXrRTPnLUup6N IKusonh+6qxhSHBHMTLsw60n6NTCznqqx6Kf8lpsHUQDH5uSBosTbF4XSjnIbzrHRphZjcCgZf9 Ooo4AjeW6Oj4yVuCaJw== X-Proofpoint-ORIG-GUID: HgjlmjcHQyUAf9y7Y3iWdAqFuQ5L-PrM X-Authority-Analysis: v=2.4 cv=SuagLvO0 c=1 sm=1 tr=0 ts=69fc2bcb cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=KtZWPW8jcQ_ObEEXPWgA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: HgjlmjcHQyUAf9y7Y3iWdAqFuQ5L-PrM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070057 On X1P42100 the Iris block has an extra BSE clock. Wire this clock into the power on/off sequence. The BSE clock is used to drive the Bin Stream Engine, which is a sub-block of the video codec hardware responsible for bitstream-level processing. It is required to be enabled separately from the core clock to ensure proper codec operation. Reviewed-by: Bryan O'Donoghue Reviewed-by: Dikshita Agarwal Signed-off-by: Wangao Wang --- drivers/media/platform/qcom/iris/iris_vpu_common.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c index 69e6126dc4d95ed9e5fccf596205e84ec0bfc82d..20af13388f3ffa1834a172c7c027e75c037ab8d1 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -224,6 +224,7 @@ void iris_vpu_power_off_hw(struct iris_core *core) { dev_pm_genpd_set_hwmode(core->pmdomain_tbl->pd_devs[IRIS_HW_POWER_DOMAIN], false); iris_disable_power_domains(core, core->pmdomain_tbl->pd_devs[IRIS_HW_POWER_DOMAIN]); + iris_disable_unprepare_clock(core, IRIS_BSE_HW_CLK); iris_disable_unprepare_clock(core, IRIS_HW_AHB_CLK); iris_disable_unprepare_clock(core, IRIS_HW_CLK); } @@ -292,8 +293,14 @@ int iris_vpu_power_on_hw(struct iris_core *core) if (ret && ret != -ENOENT) goto err_disable_hw_clock; + ret = iris_prepare_enable_clock(core, IRIS_BSE_HW_CLK); + if (ret && ret != -ENOENT) + goto err_disable_hw_ahb_clock; + return 0; +err_disable_hw_ahb_clock: + iris_disable_unprepare_clock(core, IRIS_HW_AHB_CLK); err_disable_hw_clock: iris_disable_unprepare_clock(core, IRIS_HW_CLK); err_disable_power: -- 2.43.0