From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75F60339705 for ; Thu, 7 May 2026 08:07:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778141266; cv=none; b=T+4p/2WVgq2Tl+EDXk+Y8E4ArTMa5g+xBh0u6FCKNoxHEnlYILOX29JZrVKZ5zQZMF2AEjfAnaIBLFtASD5VEnXNVVnqProXCzpq4YmVDc6oW0FShph/N7d7h0lC8ak5BD7dHI/HvLQZ3INohT0beOIB+5fkfZNtw3/QepixDfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778141266; c=relaxed/simple; bh=Fqe1k6ndoQL7AnpjmB3rnljMslxXfxgBLPUTZjxTcSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OdJOYPMASjfbDx35HCqC1JSHRPuieFhkBuq5qAGezI4rnmB7Z3MWffdocYU4JgXuN2S3MheaCsCEWwylZlQEP2BwQ98Q8APJOqh1sMRphQOWW3oETpT1JkFZ4GXIHVeVXJEAu85jZAsXalGDsiss8/DedWIMNdSZ1+ZS02Vicf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aId/aLsZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WOnBTRDC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aId/aLsZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WOnBTRDC" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64745oOZ879574 for ; Thu, 7 May 2026 08:07:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=IVQVByW/wSo hyv8buz0jWXLYt9mFK1Fn/wNwuVrm8X8=; b=aId/aLsZi9orcrIVTnUwyCJaFk/ N7Qzrm2XOewR1t9hT+ChzLteHB+s8DvhNKmXrUepqklZioomkIqhRxgdtrXGw260 /h1Dbt9uz3/grSl5r0e4U07QLyE4HZ/FGtegwsVTzYpivpwQBN+JmsU0lqW++HWc x2fcop8JNfdjE1kxXKz1BuZibPVawjm2mq0lSGdAX4SufF/gRJ8DWX7ndFk5zKAr k6jWfv0u89wF17G1O3UrNnPtc+WnsB7joMJ3uoiY8Y3X6TwNkO8AAVhQnl2rQ99f lv0tvYTApHUF6C6zGCusunMERQotv5MiWbxhDLSTd523qnmcaInLnhOkg2A== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kdq0sjb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 08:07:44 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3594620fe97so1322615a91.1 for ; Thu, 07 May 2026 01:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778141263; x=1778746063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IVQVByW/wSohyv8buz0jWXLYt9mFK1Fn/wNwuVrm8X8=; b=WOnBTRDCe1vJWqHXGwdF5eMFUV7v5z19/eocnZqTTjtyBHc4z3cPJmahaAiZkZvYMm cOOP9Fmx13vL7icFYdrDcncBB8Kl3YQCrRRDBLwZAXp7SXN2W2mtSl5jTUMuLnuATHpR DQiqkGtqWfl4AzR4OQYErpp/Y471qsthyrwlSW8AVIvYvox/QwTfWR5i31F8A47KyHYK F3vFuj/ESt8WASFgh/jhe/aWgNKFswqxgFNZ7pdHlurKVVEq7x9fGssMpXhgSt2wzMZz O/PbU9Fx1QwAHYVD+0obtovl6jXOeuw44H42UrSqbzrzWk4cD1++I5CKHpKfDtnzf0+t IoKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778141263; x=1778746063; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IVQVByW/wSohyv8buz0jWXLYt9mFK1Fn/wNwuVrm8X8=; b=VihtNl1ny5LhAHoTN3igGahftYfm4Rz1QdjKmi4tKWQjlpqO7JH6SrcBitwJOYRgzz 9sP+boTSyUsYymCVcMf3mev1LRYChylk1kWrfhm+i8qekDYCg19RvcNdtv1uJt5Uadwr 4cAATqxNl4Lvff4mSxj1XpCaZlk8EFXI1pKfKJUe6xDv1bMVOg+3WyEH3tetmbp5h3fA ZnitoS/VrZHBL/GZcJzEoAE6wS6k08YPOQWb5g1Own6IBZLJZgBhSU0xv+aAeqkBdZSC uVag87dHKmCKTN1QLFbnQhkbym5M9LeMhFabTgZQFsV98FdFSmEJw6MfCubdHiHsi0Oi ynGw== X-Forwarded-Encrypted: i=1; AFNElJ/FXpkW42fRXGLCvn0hrSb51t7nFAQmqCigjQPkWHvQBXUtUNzS2nrY2coK9i5/NTbp8OD0ydBSreYcFfY=@vger.kernel.org X-Gm-Message-State: AOJu0YxZUMEXf73xe6xfl3esg8kmKQns/MFn9Plr2FHpvTUr7YTU2zhI cLeMd5QkIMCdql9XMFif0ju63pSI/RHIcAHCLPZNs1rU51fH3LK3EVg/1nLgevBisOG3dwBrAMA FvdY816Uu6G7xbTeYy9Vy4cI0fNK+iLye4wRZTGbMwy/MYDhJfpGNNonKfwyVT8UvAL4= X-Gm-Gg: AeBDiesK9z4WEQwYOMjHzDRUf1f0OIRVuB1o4Gb/C178igohpphz1AbWSLVeppiQoNB TVQe1FsR+arlM4FOO9HTGTOl5xwdUlMtXDcLqAANMknpiGZ1XhT9wXKcyoKjTUIHl017mjiAlFi 57zKnp7yu2niBlKTWVilAdg0Y432NDVEmQcfIIUvUK4CmJn/1MsV+HXJPgOZycKq+7JOw+JvWIh zMsJYay6FLVWwDty8Ce3y1na8Q6cBQy3K+DU+j/S98rbzrjzwc5W8A6RUvnLzp11TTNOBayXqtT YPWDg25JccarUpotHxRdyG1s0vh2hGyU8bZROGuETCDNf9PJVwBfO0qOkNgMk7o6bQdte+ShoeR XSSDov5cIcLP2GulmL5owDEeBSAd7DW4H5bS9KneXCBP0499a5lK8MagBxd0= X-Received: by 2002:a17:90b:5284:b0:356:2c7b:c026 with SMTP id 98e67ed59e1d1-365ac766d8fmr7725933a91.23.1778141263436; Thu, 07 May 2026 01:07:43 -0700 (PDT) X-Received: by 2002:a17:90b:5284:b0:356:2c7b:c026 with SMTP id 98e67ed59e1d1-365ac766d8fmr7725871a91.23.1778141262870; Thu, 07 May 2026 01:07:42 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-365b0560fa8sm1986094a91.1.2026.05.07.01.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 01:07:42 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Marko , Guru Das Srinagesh Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha Subject: [PATCH 2/4] firmware: qcom: scm: use dev_err_probe() for dload address failure Date: Thu, 7 May 2026 13:37:18 +0530 Message-ID: <20260507080727.3227367-3-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260507080727.3227367-1-mukesh.ojha@oss.qualcomm.com> References: <20260507080727.3227367-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=P6IKQCAu c=1 sm=1 tr=0 ts=69fc4850 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=7_M7cpwsPd7APosSulYA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: 38Tkn23mvl3Kt0tKrS8vQVCx_massn81 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDA3OSBTYWx0ZWRfX1aTH7ntzXFk5 x10Dz1PTz71sTMAZybGhuNInqDK1iDuoEONOWp4Ak6UTNCMNdn+rqhSHsnbBRRutKp4o5ZwUPvm /lsfVU0Jby3F8gAEi2jw2hg1LpE9EoaTQGrMUDID3oQEkeTKk1K4/+5PAakojLI2qqwYzDys8Zt 8eZ2vpezv1UhaHDUBDyMIDn12vsbqG9QWxZneGgI2q9lTcqH/sdVQPJHDhs24Gp/KxagV+xTWdJ 21qcCoSS+trALi1xTaxrOP58P1IlYszwrZrtKQQWmf9WJbz8oz/eaH0BocAlKimU4b93cJ+d8MY YVmVaIleaz7dpMg+E3OvQ7BpfsvFRjMzya57lnRAhv7fdFfT+IJzVC57eKPmBjkkxqTMoU5pOFC 3CKFkMiJdOd4H9umsxQ0EEPRDK1DWA3eM4qvkm2RMj4ZKwrGSTiv+0o5ouY1ELIWDd1UxlWF0X/ D7Kzs2Dv6ldwH2YFjcg== X-Proofpoint-GUID: 38Tkn23mvl3Kt0tKrS8vQVCx_massn81 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070079 Replace the bare `return ret` after qcom_scm_find_dload_address() with dev_err_probe() to produce a consistent, deferred-probe-aware error message when the download-mode address cannot be resolved. Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/qcom_scm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index d9ee180388aa..f65b132004a5 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -2762,7 +2762,8 @@ static int qcom_scm_probe(struct platform_device *pdev) scm->dev = &pdev->dev; ret = qcom_scm_find_dload_address(&pdev->dev, &scm->dload_mode_addr); if (ret < 0) - return ret; + return dev_err_probe(&pdev->dev, ret, + "Failed to find download mode address\n"); mutex_init(&scm->scm_bw_lock); -- 2.53.0