From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57E943F7A86 for ; Fri, 8 May 2026 14:54:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778252042; cv=none; b=D2SJdRML6fRtEaBrOUCI5Om2OrWqxOrB+qgyUJIglQ28NCqXhBpgCLTz93yNsd/p6348kdvtD9PSmsSGktfWU3ep6rkI5yvjoWoX1MmR/QqNo0TrM+2qAGoTXGjvRnpADzD0KMxUVHi1//z6T5I0lBjXcjQbLzVyYnw54rghn8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778252042; c=relaxed/simple; bh=Id8y3cDF8b1Tt5vK2dt0u5UkdzJtwzOfVSavA6SQ85A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LPKNC3RP5JusCduXwrlZx9kDvXMJBibAIs62vpK3YASAn/SIRJLCyOvJngb3H54iilkQRtKpwCwX2Ab2aCDS8FZsWXu6kObGpXRgLKtpcvhIA8dXA7ZkROuUa3EjlQrW94648irypi0471I5brCBD4eJyn54Eu5W/6SQwetujDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W/PgGArx; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W/PgGArx" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7dea20cf21aso1918933a34.1 for ; Fri, 08 May 2026 07:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778252040; x=1778856840; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+GeLFNXv42TuP6KRLLxjXq2DNl7n0yfqf6KcI9MFRQo=; b=W/PgGArx/Gpk0rxhJWwV9Nr+YCeyjqriEyTlggWQNPuyShZNSg8BzBOuFMtB9M4EYY 90A1wJvCE+1QichTfTf9Q2Yte1RdQ5tGCNqM7j6n79ik9a/hvZRJ9Rr3EaggvIoA7t7T T7xsz3oh5xsLVbGBPmdRicqB+d/yZBKD8tYVv2ctZfkcGngV8tJYeUwokRAA57K1Fnbh 927Ln4xh3ov/d0RNl2Lt2O7UvJ/eGJqMKORwGRgZncq9Ob8rV0ceESyu6ZWZ1ZPzvImI 6RlqhDfPaWOzq3hq208w0m7Hsm6QhlKyHy8cEKipol34KmUCkyWcKe68HHTjwiQ3yK2Y 1Klw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778252040; x=1778856840; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+GeLFNXv42TuP6KRLLxjXq2DNl7n0yfqf6KcI9MFRQo=; b=f2KpUqaLNjfswDNv8dOHKYqOURKLVxPKEWbVlZTbjTYzsxQA70dZR9MvCtWQdqiSPA 2tYaa+Shzgv9CIEZ17HmqAtQnYoaVTrx/kP9clP56L6jTTTrVpnJcLQUDGImWaetVyRA GbCxW2n+0eWttlko8uY5k0steSNsJvO83/E1FDTGE7sZU9PdmPg8Uft87lCXGPkKZaOe Wqe/Rernzy+XXPde3u0tLkRTm+O3OhodYb1SN1k99DrlzXMdlQLuH4lzSFMOyDOBV74G 0AVh+inj6qW4jIR3zNMdF+jmT1ymA9LHNWoVBZjz/522w+saohJbFCWXMvwu9y8njA6l qcDA== X-Forwarded-Encrypted: i=1; AFNElJ/w+InE/2PfzuLqxfIAIJeE45QjPzCyJJ45uVsSj7yTTIckvTvyrlgWSt2XzfS4UcRhOG3ONzb1m5J5Aa0=@vger.kernel.org X-Gm-Message-State: AOJu0YzHAIecYjL72WZIJtG86gOrn54/KSa9y+NeW3z8ig8KUk1EPRhn QtvvR++XBZTgX+vSa9lGaqFLsqvvKGw2X/qbZA0vlhAF3v4UcSsa9XjD X-Gm-Gg: AeBDievw0WJ8Aq0uT2oQKGqEDV3fS/jJ2sHYtkrb4TgIk1sFjVahH7nlAgZ3uS/MNRM Be9YEVcnLR388gojaJgUyJZAKhAMVCw4XgTG/bw/wQ8+/IYmXciFm1E7KV5Ve54gZBMzQYKaHZA gqt+wUiEm5W0yeICm4pwqiUqxAKS+mFcPmYFrqoPyGRXYmDsQKP+SRRiyAMaBa1bLOL6E/uAldL +puCdf2SyrezuK8RURuVGPv+PoXH9XKWUIO1NoUKa1uFTbCiAxlGi5vKReEc17kj47q13rtM+Og jHOodoeHVmVyF0oJku1D5CconW3dVCeCOninB/zaRuAhup7HLdGAQrKLYWxIyqDiNzE0NhyZ/mY HBgnBTI1VzCgBpl6NKRx+iJIXJXIv/UR/6JzUHZHzgMgwZiq5OUqABm1XkyN9nHjxlHo79xwvKt ENGvbkwZ0xVlNS1MpTivtmhgQ49mqdYlF/0a3kscfhgFAtV8SFJVwk X-Received: by 2002:a05:6830:a90:b0:7dc:c92d:976d with SMTP id 46e09a7af769-7e1def3f15dmr8500919a34.10.1778252040158; Fri, 08 May 2026 07:54:00 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:4e::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e367be21f6sm1274509a34.2.2026.05.08.07.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 07:53:59 -0700 (PDT) From: Daniel Zahka Date: Fri, 08 May 2026 07:53:45 -0700 Subject: [PATCH net-next 2/6] netdevsim: psp: remove unnecessary UDP checksum computation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260508-nsim-psp-crypto-v1-2-4b50ed09b794@gmail.com> References: <20260508-nsim-psp-crypto-v1-0-4b50ed09b794@gmail.com> In-Reply-To: <20260508-nsim-psp-crypto-v1-0-4b50ed09b794@gmail.com> To: Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 The PSP spec requires the implementations accept 0 checksum in psp-udp header. Let's take advantage of that to trim netdevsim's psp code down. psp_dev_encapsulate() already sets uh->check to 0. Assisted-by: Claude:claude-opus-4.6 Signed-off-by: Daniel Zahka --- drivers/net/netdevsim/psp.c | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/drivers/net/netdevsim/psp.c b/drivers/net/netdevsim/psp.c index 5073bda60883..75740e2a731f 100644 --- a/drivers/net/netdevsim/psp.c +++ b/drivers/net/netdevsim/psp.c @@ -1,8 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 -#include #include -#include #include #include @@ -81,36 +79,6 @@ nsim_do_psp(struct sk_buff *skb, struct netdevsim *ns, skb->len - skb_inner_transport_offset(skb)); u64_stats_update_end(&ns->psp.syncp); } else { - struct ipv6hdr *ip6h __maybe_unused; - struct iphdr *iph; - struct udphdr *uh; - __wsum csum; - - /* Do not decapsulate. Receive the skb with the udp and psp - * headers still there as if this is a normal udp packet. - * psp_dev_encapsulate() sets udp checksum to 0, so we need to - * provide a valid checksum here, so the skb isn't dropped. - */ - uh = udp_hdr(skb); - csum = skb_checksum(skb, skb_transport_offset(skb), - ntohs(uh->len), 0); - - switch (skb->protocol) { - case htons(ETH_P_IP): - iph = ip_hdr(skb); - uh->check = udp_v4_check(ntohs(uh->len), iph->saddr, - iph->daddr, csum); - break; -#if IS_ENABLED(CONFIG_IPV6) - case htons(ETH_P_IPV6): - ip6h = ipv6_hdr(skb); - uh->check = udp_v6_check(ntohs(uh->len), &ip6h->saddr, - &ip6h->daddr, csum); - break; -#endif - } - - uh->check = uh->check ?: CSUM_MANGLED_0; skb->ip_summed = CHECKSUM_NONE; } -- 2.52.0