From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 866CB3FBEDD for ; Fri, 8 May 2026 14:54:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778252048; cv=none; b=JMuHIAlQzXvrUMKE/V53oeIwiVKPL5YJnINaSVeuxyPVEdzO+uoCSalcMJBE4iZXa9uyodgZ3xZe3C5+dw2pbyPqVGESv/ORKuprC/yocQwLtvcyymw4pzynFoCjwXZGQooXg9wTpFR5VUzzxJJDeqkFX93kLVRoBM0F3MCR/mo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778252048; c=relaxed/simple; bh=36DgZFE5cWQ/2I06imy7s6CW61tBQ1NllxQ2tZYBFhs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MUnAs5bZ9FeepL39AMfz/7ETJh432NG6Sb0GrRdS/wdtO93hbefKpHNYnnV0jmZ+1abvY+bve9PKsuOPby9fWgh2HF6WW0wbx9zcQoU61CfCgQh1w8f4SAmUxbTerYD0n3KmhCZ/6XIUwsyXhD2433GH2IKGbatWSOpVrqob2AY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eBcSVAhu; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eBcSVAhu" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7e36bb16a92so281325a34.2 for ; Fri, 08 May 2026 07:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778252045; x=1778856845; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RHL1wJQG1EIug8Z16j66mJo+lKQHRHLvWtIK615c/6Y=; b=eBcSVAhui0dnRIpBkoAxEI+H+frOMTDPxFMo7GarVpT7ZTW1UfuynJ6w68J8KHKiLD EcVbm0GJxepUWcNQSZQ631emacVQ5QvFGi6CMZMnoCkChgPSgqKYEu/dmthR5/jXWf5E SvQP4PjnsseCTU2v4CrgRWYoYJ7quG5itsWq2JLbR79BkDMRuuxwJLKvXjlNJKan5xKC 0/cVkEbwcwAEEV1sEiGWZcgaOc7xA8QOVuDhl3TJ7KQ7hXY/F864Ac86MspnB6EqP0UK +P98XP7s303GRlUhtnR4dVnQWGVKKSUmCa7mXFOcF7F8kGuIssDGvgkSkt4DYxLyTMRe L8Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778252045; x=1778856845; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RHL1wJQG1EIug8Z16j66mJo+lKQHRHLvWtIK615c/6Y=; b=S3iJsDsFbvf3FsCyRTWz3mCugtM6hB4Or1eRa+n6TXMZ6wOefl02BWAcKpO3ZHbw5k RsKkZkBJ907M/RJVNZj7i2E2zfpaNLEKGlhvo6mdjEd4bceEo3nWnW2cjbAJKGD0odsL t3rZKs66YoOc78+xlsFZjfvUWP3f9VryZJqwgmja+7ntFNjUI92xPK2qsjpIyIf/fC2F f3lF8wS/kmaGatCeb8vQwXa82uam9duKEQe1eVaUNAUNr1WjIz22cslg8jKuGRQRtDY6 nW5S/4GOMi3bfqK+8ZbkoYLFSonJzU8RavlphCjsdxiCTiIXUc8FmcLdF6zLk95eTLqh KG3A== X-Forwarded-Encrypted: i=1; AFNElJ+zxkcCFgfRWm3QwvOaL1SJBhw0l/jvkaVSECGyW8Ny7Bswc0HItjcmGjZSw9ruRJeENG3QhUaq5WCTybQ=@vger.kernel.org X-Gm-Message-State: AOJu0YweQWtsOPuioQqYkJPTtajZ+3QtwLV6t1pFmyPbnIT08HBqb5mM b9QkclGKaliQtM7QvRSkC4TgrCqG475TkWZ0qd7fhwL+cqhQK6952Ymn X-Gm-Gg: AeBDieuENwOo46SmrzO8j/7WFKKmkTLUiaTaDupr851FGsA/jF2UsMqHcv1nyRXBZXK TVHCAQM9xW4sWE33c1+vwX+y7nX7Kbk/ntS+SWBiGZtDGHKc8rz6x5YFPwBvS5PbP+8wYYUEAW9 NQrz1aiW3PDAmm2aVh9Px4KHKZC3FpNTkSdMfyOEAf6YrDdyUgubUzlSqFtbyKOlMDkmbO0aMkS RX8wjpCxqDgm0K8cvSj8ZCRvYXe1cVA4ioZ0M0WIwlvskqccXpi6XAb+TO2X3oPFslcoQJcXFad 4/v0YHr/7AcRcBGG53iN3rJsqquiZ1U/aY0Ba3I+23+oyVwURumps68oE0KqiebAoW2gnjqJ/68 sWylnoif3iUMBsFZ1IY2qIn3G/h5XsErilhFCqoisx+x333FRl+gDwQNPGJtWHRIzrVgp9bL1ab fGENFw7JyD3SdOgtjO0k5WmMfupmMS73wd00WBos/+ToOLBILxP4l1GEb8vJ/Jx3M= X-Received: by 2002:a05:6830:d8d:b0:7de:a2cc:9dde with SMTP id 46e09a7af769-7e1df04e894mr8115894a34.15.1778252045438; Fri, 08 May 2026 07:54:05 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:4e::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e367c056desm1190872a34.10.2026.05.08.07.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 07:54:04 -0700 (PDT) From: Daniel Zahka Date: Fri, 08 May 2026 07:53:49 -0700 Subject: [PATCH net-next 6/6] netdevsim: psp: count rx authentication and length errors Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260508-nsim-psp-crypto-v1-6-4b50ed09b794@gmail.com> References: <20260508-nsim-psp-crypto-v1-0-4b50ed09b794@gmail.com> In-Reply-To: <20260508-nsim-psp-crypto-v1-0-4b50ed09b794@gmail.com> To: Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 Now that netdevsim does psp parsing and aes-gcm decryption in rx, we can report authentication and length errors in the psp stats api. Assisted-by: Claude:claude-opus-4.7 Signed-off-by: Daniel Zahka --- drivers/net/netdevsim/netdevsim.h | 2 ++ drivers/net/netdevsim/psp.c | 11 ++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/netdevsim.h b/drivers/net/netdevsim/netdevsim.h index 112fe1ee10bc..5f0f638ee893 100644 --- a/drivers/net/netdevsim/netdevsim.h +++ b/drivers/net/netdevsim/netdevsim.h @@ -118,6 +118,8 @@ struct netdevsim { struct { u64_stats_t rx_packets; u64_stats_t rx_bytes; + u64_stats_t rx_auth_fail; + u64_stats_t rx_error; u64_stats_t tx_packets; u64_stats_t tx_bytes; struct u64_stats_sync syncp; diff --git a/drivers/net/netdevsim/psp.c b/drivers/net/netdevsim/psp.c index 4945973d523d..053c01cc310d 100644 --- a/drivers/net/netdevsim/psp.c +++ b/drivers/net/netdevsim/psp.c @@ -207,8 +207,12 @@ bool nsim_psp_handle_rx(struct netdevsim *ns, struct sk_buff *skb) psp_off = l3_hlen + sizeof(struct udphdr); payload_len = skb->len - psp_off - PSP_HDR_SIZE - PSP_TRL_SIZE; - if (payload_len < 0) + if (payload_len < 0) { + u64_stats_update_begin(&ns->psp.syncp); + u64_stats_inc(&ns->psp.rx_error); + u64_stats_update_end(&ns->psp.syncp); goto drop; + } if (FIELD_GET(PSPHDR_CRYPT_OFFSET, psph->crypt_offset)) goto drop; @@ -238,6 +242,9 @@ bool nsim_psp_handle_rx(struct netdevsim *ns, struct sk_buff *skb) payload_len, (u8 *)psph, PSP_HDR_SIZE, iv, authtag)) { memzero_explicit(&ctx, sizeof(ctx)); + u64_stats_update_begin(&ns->psp.syncp); + u64_stats_inc(&ns->psp.rx_auth_fail); + u64_stats_update_end(&ns->psp.syncp); goto drop; } memzero_explicit(&ctx, sizeof(ctx)); @@ -346,6 +353,8 @@ static void nsim_get_stats(struct psp_dev *psd, struct psp_dev_stats *stats) start = u64_stats_fetch_begin(&ns->psp.syncp); stats->rx_bytes = u64_stats_read(&ns->psp.rx_bytes); stats->rx_packets = u64_stats_read(&ns->psp.rx_packets); + stats->rx_auth_fail = u64_stats_read(&ns->psp.rx_auth_fail); + stats->rx_error = u64_stats_read(&ns->psp.rx_error); stats->tx_bytes = u64_stats_read(&ns->psp.tx_bytes); stats->tx_packets = u64_stats_read(&ns->psp.tx_packets); } while (u64_stats_fetch_retry(&ns->psp.syncp, start)); -- 2.52.0