From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EAF63750D7 for ; Fri, 8 May 2026 06:18:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778221088; cv=none; b=olNb0yES2imxicBBTSaaygh/cVgV2xuodOdEEXz+kWTnTnJmKr5ZPf80eAuRxLIthxOieesuAl+Nc0nDuzpmZ52Da+8am66NVMd7e8CjAJfSOshuuOyhM+iDu2mXGCqETaYh2qbMYyhfI7vxw2A6p6IiXlq+WdJpJOZtCXqLGp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778221088; c=relaxed/simple; bh=fne91szarOWdIvniaI9+UEt6vpPwm2FRb2JS2VMwdb4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RcCkvORFUFDQrRCcbhT4NGBw3yZwJxfjSSiDnwVTfR6nWlSw/9Z1+7tv1VNtWPbyeVKO2/Jsm8uOHWuyIXt7XZz6PqvEfMRCngiJzlNh/tt1UkaBKKsJO/ITTnbRngYCByUy4E2txiTyrD6bz+CcxoLNtDPeOrjJpYomAaza+NY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VHGrunoM; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VHGrunoM" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48909558b3aso18868805e9.0 for ; Thu, 07 May 2026 23:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778221074; x=1778825874; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=btkeAG5X+48Uo58rvevp6gJltGqFkkONHOsVscYaKek=; b=VHGrunoMVLtvYYt6xSKBzpp0Wi1jszQ/g6/9wSP8iLL/8CThUZwcFCId+4lQXny+tO R6Oap6ho7m4jTAXjKCbdOoLRWtkg1qiNiPgmnu+ziKttUKQU22TIJG9RhpQtpRVBJDQn Bg7CcF37vorUbz7gcJ8jZogys+vOFViKwaq/je/SCDa9DJVKBIw99U0dJd8rLnNfMhQ4 FOh/7H7PtUJKqXXMmbXI/r8Em3p+omxnCg7J6Rhue5VDcUGJsGITBeOO0vVM1gSfwKeS A7Csr0PIEWK6UF7/ZBUV5jrIrV9yzHLYfwAxXy/ix21qBZ5uJBJsSaFdx1XEGN1vwIhT kp5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778221074; x=1778825874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=btkeAG5X+48Uo58rvevp6gJltGqFkkONHOsVscYaKek=; b=KxFNDR6HX4PRc0SQKT/tEvvdV8UmVgFbEBJx/jj7orquSxwzHNnNVUNo8xUlA46Fgk 2xXjnRzxS2HxK/EAL0pAgD5Z8GuVUCOOJ9R6vdoU+VU9wc56P4XP2K/abFokstB0cMaN vpa4TDOt75g2Ja5oDwU3/I1fe4BSww3NE9gdGeS/P4qIRQ6BhaRfkdRIvuHHPFNFXC27 bZNHpCOi2ojaZc2KvuvyY2cQ7aXqq0oWEvSWu/CslTOdTfgp+luFTaFDTAXoFMtI2NkR fNvKCJYz+BcD1KnE6ztYyrbXmBbXTq+rkUEIF2YiMbWZ8U4RiuoPvqvFK+cmwIvS6a+S 01eg== X-Forwarded-Encrypted: i=1; AFNElJ/oaVv9QAEalyxK9dZ3AHzO4r5A+W1RDEqAWRk+MnvPRHh0ZkF+f23sYRW0oyUXLusFrQ+tuzh9AEyGGxQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi0b+8eduyvB2Bdhacs2RDNUdN++WSq2h3tEEVL1AN0Zui2Xvg kvCMh7lwfyCR5oz+08aAbjq3uSwOZHyqiB62JVDxL2FLK7OkuVn8U2xs X-Gm-Gg: AeBDievE3lDLhI9o97irl4RBHOAPIA5v6FMj74Rsg3cXxYHsc5kpjdGjg0LuDcrVQbz KyH8WdAaxcPaI8Amgn9ubwTQzaA74MwYJRU7X1F0C/M7QGZhhAxCLk1rXz4Q5Uch/L/nQ52o94j cX1vvIfYRVleVqv6/eLcO16FEuBy8dETrvWTk4L95VsTIjwOBLWB6pVKeoBXI9t2k/ir514gD7F OR0JGF+fyY5ZJJUp8RvDQpJYD41BOrH46yyrEDDhtYc5gi2xeJzSCNvDpILaMsxchVL28BMbAU+ doR1qsrpd2mmW7bRMUG3iD3w9cDpI/aobUTI+mDaTxTWkrgMU2ZffkElNo0lgCbR3/t3XXyPIWT lqBoCTK/pEr7OrpakOIRWFzQ0jWGhuOhbkXR10X4by8AZqZXezYJt9nkAZMlrcntTKK4oVf6PAE PXMr58Z9kwBLoEfBE= X-Received: by 2002:a05:600c:8b65:b0:48a:53ea:140b with SMTP id 5b1f17b1804b1-48e51f4e5fdmr200842415e9.28.1778221073991; Thu, 07 May 2026 23:17:53 -0700 (PDT) Received: from ROG ([2a01:e11:202b:40:68b1:8d59:e348:c16e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e68f5d48fsm11251175e9.14.2026.05.07.23.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 23:17:52 -0700 (PDT) From: Marco Scardovi To: andriy.shevchenko@intel.com Cc: linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mathias.nyman@intel.com, mika.westerberg@intel.com, Marco Scardovi Subject: [PATCH v4 3/6] gpio: acpi: ignore out-of-range pins in acpi_gpiochip_alloc_event() Date: Fri, 8 May 2026 08:17:26 +0200 Message-ID: <20260508061729.9530-4-mscardovi95@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260508061729.9530-1-mscardovi95@gmail.com> References: <20260508061729.9530-1-mscardovi95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a check to verify that the pin index retrieved from ACPI is within the valid range for the GPIO chip (pin < chip->ngpio). If the pin is out of range, an error is logged and the function returns early to avoid invalid memory access. Signed-off-by: Marco Scardovi --- drivers/gpio/gpiolib-acpi-core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpio/gpiolib-acpi-core.c b/drivers/gpio/gpiolib-acpi-core.c index eb8a40cfb7a9..e53d68578024 100644 --- a/drivers/gpio/gpiolib-acpi-core.c +++ b/drivers/gpio/gpiolib-acpi-core.c @@ -370,6 +370,11 @@ static acpi_status acpi_gpiochip_alloc_event(struct acpi_resource *ares, handle = ACPI_HANDLE(chip->parent); pin = agpio->pin_table[0]; + if (pin >= chip->ngpio) { + dev_err(chip->parent, "Failed to request GPIO for pin 0x%04X, out of range\n", pin); + return AE_OK; + } + if (pin <= 255) { char ev_name[8]; sprintf(ev_name, "_%c%02X", -- 2.54.0