mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@kernel.org>
To: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Joshua Crofts <joshua.crofts1@gmail.com>
Subject: [PATCH 2/7] iio: light: opt3001: use macros from bits.h header
Date: Mon, 11 May 2026 12:04:07 +0200	[thread overview]
Message-ID: <20260511-opt3001-cleanup-v1-2-f7879dc3455c@gmail.com> (raw)
In-Reply-To: <20260511-opt3001-cleanup-v1-0-f7879dc3455c@gmail.com>

From: Joshua Crofts <joshua.crofts1@gmail.com>

Use GENMASK() and BIT() macros from bits.h header where it makes
sense. While at it, remove unused macro.

No functional change.

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/light/opt3001.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c
index e6c3665f46be47129097c3997c7551ba9a8f6440..47f0e01a95e772954de0f1337ac0d881b8b32de6 100644
--- a/drivers/iio/light/opt3001.c
+++ b/drivers/iio/light/opt3001.c
@@ -33,17 +33,16 @@
 #define OPT3001_MANUFACTURER_ID	0x7e
 #define OPT3001_DEVICE_ID	0x7f
 
-#define OPT3001_CONFIGURATION_RN_MASK	(0xf << 12)
+#define OPT3001_CONFIGURATION_RN_MASK	GENMASK(15, 12)
 #define OPT3001_CONFIGURATION_RN_AUTO	(0xc << 12)
 
 #define OPT3001_CONFIGURATION_CT	BIT(11)
 
-#define OPT3001_CONFIGURATION_M_MASK	(3 << 9)
+#define OPT3001_CONFIGURATION_M_MASK	GENMASK(10, 9)
 #define OPT3001_CONFIGURATION_M_SHUTDOWN (0 << 9)
-#define OPT3001_CONFIGURATION_M_SINGLE	(1 << 9)
+#define OPT3001_CONFIGURATION_M_SINGLE	BIT(9)
 #define OPT3001_CONFIGURATION_M_CONTINUOUS (2 << 9) /* also 3 << 9 */
 
-#define OPT3001_CONFIGURATION_OVF	BIT(8)
 #define OPT3001_CONFIGURATION_CRF	BIT(7)
 #define OPT3001_CONFIGURATION_FH	BIT(6)
 #define OPT3001_CONFIGURATION_FL	BIT(5)
@@ -51,7 +50,7 @@
 #define OPT3001_CONFIGURATION_POL	BIT(3)
 #define OPT3001_CONFIGURATION_ME	BIT(2)
 
-#define OPT3001_CONFIGURATION_FC_MASK	(3 << 0)
+#define OPT3001_CONFIGURATION_FC_MASK	GENMASK(1, 0)
 
 /* The end-of-conversion enable is located in the low-limit register */
 #define OPT3001_LOW_LIMIT_EOC_ENABLE	0xc000

-- 
2.47.3



  parent reply	other threads:[~2026-05-11 10:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 10:04 [PATCH 0/7] iio: light: opt3001: driver cleanup Joshua Crofts via B4 Relay
2026-05-11 10:04 ` [PATCH 1/7] iio: light: opt3001: make headers conform to iwyu Joshua Crofts via B4 Relay
2026-05-11 10:04 ` Joshua Crofts via B4 Relay [this message]
2026-05-11 11:01   ` [PATCH 2/7] iio: light: opt3001: use macros from bits.h header Andy Shevchenko
2026-05-11 11:07     ` Joshua Crofts
2026-05-11 13:21       ` Jonathan Cameron
2026-05-11 10:04 ` [PATCH 3/7] iio: light: opt3001: prefer dev_err_probe() Joshua Crofts via B4 Relay
2026-05-11 11:04   ` Andy Shevchenko
2026-05-11 11:11     ` Joshua Crofts
2026-05-11 10:04 ` [PATCH 4/7] iio: light: opt3001: move driver to guard(mutex)() use Joshua Crofts via B4 Relay
2026-05-11 11:07   ` Andy Shevchenko
2026-05-11 11:09     ` Joshua Crofts
2026-05-11 10:04 ` [PATCH 5/7] iio: light: opt3001: localize for loop iterator Joshua Crofts via B4 Relay
2026-05-11 11:09   ` Andy Shevchenko
2026-05-11 10:04 ` [PATCH 6/7] iio: light: opt3001: remove unnecessary comments Joshua Crofts via B4 Relay
2026-05-11 11:11   ` Andy Shevchenko
2026-05-11 11:14     ` Joshua Crofts
2026-05-11 10:04 ` [PATCH 7/7] iio: light: opt3001: switch driver to managed resources Joshua Crofts via B4 Relay
2026-05-11 11:13   ` Andy Shevchenko
2026-05-11 11:17     ` Joshua Crofts
2026-05-11 13:32   ` Jonathan Cameron
2026-05-11 13:37     ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511-opt3001-cleanup-v1-2-f7879dc3455c@gmail.com \
    --to=devnull+joshua.crofts1.gmail.com@kernel.org \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®