From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 940383BED2D for ; Mon, 11 May 2026 09:20:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778491238; cv=none; b=EXGp/C2YuJOusUcOYp7QQ60IF0lYMdVCE44ca6tcR2UYKUcjBWs4zzWijsdcycPE3HEiIG/pnGYuxuMuL9dNEOFz8dZAYj2VKXaRfYZ+pDQUEoljZra2ZHaVpdeC+GoD8pDm3wHNFW6LdBvVywyJFQqSU1vacOeD6S/e8HMNYTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778491238; c=relaxed/simple; bh=QZuxmCrKzUY9/4DJZBvW/RsakTj7/Vxp1bMSYyTjHRU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P10XUfIWFZthlbwg6uWUzcg0Ga6aB1eGzpe1QV44/aiPYgjC93erqTlqKNKWp0M/qTfG6Ri7vhN6od9OFzvAjoT25F1Q59FItir3mz0g60ADLrIFfYNafIIyud2ThknruIWEqSMB3vszF/rm3rjNxOfxX6aDzwa9b/IUB9N+jj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jB0kE2os; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jB0kE2os" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4891e86fabeso48074475e9.1 for ; Mon, 11 May 2026 02:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778491235; x=1779096035; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8uKDFDq6E8/eD48OfK+PZznOc+DyNeOaGLJOIQrrNXY=; b=jB0kE2osLOr+Dk83W82dX+mQpF19Ns8nUH6q2iYx+DPIJXkvUSMLy1vy00bv7mKJ2L keazgK5wdch9ujVGp6z8zduPweE/HM5mlT5pm0NnNULzokM+3AGTqMtmh1miKgze43su nN9bWLpYN5FG04AoUMwrNU7rCFcB+ZfeqX+96FRh0b4/D+3q8SYzENq0C150tF6xdBEr 8xGVsSVhjdy8PhQpnGOz1EFs1da2bHgcb9FYLrz4E7FoL5UJrhK6ZDqbNiWOgtZEzeF0 4i2U0Hh8DSEsXeYOCwLuno/wvwYhGMhrFY6bdcUVTtrZwXRpPSI1AkWJUZfZKzuuEq4z ixzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778491235; x=1779096035; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8uKDFDq6E8/eD48OfK+PZznOc+DyNeOaGLJOIQrrNXY=; b=YQMw/TDpkxRECdZBFdrm6Rpdfzavu2+i/VC+Nk+nanSFjykHojziGaw8PFPcEhMukH aLhzD5otUYRyXNkmJY/qwWYj6g1T0IeIrf75D2IASc9GUqioj8rTKhMYus83Pl6UToV0 zjm5qA6BnhX2Ufou47dWyLejzRCW/QO4EUHncXf2bXuBE5QgCd+ayYGtxRlgy4jnfHh7 6EIbl3zQ7LZwRaKqQoYyDtJMbq9LS1Z+cW2ktnfdqOhFnlKMh5OTGVWmAdpdTm8uBnbP YbiCUK0roOJZRmzgCueH0sDa4t3f916A4LrpBwwTFabXldvCgmKh9YmFz5s9+Dsbyxjf dHPw== X-Forwarded-Encrypted: i=1; AFNElJ9F1IjonRko+qN8fcKoGZ4xBtoxXAdHymI6QZi4LrSCiM9BDvYDXz3dck3sl+05dA5RNgPXfen3TqtqhU0=@vger.kernel.org X-Gm-Message-State: AOJu0YwIfCcmS8rChhRpKVxuDxQXlAHPHqbo+u7pKXNi4zUz0PNL+Xl3 LZ9ecMrwRqhgXM6zDBRrlVl9rB/Km0uHXLmrONC1hZKIturdZ2D9RybzKJMXOBXP39c= X-Gm-Gg: Acq92OGCxqGjMxhL68JBQdCKm0LDWt/fsnGmc9vDkzjybah77nyD+APJAueob9lWPvh zmQP8ZZqQuC5uP3KdeU9qJNe61U0uf+Vv+qb1I5juJ6LvYE6BPvi5XTW6D1bkYs1+FjD3cnEnFi PSyb4KG9NXDBMpnsenB3xM1fz2FffUQDbT6HaxOJblF02afCg/yAlEXnmRz/SqL2KzP5FHgaExD w9oO3gCQhpqDgIICzXOynTAH55l5YD6rvbxiVsJrYLyirMBbniNt5iq/MqejQ6DN9Y6kCi49F3n MfOdNyVwDPuludZQ/NUHRs1Vo3fcMDdSmckhjBgya58HtXcyOSB/LKsoHvziKm18pccLkgogi+G ZNOlKpQt7ypCKpk5+P+7scsgsKNV6CEb1RKYcvUbfnd7meQPUKBbQbyrPQYbPj67LeYmk19y7Dk JMZs/lis4AKrJPlKh4gUfejWtYZCFifUN+j1ixyzXvqiCLGCgiHd3eQUM470iCj+XWFA== X-Received: by 2002:a05:6000:290f:b0:43d:7af0:3a7c with SMTP id ffacd0b85a97d-4515d3dc24cmr36669919f8f.29.1778491234498; Mon, 11 May 2026 02:20:34 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:106d:1080:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4549120ec0asm23743240f8f.17.2026.05.11.02.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 02:20:34 -0700 (PDT) From: Neil Armstrong Date: Mon, 11 May 2026 11:20:30 +0200 Subject: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260511-topic-sm8x50-iris-10bit-decoding-v3-5-7fc049b93042@linaro.org> References: <20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org> In-Reply-To: <20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1866; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=QZuxmCrKzUY9/4DJZBvW/RsakTj7/Vxp1bMSYyTjHRU=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBqAZ9d9BsAPVj1mBVZ+AYXUx2sn524eS3AODUszxx4 KW545AqJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCagGfXQAKCRB33NvayMhJ0dSxD/ 9EW3HTL0vDojNVspto/DqfUz+dZnPXlgKd4cCHR72RhQclrmBNfexxUoZqU9mxmGY0/lPkIftsz1zT 4O8tSVaZpThR5Ds5CS+TMWxuUj8HtcrQisMaBTmqOKiBVUB4Tf/50CNjTk3hvpx5x5OJLYFEANlD4S JLlRg65qHzPBB40XAqbJH2W3RQAjc4gC6hgm7fFoyI5cxmzliAwDb2rWEbxXFYkdkIMbrk9H7eZj4z aO6NYRjnVjshJQL0DdloVNScd/lY+8LQKESplWQVOJ+EzdpVknUy/yVo9GwDlS3kX8PnKkw7fbBgtt cOSelzRccijlH50wEYJPm4hOatLN1n65f6JJ33L5OGrxehfLWpatyjRVWmPNEYkM4U+CrS8HAZClub LN6iLCICGNcqHtDqzHBFv3OxADMD3bCrb4jhH/b5qx+6FKWKolzNE5eFh1QxtZyM0UiYzrdjYHSAlg bANWxUkzearxKBGLMIM2Q0QsuQD/BhXTinvMtQ/0x+9bXoyNoP80TyL6E+eWenHIaM4lkRQr5196PV PbSKAyu0ayhq6sSyA7IwKtj+1qkPI5bS0TyXa0wAiZPm5+nPlY4dQ+bU3X7aazvGqWOhspDI9pwmd5 fiu0YzJeibPnSPmYglYtha8JLTibFiqVcuaIQYDnDnPsBp1UWqsN2CRCG4qg== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE The 10bit pixel format can be only used when the decoder identifies the stream as decoding into 10bit pixel format buffers, so update the find_format helper to filter the formats and only allow the proper formats when setting or trying a capture format. Signed-off-by: Neil Armstrong --- drivers/media/platform/qcom/iris/iris_platform_common.h | 1 + drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h index 5a489917580e..cd3509da4b75 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -18,6 +18,7 @@ struct iris_inst; #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma)) #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8) +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10) #define CODED_FRAMES_PROGRESSIVE 0x0 #define DEFAULT_MAX_HOST_BUF_COUNT 64 #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256 diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c index eea69f937147..f4d9951ed04c 100644 --- a/drivers/media/platform/qcom/iris/iris_vdec.c +++ b/drivers/media/platform/qcom/iris/iris_vdec.c @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt, u32 type) if (i == size || fmt[i].type != type) return NULL; + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) { + if (iris_fmt_is_8bit(fmt[i].pixfmt) && + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10) + return NULL; + + if (iris_fmt_is_10bit(fmt[i].pixfmt) && + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10) + return NULL; + } + return &fmt[i]; } -- 2.34.1