From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 335CA4D8D96 for ; Mon, 11 May 2026 22:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778536920; cv=none; b=JXqe1cChLzF3vkXIlkLiKvaczWMP+nliRYxJ0Oa3TYa3eNTkBDtOF7ZOnTYFiNYus57qH/eL05FPdhHgzzVfr8z9+MdJz7slKTPQ5aQ8fAVlkfkw07+Tlgbx/y/V6D1mAogvYFTVHzSIfWciCr9j7ly7knrgjzkrg5v8qd0MCV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778536920; c=relaxed/simple; bh=9afZ6DUJ1CXOVWQg2qqUUq5G7YQmIffoUiGOW9svvL8=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=Vl6Gip4yKUdBhmsPYk/oNuX62EYDTmBMmmDpj2fyskWPGfhXDX0cONXV/iDgx/XiIg3HGUFyZF/uDwbpfIMw6oYtdS5JESiVEQox1+tACHVTemlulu1hpf0T2EG2sR69n5xhCoAlF3ve5jIUjMxCnrRQkCFGTnmWyiCmN2zQ0Wk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=UWZv84Lm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="UWZv84Lm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C164C2BCB0; Mon, 11 May 2026 22:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1778536919; bh=9afZ6DUJ1CXOVWQg2qqUUq5G7YQmIffoUiGOW9svvL8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UWZv84LmnzGTG7Kd1faAV3wNjLP8AbNMbGUXadbla5+FnPj7aFnJfb3Xjbaw7ND5j j85EHFigoi71KVx1zSRP0htOAqoH4KoI7+yG/WAqP3R0BVwhp6NQEYvFR+Igm4arBO lA4D1FL+yNtmOo1QFp+aMrUiGjSYQK48Gc3PwSVI= Date: Mon, 11 May 2026 15:01:58 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: Baolin Wang , hughd@google.com, willy@infradead.org, ziy@nvidia.com, david@kernel.org, lance.yang@linux.dev, wangkefeng.wang@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "tmpfs: don't enable large folios if not supported" Message-Id: <20260511150158.921c0ac72b31a6fa0a125ab8@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 11 May 2026 13:03:04 +0100 Lorenzo Stoakes wrote: > On Wed, May 06, 2026 at 04:58:20PM +0800, Baolin Wang wrote: > > > > > > On 5/5/26 6:47 PM, Lorenzo Stoakes wrote: > > > On Tue, May 05, 2026 at 11:46:11AM +0100, Lorenzo Stoakes wrote: > > > > Acked-by: Lorenzo Stoakes > > > > > > > > As David asked, should we have a Fixes tag? What about cc: stable? > > > > Sure. But this fix tag depends on the commit 665575cff098b, so the fixes tag > > should be: > > > > Fixes: 5a90c155defa ("tmpfs: don't enable large folios if not supported") > > Depends-on: 665575cff098b ("filemap: move prefaulting out of hot write > > path"). > > Oh is Depends-on a tag? Wasn't aware of it :>) It is not. hp2:/usr/src/25> grep -ri Depends-on Documentation | wc -l 0 But it is! hp2:/usr/src/25> grep -ri Depends-on ../gitlog | wc -l 156 I actually removed it because a) various tools whine at me and b) we didn't cc:stable anyway. Please let's not add new metadata without having told others what that metadata means? "Fixes:" should be sufficient. I interpret Fixes: as "apply this to any kernel which contains ". Is more needed?