From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAB69477E28 for ; Mon, 11 May 2026 17:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778521517; cv=none; b=On5a9J25b59/d8twFrbIT5IMwFZQTzldACUEDN6bGtZLfEnK2MQWpmLAtFQvRF8jBADVLUysQpofS0kcLJ5DfszHVPa7zhXy4l0pvDnTy/ompzLlILV23YJPJIo1Ro8mNib2OO43LAehHrzmHXrwVO1Ofou2ZLGmwvRls4Zdp4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778521517; c=relaxed/simple; bh=fC6+iF3wZIOJ9jkDKq6JyJEIBQEMNM9kicOyuc7ikR4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RH+zvWun1Rvcg7yMmUXrOBhaXgaMhO/PyMt7lt1YcToq4oKmc767xw5vKHpz+Iiw+x5eTTzF3aM+tneYG53jmSFgoBdcVGwE0h/D1c3cn35cgH6o7J7AwjLXoK4yz2Zadk8LPATtZHTfbvh0GxynWP3dDHIAzN4HGxZ2/SPqEFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lKy1Ookj; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lKy1Ookj" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c8027e876fcso1835833a12.1 for ; Mon, 11 May 2026 10:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778521515; x=1779126315; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UXBbj7mUNYlbg4rkKVQUy4THqQa8ssCmEHhDW08Rios=; b=lKy1Ookj0ytwjxknS9RLNUTP2b8a3jvMOa+T5gSV8t6jqcLLMmsLHBb9nMKgMDmAqc VbZYjcnozGjxtUWm/zKSkU4T/w3DRVzuFoK5gpCb3QOo1tjbZYBkKmmWIg5GPXRwZSYT xlmRJ5ovDcmQnhHS4/5F76p8ypN0jyRfSO7N001kmtRTMoXuX2UokJta4gtzhZmCF/xK DjIRiPBy6v3fDvRcshAr2I4MgEOWSYqWW0PS0QKQSQVeVFS04P0TH2bU7CJRK4HiFxjx qbrBSu0oOjdNl3IFQ5oYutpR+LKHXDQEtbrcFHnrhW8sZtl3UdmiVEYuAcTebFUrSTaA OK5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778521515; x=1779126315; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UXBbj7mUNYlbg4rkKVQUy4THqQa8ssCmEHhDW08Rios=; b=BkbmQ8U13zt81rYKl8Y2/BBnan5cBcFkN+AN4OVVUr8c1DH7W+GbPrhVYqb9AbQ3pY kBG4Uk4bxgUXociuR3iAEDnouauSPJcrIVfB8MX0V3jdCmgk7zvkJRn8UVN5S/13S3H/ fnFsGh1Mat8Sh5Z8POfDyNg+CWOanc/tcnvtEXaO7vccROB3itoCoVHqEdhtCwFF7q85 IA32cek5zgfbp983KhesBW/WE9/LKMGjetlhumqt7IDd5fo7ZTsJfLhknB3Mv5BKdp0w 63xec/jn27rppyhmNr4wdRT9M2AmiNk7P9SH6fhN5TINeVsDsB5JLNrFOgobF1R5MCwU 8ooA== X-Forwarded-Encrypted: i=1; AFNElJ+4M5nKLWIgO6mIkrGaR1g/B9V7apF8aEzEsAOeMveAX1EBN63BnaglXrlXa2YBtBt9n+nN4S095Zb+gkg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6trDrT3T7d6iILVTxZHSDzsdcRRYXTWfiSQ1pSxkTWg1eNwU3 5YPxLUhkk0133AAM8LXkljNqb2aIj4xVlqNvSRB0Rg3G4UoxBX4WDspY X-Gm-Gg: Acq92OH/x5M7GVi7e2jrvm/jGjxavNoydND/tFsL9h/VU/9VTbTxNGh33YgE6D0+vsq cEZd28AWVBctVBArmxgCSN+nvbnRnk2KUIu+nLbnQTQHKzPqZel+MuO5vJa8uHs75hEwimyAHN0 eDmkYnclK+OmKApjFTXHdszBvlTTmjDY8wbeDdmlNIOVjhBlBNaVWFTdqi7WlzSbbA1S67F11ff kgwSXQktLya4SycxzYBn0vqpKKvtOYn2jXJ0RIf5Ttpvb9RDKIfq1PuCIS7lQfdgqO8vU2b1Fmw tAB7d7lNcAVUInDEdtyxVkCm+pZxINuCKPZ2wH1VKhxLZkqXpNoZBBfGkiTa04atyRNSgJGvZGS BLBHoJxIo8/Hz105qyMmH8Kjuwsa+LPZuNRZvGp7uWxQ20bUUtsa3UiD1VuJF+TUCwRZ7qXNMP9 wXSrYKNc0pJGQUbswIVSOYU5jVY6LrOyY322H+mNjJwxOWiq4509xQWMhQOL64B9MKFDtu/FDl3 AhrfK2rPJ1wf7v6t13KhZMA0rNsVrr2z2ve2BLm95NtBMq5khtocHeroiY0IpHopALb6fY= X-Received: by 2002:a17:903:2ed0:b0:2bc:b80f:677e with SMTP id d9443c01a7336-2bcb80f698bmr73240535ad.25.1778521515128; Mon, 11 May 2026 10:45:15 -0700 (PDT) Received: from lord-daniel-VivoBook-ASUSLaptop-K3502ZA-S3502ZA.www.tendawifi.com ([14.139.108.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e365a1sm106838425ad.44.2026.05.11.10.45.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 10:45:14 -0700 (PDT) From: Piyush Patle To: jic23@kernel.org Cc: ak@it-klinger.de, andriy.shevchenko@linux.intel.com, dlechner@baylibre.com, nuno.sa@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 v8 09/11] iio: adc: hx711: localize loop iterators in hx711_read Date: Mon, 11 May 2026 23:13:34 +0530 Message-ID: <20260511174342.123820-10-piyushpatle228@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260511174342.123820-1-piyushpatle228@gmail.com> References: <20260511174342.123820-1-piyushpatle228@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Tighten the scope of the loop variables in hx711_read() now that trailing-pulse selection is already handled by the callers. Also replace the 24-bit loop bound with a named constant while touching the same code. Suggested-by: Andy Shevchenko Signed-off-by: Piyush Patle Reviewed-by: Andy Shevchenko --- drivers/iio/adc/hx711.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c index 9e5cafa1e307..0db2d2db9242 100644 --- a/drivers/iio/adc/hx711.c +++ b/drivers/iio/adc/hx711.c @@ -23,6 +23,8 @@ #include #include +#define HX711_DATA_BITS 24 + /* gain to pulse and scale conversion */ #define HX711_GAIN_MAX 3 #define HX711_RESET_GAIN 128 @@ -157,16 +159,16 @@ static int hx711_cycle(struct hx711_data *hx711_data) static int hx711_read(struct hx711_data *hx711_data, int trailing_pulses) { - int i, ret; int value = 0; int val; + int ret; /* we double check if it's really down */ val = gpiod_get_value(hx711_data->gpiod_dout); if (val) return -EIO; - for (i = 0; i < 24; i++) { + for (int i = 0; i < HX711_DATA_BITS; i++) { value <<= 1; ret = hx711_cycle(hx711_data); if (ret) @@ -175,7 +177,7 @@ static int hx711_read(struct hx711_data *hx711_data, int trailing_pulses) value ^= 0x800000; - for (i = 0; i < trailing_pulses; i++) + for (int i = 0; i < trailing_pulses; i++) hx711_cycle(hx711_data); return value; -- 2.43.0