From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B4AB47884D for ; Mon, 11 May 2026 17:45:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778521524; cv=none; b=jvtRJppqplTpIMnKG38djOiX/hghuzHwDuGUyQQUbVQ/DQUCrONifwvCdrpRcoWrFxru7OOzcL8ZgWHqCuGAlXnozgQL52idn3bQDYFND7Ym97VXp6nWcEbjzLfmzu2MS04XAmGufvTgwaT4o9opinHoVD8K4juqHtEtBDE6DXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778521524; c=relaxed/simple; bh=5k+SnEgwLcoE/m9oWbMPiYN8XaRjygHFU88BagKW3cQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZmLkqP/iIqBB1fzxWwC8SdIyULTtfcWp15a25jGOEFjFhDijlsSc0+LsqM6mu2tWuMQejKhFknb/OSAfwTqik32Vmnotw1r9s62jALnXG4kWFfVIGogtGHeS8VwEj2QD+7VboENatBmit7CMV6UA+wucp2kAT0cFdxuDSwOKkLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gfu4YBdU; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gfu4YBdU" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ba4a1a0325so32832435ad.0 for ; Mon, 11 May 2026 10:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778521521; x=1779126321; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=beKvBN1aF04rHKZBL8DcVQubUk4t9ZmlxiCzX/vBMwk=; b=Gfu4YBdUNYV0IYPX8YornMdAkct1IB9M3kDNcc4CFcurHnR7AOQQL4dFGft9kh0fO2 Rx/Q30ziLvXjqm3vhftlpgtvXN707tuv8G1xT0hduWPVmjQ9xGD3639Sy1eOsGwhCO6a qoLsJyios/eFUxWCmqI1rXss5EINME8Ht7G9f56uHfzih5SQ9jPGG/K+BOF7X5kNZPBA ZpWandFN9jb1oizWSee6ZS70/dcVBUzBYQkQamTZrFk7hkmGJ14jkHgeN9yl+pCOs8uc DOd/0hrN9QTz4HiSxkBnmikZI3yARQwR26ITeYhw9ubIqCNTtl8hqLqmgAXUkGyd62+Z tsAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778521521; x=1779126321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=beKvBN1aF04rHKZBL8DcVQubUk4t9ZmlxiCzX/vBMwk=; b=j4JFG8VdfmXgZSVmAzlaMQfFbiOFZGpPs84IVTkPpA/voxQRpWvXswQ2Bm12t2vU0N 8SxeQUobc37Wj47nIPc98eOQB/THHL9BThpeYvj7kXVpCgBZ7ibK4yfFTacwFcXi0Ni8 mNBUHpJ2D45HHu8WfeNtEdmBr5LOMUxaGbBEq9b7MYrm+WuTBoVJTklCCGgvctFDu0fJ 6xGLNmtmajvt0FPffwWGoo3VdtIWX17Z3Z6GUb7ltsVLnBe7i/OB3VIKgA0E+RNGL8lm HEQJDPzUy9AJRmymZYP7Qd7QOTH2K8IUtDszxwyLEowGMav+YPzXQ8EIfM4UThnTr8Er kpag== X-Forwarded-Encrypted: i=1; AFNElJ8F+EUUuWCcLOGWljgivhSjj29mtNanhv0H7hsVM2OmE1EIPBgodcWfBh5BCFjHx1sJBrZY3wV71iXQ06Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwYU9S7fQUSNhAvyjEw1ZBHtU9h9VlCj7Y6QuKuQCpHdQlaWtMG /wGYkOo9aryouDVJR3PpDOAAccPYaOqTiT4CcYTzfDiSU0bwK9MIF7QJtt4hVw== X-Gm-Gg: Acq92OF7WoDcl0Td0Uyv6+9hNAUlLmTDs5hOmbXYFkL9MD8fbhQgaNhXxewZ3skcFO1 YFtw0T4NpJG55VyIsrVV2Igen1fyjJTbOqJ15ua3RZqSSpKonfReMj9SisGusY7IA/Zbapfp9zF 2bvyaWISl3/GFjYa8/ThKxPnVKZs28TfAbqeVKO/zzs0Pfsid7C2XN6sre3CQxdsOsfz1PBcM0t lexhbpPsxtpGr9KIOr5qYXIDPCAAv3nGETAvEk+3lv4UO6O67xV1nXFTfc7mzRvGzk89EEVMHkN ow7cv527vZ9aS4xgFJ7qMCHiaJyoI4P1ENI0TTeDHTLn7l+ns/Snhx3uBj8bvB3nFIk+ccYAef5 wpMrOeIW59iYKPzYZwzukm5+RqjMetCK/AmiGjv3I8ktH7DSLM9lRrBR4RCmJ1cfRqLkQd+Xq3m zi+J4fiBvuCAu5D0lIx7eqXAKfty0Y7kMADb3X+JtXWXWYQ7XgYKZ8cmz3oHcYXBWdVEW9qQSr3 S0rHtCaBkG8HAX7qm1Hx5vtkdl58ktWe3ojNff0Cp72nTokx2Oi4O62Mcto X-Received: by 2002:a17:902:d2c9:b0:2b2:4d36:7aa with SMTP id d9443c01a7336-2bc7ac4ed26mr117712555ad.35.1778521520774; Mon, 11 May 2026 10:45:20 -0700 (PDT) Received: from lord-daniel-VivoBook-ASUSLaptop-K3502ZA-S3502ZA.www.tendawifi.com ([14.139.108.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e365a1sm106838425ad.44.2026.05.11.10.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 10:45:20 -0700 (PDT) From: Piyush Patle To: jic23@kernel.org Cc: ak@it-klinger.de, andriy.shevchenko@linux.intel.com, dlechner@baylibre.com, nuno.sa@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 v8 10/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read Date: Mon, 11 May 2026 23:13:35 +0530 Message-ID: <20260511174342.123820-11-piyushpatle228@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260511174342.123820-1-piyushpatle228@gmail.com> References: <20260511174342.123820-1-piyushpatle228@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change hx711_reset_read() to accept the channel descriptor directly and update its callers accordingly. Split the existing HX711 channel-selection work into a small helper so a later variant-specific change can add a matching helper without growing hx711_reset_read() further. No functional change. Signed-off-by: Piyush Patle Reviewed-by: Andy Shevchenko --- drivers/iio/adc/hx711.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c index 0db2d2db9242..183568196d52 100644 --- a/drivers/iio/adc/hx711.c +++ b/drivers/iio/adc/hx711.c @@ -269,7 +269,23 @@ static int hx711_set_gain_for_channel(struct hx711_data *hx711_data, int chan) return 0; } -static int hx711_reset_read(struct hx711_data *hx711_data, int chan) +static int hx711_set_hx711_channel(struct hx711_data *hx711_data, + const struct iio_chan_spec *chan, + int *trailing_pulses) +{ + int ret; + + ret = hx711_set_gain_for_channel(hx711_data, chan->channel); + if (ret < 0) + return ret; + + *trailing_pulses = hx711_get_gain_to_pulse(hx711_data->gain_set); + + return 0; +} + +static int hx711_reset_read(struct hx711_data *hx711_data, + const struct iio_chan_spec *chan) { int trailing_pulses; int ret; @@ -283,11 +299,10 @@ static int hx711_reset_read(struct hx711_data *hx711_data, int chan) return -EIO; } - ret = hx711_set_gain_for_channel(hx711_data, chan); + ret = hx711_set_hx711_channel(hx711_data, chan, &trailing_pulses); if (ret < 0) return ret; - trailing_pulses = hx711_get_gain_to_pulse(hx711_data->gain_set); return hx711_read(hx711_data, trailing_pulses); } @@ -301,7 +316,7 @@ static int hx711_read_raw(struct iio_dev *indio_dev, case IIO_CHAN_INFO_RAW: mutex_lock(&hx711_data->lock); - *val = hx711_reset_read(hx711_data, chan->channel); + *val = hx711_reset_read(hx711_data, chan); mutex_unlock(&hx711_data->lock); @@ -391,8 +406,8 @@ static irqreturn_t hx711_trigger(int irq, void *p) memset(&hx711_data->buffer, 0, sizeof(hx711_data->buffer)); iio_for_each_active_channel(indio_dev, i) { - hx711_data->buffer.channel[j] = hx711_reset_read(hx711_data, - indio_dev->channels[i].channel); + hx711_data->buffer.channel[j] = + hx711_reset_read(hx711_data, &indio_dev->channels[i]); j++; } -- 2.43.0