From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93F6A1DF980 for ; Tue, 12 May 2026 04:49:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778561359; cv=none; b=hcFroVj3fxfWUwSOqxCDZjHnNhzI4WN2nNT9WIRcxejb9y2nlPZgXAFdyD7st2gpvw6LDAQcdSSt9Bc4NhEWP1t0Mvw02l/5K3ogKsjYjXuyaauqiDUoSTvJQ6z+BhcfblhoaqEy1qZDos7Kj2iyoTuIEFJuXZnCe5fD0aShrDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778561359; c=relaxed/simple; bh=FBmut5npg4s4ETQF7AKszdVuJ/TKr9w3qW2XrxuPKKA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nUjzcbF1/y6cfRMA6DKVXCD7Q12kihhutSH2S+Bozv01y109/jvRJyQMgwlyRBjk/1B77+E9EdhFNf+txVQjHMEBlPd0akO1vSN1ecc/ABV6RLhpaNP7pXV6cQJ8qdKw6vtUi4A2NuwvRhUCzbR5BnZGKMBOTRJOxceOzKfZXo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IuTmsgVL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fp419KCV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IuTmsgVL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fp419KCV" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64BK6maE3384827 for ; Tue, 12 May 2026 04:49:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=mHl7ymRRDRRCpw1X3DdWS0B92buiELgNhVr 2GCgQ7XQ=; b=IuTmsgVLRTBuwG/NZ10a8ErPvEdLGXpR6gLAKm0Jjzj5W1cRUnG +EslD/mgibUyA/SQqUWkgQvCna7+zO+oxadMQ2DOt5qMoUKHesk+d8SEQe2KNhko rXrxo2G1CyL4jieuHCIYJf+GHHJvLIbTePZwSsVG40Do/uo6AFy3y2BXSa+qF9mh PGHuZaJNsmIr0Xg5yJD5Juy01w1IKIv4zlk5kQsiIiLiy8oldUu/opKp6X2xHy09 4k9TkIVfcM2zLupt03SC5vOEj2LSmKbYW2/0ohUINLGB3EWbA9U6YtrtNX8Sibp8 TDnmM60JVa6SjkFn1MMhz/rwMvRY4Tpt3ig== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e3nv4hfm6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 12 May 2026 04:49:15 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2efc342ef15so7117031eec.1 for ; Mon, 11 May 2026 21:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778561355; x=1779166155; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mHl7ymRRDRRCpw1X3DdWS0B92buiELgNhVr2GCgQ7XQ=; b=fp419KCVZGYsccxr+Jq3h5sa2203eVOWIOfyz08ag9YSo/ImQPZmjC59nX7byeagSn 9FMXK0lSngSvrQA8eQIGNDaN0pLMKddZrEXA0GpTot5vnFnSbYjq/mAlptgGdDmNuSF4 SHvM+WlKZS0c3MZJ4prkkhN9u198flptQ4TAuBUbTYod97v77++ECOsBu1PNGVR1akPh Ux33IMGuCYG8GivZd5xwBOekWuIAgiseOI2OoXZPP1txwSw13qYNKTNX84PTIUxlmBA8 OfgdPNN38QoAkgQzfY5TyJbjKcMJUWFrA5xGv/fJcfs7itPm0xrOhnWkQm71lQpau7h8 YX5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778561355; x=1779166155; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mHl7ymRRDRRCpw1X3DdWS0B92buiELgNhVr2GCgQ7XQ=; b=UeIu9gMI+sUYOqczDIme1EsD5oPGtkwJ18o0YoArSXVrnfvk3ApWPcIaUtsQOWiprP X7Ydr2yrNzbO7q9pD6UnRtCVF1NsgUocLYi6kAM9e4y9XMsAt0+HYXlTHKuiwUNyd3/V 5BvrIRSNZ+U0jmU2uQvDGsCfJu5AG5/flVYImodph0WxScE5x8KBywa+xU/mc6aGl3q9 sL+b4vZz2Qz/6BW5tWJpADYJOnZBLSLQ8UWtN/S6Bw26Rm/dX7maSTOTGBYGo0H5FuJn z4YqTGDto320GkZwD4+wkx3rHO0lgmnZr+KGDZGfR3qjCmCyZvmQ/9MuW+iAdtdRi9Jk YxWg== X-Forwarded-Encrypted: i=1; AFNElJ9rsZ+C0XrQXDzfa7wnFTRK6ze1R7XrIERQGbsc3njZx7PSsiYyJh8qzHaTnrhJisbqY+6XPMLXjwhf+F4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8lP31xKV8I8CUv76C9x2GbSlBx4Hiw4SKbAqVybcsvPjFRjl+ SWVJ+ZT1RSDuQh825JNBl2k14nkHv9WVrfpmfLU0r23CzCxQn0WZhpCs3Lvtsdn4E+erMPXe0Jj W81GkhGsBFqjlQE77twSZwdKNGeBGm5+IWOgwvCvpGKNedsZtwdh1ESvKzjqOxH1t1fo7tRI7cJ 041Q== X-Gm-Gg: Acq92OHgByOTWoQG5Ct7bdpeNR0qHNbXwaFAQ+0dZg+O7PDOdxUbMBKv6Km/Ecp//LL u0/s8WqcJH6e39Uy6LBwTOlXYWtjjtL8wKbHH3OqOIKKTUA28l5xcLHajsZKu3mgmRFqmF3zahL LpaB8ocN5XGzbcuMIZ+uLAFdGFUafjgPJoppo5CTi2hpFte0/L6NImodXoxU3tMvsAwWtrIz3wl 6oBn/u+qLG6P1EaaflCv/CMWMGngdGSSMnWng4on2w3wV1PCUNZ8ryRNtScMDB2c7xVA7SToFgu sbcQ1UMn6PFrMtwv0/cwsHcgufWReL/XpZlmt408zo+xWi++/n5Dvppa+UZgqk4omPGdd/EZxcr xvKpOilwTKbizkh5tXe0MkM7s6jp+50DNvcAkkM7lZx78X2ZavmpnN8StXwf6fhXJ9M1pDqWNI+ yKGg== X-Received: by 2002:a05:7301:9f03:b0:2f3:a348:a2db with SMTP id 5a478bee46e88-2f54c280b01mr13358610eec.10.1778561355038; Mon, 11 May 2026 21:49:15 -0700 (PDT) X-Received: by 2002:a05:7301:9f03:b0:2f3:a348:a2db with SMTP id 5a478bee46e88-2f54c280b01mr13358600eec.10.1778561354518; Mon, 11 May 2026 21:49:14 -0700 (PDT) Received: from san-w175-na3-01.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d43b4sm16032926eec.11.2026.05.11.21.49.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 21:49:14 -0700 (PDT) From: Wei Zhang To: jeff.johnson@oss.qualcomm.com Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, wei.zhang@oss.qualcomm.com Subject: [PATCH ath-next 0/2] wifi: ath12k: fix NULL deref when MLO link activation fails Date: Mon, 11 May 2026 21:49:03 -0700 Message-ID: <20260512044906.1735821-1-wei.zhang@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=ZrTd7d7G c=1 sm=1 tr=0 ts=6a02b14b cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=AAKCvc--jUWDOs3SvV8A:9 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEyMDA0MSBTYWx0ZWRfX/bb/YlyNESRT ZlkLhOnZHuQ66iznZJSIyqwiA8jxlMPPgcYJAXVeXXR1f1HyIW0RDPmUh63/zp6N9wHRLhTvXIX sh1Pt16IyehbnrQ5367mLOzfD7QMtIGs6nDt7XaBe1Eo0N6KKVPYgzS529i/c1JHGo+BH4FJ2NC hGHOaHEwD812cBJgbXLFhOv1Yuq1mar0guBtpakM+rde8DVSOMBjdbj17K7uwm9bGJjKH8kAxGW f5Qh0gs0bVPja5LmT3moRVulvOkpQsvrZYTTFaFgg/yphpShfZGp2RS72YOYxt1vEboN0HBKRfK 5JZrCc+ueBvtGdoiJWcxKjK7PHPKG+D74hpwFXO02m19tRXFWyaT3L0EpMB53uD5RB7noDlJYf3 Hx58R+GJd38vvR2AsWtyffiPcE6ysbxSgidHTbdHWWPdkbPK3HEtL7kIrLdCzlVNNZDsOmz/OI2 uKtSflgAjsRl+kva/+Q== X-Proofpoint-ORIG-GUID: UOmxZ0lD3QyfYi91hHbgROM8JKNWuqN7 X-Proofpoint-GUID: UOmxZ0lD3QyfYi91hHbgROM8JKNWuqN7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_05,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1011 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605120041 ath12k_mac_op_change_sta_links() adds a link to ahsta->links_map before verifying that the link's vdev is ready, allowing broken links to be processed by subsequent operations and causing NULL dereferences. Patch 1 fixes three error path inconsistencies in ath12k_mac_vdev_create() that leave arvif state or vdev resources inconsistent: a direct return on wmi_vdev_create failure bypasses err: which clears arvif->ar; and both failure paths in err_peer_del skip the DP peer cleanup and vdev rollback. Patch 2 uses arvif->is_created (made reliable by patch 1) to guard against links with no vdev before allocating a link station, preventing broken links from entering links_map. Wei Zhang (2): wifi: ath12k: fix inconsistent arvif state in vdev_create error paths wifi: ath12k: fix NULL deref in change_sta_links for unready link drivers/net/wireless/ath/ath12k/mac.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) base-commit: 7b25796f571fc09a7aa6fe7efb23edccd326917d -- 2.34.1