From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D89D3C8733 for ; Tue, 12 May 2026 20:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778619216; cv=none; b=FeXifedBxMvkYcIWMpRZM1UBiVxuJWavGPid3x94EFykbHAfp2b2GcAIBxKduYXDP2acpOCUPtsnJD65grN46Imx/U9ISxWxadSrPumc2Nl2MWf0M+Y0pe3uHNvgj+eRrKsJ6jPU5XSPYG97YXbHmfgYIZuSDnF1und5x8tkSVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778619216; c=relaxed/simple; bh=K8MdpY6XMsl1Tggb4WHji+dp3CRcvvp1nn7mA74lPSM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lpK+DghRa9wb/CeJFAtpUYKNvs0/auXrMoIDN4yG5U4zsxZL4YGUmtzwC869RtAMqdlXNbPMfA/IDVbrqVUYVaYSNLdfI1n89KD7KpxQO1EZk9d+rg1E9KV8fij6ful533R4aI5E++T41PF3upG9S7SOMm/ajf7lO+XoF6INcT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JzHTNS+x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eYGkh3/y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JzHTNS+x"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eYGkh3/y" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64CGfIwk739981 for ; Tue, 12 May 2026 20:53:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SkHOXs1v/pCbA8JFYyhJRkUq8O19fMYyqzXVYS8eqYk=; b=JzHTNS+xpFW1jkVP pOsQ5gGOvHPAo75Qg00C/p/ACKxvkR2nAc6MnbVxPO8JP0zbI0zRdx9F3tFM3VER +3MC37GAokAzXpMZ0QLWEz7GZpNaH+44BiYO+WKoaAWZYX0FLcjqnmC2U2sWNZCE z6VM7lGNhK75LVRKDNtD8xRebPOSNKGxFpMu3NdIOOidM/8y0iiyw4rkk3r6yEjc IB93PV1ZenShPm9rW28gOOGo6VVG0y7gJRU5jVH2ei0l3B0hYKhf6mpcJ4T6/O7u 51fWn0wKR0Qx0VyGbcznnNkZMEV1XyEbkwtfO3iEPFCYEY04Vx+XoCFDheuWnlLz CeNeTA== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e42rhtff8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 12 May 2026 20:53:34 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c827bda2e60so1979335a12.3 for ; Tue, 12 May 2026 13:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778619213; x=1779224013; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SkHOXs1v/pCbA8JFYyhJRkUq8O19fMYyqzXVYS8eqYk=; b=eYGkh3/y75NjoyZhHPzCyF0NdP7Wcu/ZJ2fMEWD68FuzrhCH28pIBfOE7UCmFIR5+N nKqVvcKl3TtaNbinoXRtb22e85Gm/Z+EsV8WpunfxvrKgQp5iCsb32LVOPqAH7aM1duh VNg35lf5/EAhZuneY/wvJKa0vNHXIJKDhpnn0jp1sDhctCu4woU8sjON0CcCM/0jKRlV Mp/aTfaQbiDMmE3AiCGzeDlEpNPmbwdj7G/a60LY9oAAUM10ryxU6HCiLTCICqTFbXkY TOb4+I1LujMMsHf+GkvaRm77bV9Ee6O0fvPAg6uYjsO//RDcuS8EFzpZWx1gWOXcFN5m KHaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778619213; x=1779224013; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SkHOXs1v/pCbA8JFYyhJRkUq8O19fMYyqzXVYS8eqYk=; b=nNVx3LJQzj1hwUr1M9+n3MtGXfOz+JHUVCX0M+zEjkipZOzhqVF12pj8lujFHva3ZZ 7eB+YrGp0V7db+eFFa9uuCJ2FJOC68dfvxdLWAzWpw8XTb9JrjIht2pynbtlKOkRfkxV 7VO0YnSA5OtWDn9PJisyCpgHQTAcDFwPB108K/nTAfdABYuEeR3XOoPaRD32ssv45djT vrUrB3ftoookFl985tS+bwMUQO7IdRoBwX0abwWTbn5CQ/1j9B4qhp08EEb+SAz9NJqW Xu1xEyn0BXwHFiDapxfRTXdXS9otPXWgACyW2sOclICBr6riehs4hpdUw6zoUs0XFHHW M2iA== X-Forwarded-Encrypted: i=1; AFNElJ8SRhMFdalnT9dgpkDjW2PL8fBhZAKYdE0lopcdVJL+rhc5CzRaS9Tezf1CMp0IoU7XSk21Ycg1nOu0xds=@vger.kernel.org X-Gm-Message-State: AOJu0YxsSS9mqZCsP8y0oKMvc2GiTZ9Xg9Tf36hkl43u3x8bhWuUuwOr cpnhfSfB4mAA9f4+/ky+s5YEYnhvHfxi7dq92sLPdtecXq0GfNvyTYukX4ESAsGJOa2aCftbZgj EA3dejqGEdtbnkXbNI0ichhcT3KpewDwdmax/yk8Xr2JGMga6uDcawlBLP6A4/eXxg+E= X-Gm-Gg: Acq92OFOPV6sN/gW+cbi6MBMjbw2kv7J2JvnLAh/ZHvWHIsMMKvThGtBjXK18MY3npI lR7+2tL+HuJ0x5mtL7gjODSbgPvWjiho48NL577tMBYfG2HKUBMF7RxpggN+y9qcCvIQkmI3S2H MUnti8ASBw2q6qLvtTytsO37XMTiJULifFSTa5pYM0eHfcZs2hINWr15V5uK7yPKeBWF05HPvIk e+ouOgN+ATfVu66hHMQP3ze1l9m4meWJ+U7/eAzDwAJJPoDRLE5Aw4uatR40/uVAOmOt+Fx4vGJ alSZyza9PaEGp3vpJxTJVyG/C7xU3zoAneqxoK/czFzyMs2M4bi21RtF10JreGp1bbgZBkkV7EW qucEUxph9jTfIoLRYQMt0GPJqnyye9R6CIEOp2I1LorO8yA== X-Received: by 2002:a05:6a00:4397:b0:824:a22c:c6d7 with SMTP id d2e1a72fcca58-83f03fd68bdmr270197b3a.18.1778619213067; Tue, 12 May 2026 13:53:33 -0700 (PDT) X-Received: by 2002:a05:6a00:4397:b0:824:a22c:c6d7 with SMTP id d2e1a72fcca58-83f03fd68bdmr270180b3a.18.1778619212601; Tue, 12 May 2026 13:53:32 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965945c1bsm25453004b3a.15.2026.05.12.13.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 13:53:32 -0700 (PDT) From: Akhil P Oommen Date: Wed, 13 May 2026 02:22:58 +0530 Subject: [PATCH RFT 3/5] drm/msm/adreno: Fix invalid drvdata typecast in adreno_remove() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260513-gmu-sync-state-fix-v1-3-6e33e6aa9b4f@oss.qualcomm.com> References: <20260513-gmu-sync-state-fix-v1-0-6e33e6aa9b4f@oss.qualcomm.com> In-Reply-To: <20260513-gmu-sync-state-fix-v1-0-6e33e6aa9b4f@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778619193; l=1326; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=K8MdpY6XMsl1Tggb4WHji+dp3CRcvvp1nn7mA74lPSM=; b=9ccjXNhWsV+/S0pMs0dFGNgEHhzV5zQuUwdYYa52QEABfcg8KlXrsYrMehhxEpR2a4zVSKiTy oJAbRyqXwMlB1K7LPEmHtZ1mb2qfsUAM5kV8LRXHbbIVFlngF75D0I2 X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEyMDIxNCBTYWx0ZWRfX0YdoudAATlm7 5t/FTwh5TE5w75WYNpGrJw9O/3k6z6ER6Nh8miatT84VSQ4L/wq805FAZxXZMXJjTYQ0sjddhU5 MovQkUy05sSGK5p/NeS7L55cMHErB1yEOBDU4So93Vm9fuOssZMcNwHaRUlOqC0E3uxY5YryHtn gnrWriOZa3CXeNpRsUgjMeCaLBCVezvydrdSBNLdncbJYHFXANSSg7ModgW5qODBfU9eb6ulSod XFTWcnuOTNinRmok//V6dIKQ5OKgDxFZ2abv5Em4nat3vSx8yQ7Gb8gvWlgXPc6ytzVBqU5xaNk t15qfcRWJEFwK5m1u+dtk/5Aixog/3Y7VjsNX+pif+O/GJg60eHs/H/l1y93Uf19cTdpP6CnvwG akVvFiilmn8w+vyKXQU6yWimj04ly4oqzOdlQinAf9w+OynukKVnZA7aVnqFY0k5+RdVic6Ok0D bRqjlSBBpZO16417Swg== X-Proofpoint-GUID: K-n03K1uE7TiGCU5ZPm656x8QgyHpDme X-Authority-Analysis: v=2.4 cv=GbMnWwXL c=1 sm=1 tr=0 ts=6a03934e cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=XPVHBuiRDinS94PRiAYA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: K-n03K1uE7TiGCU5ZPm656x8QgyHpDme X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_05,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605120214 adreno_remove() decides between component_del() and msm_gpu_remove() based on platform_get_drvdata(pdev), interpreted as a struct msm_drm_private *. That dereference is wrong because msm_gpu_init() overwrites the GPU pdev's drvdata with adreno_smmu_priv pointer. Fix this by using msm_gpu_use_separate_drm_dev() instead of relying on drvdata. Fixes: 643515a9cd09 ("drm/msm: rework binding of Imageon GPUs") Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_device.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index 3052f3e36de0..66953e551d86 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -279,12 +279,10 @@ static int adreno_probe(struct platform_device *pdev) static void adreno_remove(struct platform_device *pdev) { - struct msm_drm_private *priv = platform_get_drvdata(pdev); - - if (priv->kms_init) - component_del(&pdev->dev, &a3xx_ops); - else + if (msm_gpu_use_separate_drm_dev(pdev)) msm_gpu_remove(pdev, &a3xx_ops); + else + component_del(&pdev->dev, &a3xx_ops); } static void adreno_shutdown(struct platform_device *pdev) -- 2.51.0