From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70AEA4534B9 for ; Wed, 13 May 2026 12:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778676561; cv=none; b=NLQ3hAB118mCL0UBxumMFYTdUMObKBXvSAOJMU7+4Xdu2uTVqgt16NFYwRF5ep/5YNwX4ESIqn2ePbZOm/FkSciSYyB9ldXWkuMHKIaNZ9bzCxEi5sbyZ37TtyutrAHy0dDxA2mAQAruyy3YIN6/Xke1kUv2FXM+Oa4m7iDhhsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778676561; c=relaxed/simple; bh=9MMSW5/Ed7QpArLAviQFc6KStndAKsio49V65Hx+FaA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hLty3RwidzrRVydZ3gISpo1+mDJOwYcTVnSVwBBZqz/arUXhf0gpPBd5TbY2jQniioF0NToSwGIOLJQnXzSjAubcrpZ4K+X0/K8ypTIh10S+WMmDE0q1/IHDEAvI7JejbP+Q0spEDkmlcwCZQfee6zTwbWBXyBsmuGynjx+E+Bk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YkgrZ7k8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PyilkDpj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YkgrZ7k8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PyilkDpj" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64D8rGJI4082543 for ; Wed, 13 May 2026 12:49:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RNMcPvu0+FyJ/bhqguS0n95+1Sk/5HnVopj7l6K+ut8=; b=YkgrZ7k8Hz4DAeEE CLjsJgOhs/4ujwqz11UXV8rm/ICqMwveksPbdXQvq2sL/lwd8vTHdTsNLs7rCDRk OueDZPyWs2BzYF3/gRd8+si5ZHM+YjWoTA25Kjy/M+F0Z9OsV8zEzueNLVcbNi45 5YpHQMWnqsTLRHjfcy0OITa+K28wn2EWJ0WC74mY6gXO1JSaDil+OEvqHePDKCML VMLV8SYHNFHnzz22GQ+exwyPUgowGd9LiXF27Oabm6umL+/sc2p/cSIcYYML/HVV plte4YEe9ESoVEmTRZIwm32axmOeZPH32jElMeuf8IO//lbDTsg9FrS2iFFVwid/ 8iKxeg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4p6e0tmk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 13 May 2026 12:49:18 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51605cf3c60so39898341cf.0 for ; Wed, 13 May 2026 05:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778676557; x=1779281357; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RNMcPvu0+FyJ/bhqguS0n95+1Sk/5HnVopj7l6K+ut8=; b=PyilkDpjhQfcDayZ5PPROGD53cF8jclTb0DsKvzLFHvlZIyDsuKGhB5fkWXHMBjgIV ThHd/kwLdOgQFuyu5F0xDVz+3tN7u1TvY8lqHGqhAnfEEPrSAjrBoMnah6km9StvXEJ4 Fw6yL6gPj6OQ3mY/ddER7g2+jgc2qPHu2V27WD/txFXN+6AAFmH/mcfh6IC0JINprM4a pLIOeHlqrDL9V+7AdTwQWVtwJoNYBS7bhesrLE8/TPTZtzvIJ+WGYqc63ddSauRkK2I+ dAP0zadngAU5iJNzpjLoAnMy9CFBn2FqnCYtfKb4kRfAY1zXlR7mfBXTU4iDCJ2bFF31 xk5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778676557; x=1779281357; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RNMcPvu0+FyJ/bhqguS0n95+1Sk/5HnVopj7l6K+ut8=; b=jUws4FS1ski5g9JJvFufqmYNDAwVwHR+s18Z6PgJ3oYycvB1DyzWhXhL44y81k4IdO bB2arTlAaOFui0OL9XXAoFA5NeoFx3BgQ0b9jafapajLZBGpF/MaBp+9NPEAikAEK82e BJWdPEueOQCYMQVSHV/sB8Vu8NzEU8e2tcTm7K4z7eiOLiAdOR2FTgZpfXLJdDUlaYZY aXFmzzFV5WSs2CruY0fUP0s/fMJpCkx9/Spip/fxc1Z5wtuljU1x72YoWo5c28Egiejs ym18zu4rO+xZ4GKz4gNSWzNXr+3y1ORIJASxgFJMTIRGy2gMtpGQ7fdT3yvNeN67uX/S Zeyw== X-Forwarded-Encrypted: i=1; AFNElJ9A5uHAvQKiOAqaU1Mh84XHmy/QqYyU4XYP0q37M4UvdlTdjvtZmkg/8E0XNPblT/2tKmoPexRtZFNYe2Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwhuiONosoJG6sgwa6FHael1pChVmNdS3hn5OIo2+k9uN0k4q77 QCq+IcgYnYYHFfeVjknFmZd5J2WL82lii/kqMTjH5Wel9Dhp2ae+iFWqH9t/CqZEmAMSN5dXUOz aRfzuCz9uoQxWeiQGxa8CqUWfDJ9sbGjqJ7F1Fj4bK66LUZsJLii/7hTO8CHcQY6/V/c= X-Gm-Gg: Acq92OEbE22XKMU4Fkrh9du2c9PCwJVnvj4MA5aff0ipYC8iG4lu6bbHEdUBEnATXjK tGW9M8rqrig3oqC5hjUBIF2GQg0t6KOS9tx9PgtEL5v3wAPSltJLqADRDLbOquSTB9AhgqZpc2W e9IJoqpHwhPpkAoJbZ7/VTVBUPCvd3jqZvsrAj67oT1LADFFw0ArpOIL7cTsPmgWxKwSuA6kaCx rFTsQczyKE423Obf2s0vveiXOAHyzyTwXTjJ9JJw55trBuOQgPo/euVhLS0EXf9nqwx41up6Gd7 9qz2H8B19Zaxsswr7oeSv8CPB/Acs22XmpV/Uygcdi31Wt+pEudOBCtBCLgV6WntCPoySnI6xQC 2nBSB/5uAkOB9jy1sM3gWyU6YcyT3407BR6ldHxljDNE0SH1h+xYF8hCKtzXwBqbO+W2y1f/cdK 9qdFYLe81bIdVbv3aCbbmg3ELzjedLhNQxWSw= X-Received: by 2002:ac8:578f:0:b0:509:26f4:64f5 with SMTP id d75a77b69052e-5162f60846dmr40360331cf.48.1778676557418; Wed, 13 May 2026 05:49:17 -0700 (PDT) X-Received: by 2002:ac8:578f:0:b0:509:26f4:64f5 with SMTP id d75a77b69052e-5162f60846dmr40359961cf.48.1778676556935; Wed, 13 May 2026 05:49:16 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393f5f5f15asm41106841fa.17.2026.05.13.05.49.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 05:49:13 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 13 May 2026 15:45:38 +0300 Subject: [PATCH v2 04/16] media: iris: Introduce interrupt_init as a vpu_op Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260513-iris-ar50lt-v2-4-411e5f7bdc4c@oss.qualcomm.com> References: <20260513-iris-ar50lt-v2-0-411e5f7bdc4c@oss.qualcomm.com> In-Reply-To: <20260513-iris-ar50lt-v2-0-411e5f7bdc4c@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=4871; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=BLAFo17mDNzRt3RGOIKqa5vQlLgViburqFmg/i4bsbc=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQxZLsUPCzE3Zx8QCuksX+jzjdS3bvLQpvY3t6nvfZNnSW s5o0b5ORmMWBkYuBlkxRRafgpapMZuSwz7smFoPM4iVCWQKAxenAEzkrAEHw6awz3NmOHiyzrV+ aupn9Ny2Y1X6CT51qUttL3ZenaTE/rOn3bx4x6ZHjlUH0t1zr1fyhcr7JdhcTElWfsr8TW1d2zL B3LythoFfHrYu31Hp63lvt7nNg/bCzf73z3vtT2sQuF/qqSHAqP329+PCQw5HG5vKNziUMWqp1O sIMu/gcjrDt4Bt3utdDiqMT+9m5Yi/Fr0zR97Za8VyvZIpPX/4Cst6bZaJLV057Yc4g41+TfvG6 W1hot++aV4y85xpvadIg+36eUP5+QI7p6/7ZrnzlROj4EbX1SE3knrVW5a4WN4x78/k1Xn6Z9aF tDNff8j+kPscV3oyrdyz/wFT9/zeI2vP/Hz8xMi82XsNAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: 8IwQMIzmoNnZfO6JOf0Hw4UDXy4GQAWw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDEzMiBTYWx0ZWRfX+8kWeVxsTn1W 7AxV/P8A/H9v+FuhnG4f66lPzOqXEYeqj+9cDFlXDaddonltcJIolGFT2VfnO8JcEwpOU+oDiBk BmpcO8jZczzSkhfp04nOzyOV9ziVJi3ppAgSoZJAwWfT8Qt6D7Bkox7/7QM1h+nAs7EEPNpvrGc Mra73DDxSw1HiiE/ecO69VEhETe/AvkpNXBMbYULrOu8Lf5dj6yPuiv6Taq/dO1patYm8tXq5Zf Sz51ccQewqp4jzAoVLBbq6xOEnLqIDJdmZhYh6pKt3ERDgpAz/Z6HJYGVyMB2EpDZ4V3xybZJuu 3+5dyy4p19TtmEPU3Oit6qY8Z886vaiyzFm6IvewZeQoohhHuzTgM5Z3wkZeucmIoSKop0fjk1M g8+iaNs8u1ymPJfIECZrj4iVVOpJyfsa6MTjGuSP/8O2PejUhCqUVCv4VDHckvmED/azSvzwpVc xIyw2cacwdnI1RziqSg== X-Proofpoint-GUID: 8IwQMIzmoNnZfO6JOf0Hw4UDXy4GQAWw X-Authority-Analysis: v=2.4 cv=Wukb99fv c=1 sm=1 tr=0 ts=6a04734e cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=2EYiHOum3YQmkHKk0wkA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_01,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 phishscore=0 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130132 From: Dikshita Agarwal The interrupt_init sequence is currently shared across all supported devices. Starting with Qualcomm QCM2290 (AR50LT), the register programming would differ. Move interrupt_init into a vpu_op to allow per-device customization. This change prepares the driver for upcoming hardware variants. No functional change so far for existing devices. Reviewed-by: Dmitry Baryshkov Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_vpu2.c | 1 + drivers/media/platform/qcom/iris/iris_vpu3x.c | 3 +++ drivers/media/platform/qcom/iris/iris_vpu4x.c | 1 + drivers/media/platform/qcom/iris/iris_vpu_common.c | 4 ++-- drivers/media/platform/qcom/iris/iris_vpu_common.h | 2 ++ 5 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vpu2.c b/drivers/media/platform/qcom/iris/iris_vpu2.c index d61902c9a213..d49d22b14753 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu2.c +++ b/drivers/media/platform/qcom/iris/iris_vpu2.c @@ -46,4 +46,5 @@ const struct vpu_ops iris_vpu2_ops = { .calc_freq = iris_vpu2_calc_freq, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu3x.c b/drivers/media/platform/qcom/iris/iris_vpu3x.c index dc02ced1b931..c3b760730c98 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu3x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu3x.c @@ -262,6 +262,7 @@ const struct vpu_ops iris_vpu3_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; const struct vpu_ops iris_vpu33_ops = { @@ -272,6 +273,7 @@ const struct vpu_ops iris_vpu33_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; const struct vpu_ops iris_vpu35_ops = { @@ -283,4 +285,5 @@ const struct vpu_ops iris_vpu35_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu4x.c b/drivers/media/platform/qcom/iris/iris_vpu4x.c index f608a297d4a3..90ccdc0d2a07 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu4x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu4x.c @@ -369,4 +369,5 @@ const struct vpu_ops iris_vpu4x_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu4x_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c index ff0070c85ccf..59e4d68d042f 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -31,7 +31,7 @@ #define UC_REGION_ADDR (CPU_CS_BASE_OFFS + 0x64) #define UC_REGION_SIZE (CPU_CS_BASE_OFFS + 0x68) -static void iris_vpu_interrupt_init(struct iris_core *core) +void iris_vpu_interrupt_init(struct iris_core *core) { u32 mask_val; @@ -474,7 +474,7 @@ int iris_vpu_power_on(struct iris_core *core) core->iris_platform_data->vpu_ops->set_preset_registers(core); - iris_vpu_interrupt_init(core); + core->iris_platform_data->vpu_ops->interrupt_init(core); core->intr_status = 0; enable_irq(core->irq); diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.h b/drivers/media/platform/qcom/iris/iris_vpu_common.h index 21ed4c9bd5e3..9151545065cd 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.h +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.h @@ -23,6 +23,7 @@ struct vpu_ops { u64 (*calc_freq)(struct iris_inst *inst, size_t data_size); int (*set_hwmode)(struct iris_core *core); void (*set_preset_registers)(struct iris_core *core); + void (*interrupt_init)(struct iris_core *core); }; int iris_vpu_boot_firmware(struct iris_core *core); @@ -44,5 +45,6 @@ void iris_vpu35_vpu4x_program_bootup_registers(struct iris_core *core); u64 iris_vpu3x_vpu4x_calculate_frequency(struct iris_inst *inst, size_t data_size); void iris_vpu_set_preset_registers(struct iris_core *core); +void iris_vpu_interrupt_init(struct iris_core *core); #endif -- 2.47.3