From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B31E33CEA7 for ; Wed, 13 May 2026 04:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778647819; cv=none; b=TLXCJp9Klnic/kTKpaPEexw+UqiYOy+U+ItDxta0OIYDQk4rX692Jtwxa0O1xW1FQ81V8T2Ximh0Ahb8SGRvK9c79wEbFDlEmetiTN7+tFb6+IEb58YI4/movXfmV019sI22KvjyePLl2HQKn0dXUdbnUO2gvR9mWkAQBUao5/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778647819; c=relaxed/simple; bh=tE0vkv4AeNf9uXj69TTohvhoxtlDeJ+vneLAz78H2GM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pMuGqfbsc3mSrqKkmF4N2SJRyR9zAjMFn7bj4BhddE/U+XqKbotxwSakWSk9dgQPKV8kru9E/XEIUgntIP/zeoo3TRKaZWBicIO/2G9NExmSeOxpchC6NnFt53qwZ+kAcD0sVFVBaG2szWM9MchD1gqJ77vYLH4Y0l99KbrNyeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aKS/CRqA; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aKS/CRqA" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-836ebdeb969so2956448b3a.3 for ; Tue, 12 May 2026 21:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778647818; x=1779252618; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7zlpa7Ke4ytx6XPVc5PZ6mNxC3kCRBVIMOI9TKDTTjQ=; b=aKS/CRqAo10wmFosk25zcB2iHvTml4vYTy0c3zNV/6yCSPYHNTMUXNrKZpUMQAKnNu crH6KTz8TEAPAplRaw0kVFKiXBGgveqsF1DCbmr8u1kb+jhjPdtu2PjaNVc7SKcH5lJr Nek4Wys/n1AAzjajXM0qHZYoY/iDsSS3m2KMHiMlMT1AQerPG3WlIdzY/3Y06rEuS6vW dB7Fd2mvprA6SGVemRcGggOu1zBEQFfLvJzSZdipxYp3s4UZpJOej39fwkNgp1yG3LuG baCCcIQ2ybbhdvLWaF4KgLExvFnhDYUV8UkCOs7ZhJ4FGNRqVxZJRqiMHArIFTtxWQQ/ SvHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778647818; x=1779252618; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7zlpa7Ke4ytx6XPVc5PZ6mNxC3kCRBVIMOI9TKDTTjQ=; b=V+7sH7GeCVOBkqM0xvS5ZjUMwodzVvxzRBQLwehYj+kDUZGi7aJy4mkRjRumlmSkU4 /51fUfQ9tTwyukpLFYgH/mT9L5zIKMMdu5hRJSnBuFEYnWHit53od3ZlknPcuc9VOny8 7stcNQ7SHyB/Im4pvBYfnMsjFbAsXl7NE44wIxzqnCMbLIeDPqhlTYPuKYV6M5OohSji NTwTc9sP7DrPuDFdeV7K8bAsr31Kt3OX/xWIkIbFYVks12S8lA9sHEh8nDHfeHJeKirw 7nKJwKdv3OH/nDCbPS46eUUH6swYn2tqowybZbCE3ThhwLeSVX8qlc+jjY6DPCt7KXiu X2AQ== X-Forwarded-Encrypted: i=1; AFNElJ8aMjKZhoZonGX40InNvBjbQhShM/4g1lZWtARbL+mYfz0uavih/o1ObbxOVKBtLZrGIxLx9i4+tVAc2KA=@vger.kernel.org X-Gm-Message-State: AOJu0YydDeQSQcU+U4ygT4HDHAXfBryRiZY0c1uuDMA5VOAoD1103ZaK M5oGy2RXewYiM0pK4l4tZdStt09c6Hkh27XnVNg6TwFfpzDVWFr1o+wt X-Gm-Gg: Acq92OE1+Fadn+GgVQLziirIT0GOOWRnuSdK/U4CHvuehTsZ3CCm9cxMhXpFSFRasQm CNIx3Dfz/u61qoID8mPzctI2m0Mn749/ogKTVlrO4JzxurjaVYJCjcwLjwtQQeTyISOwuwTrK0s QIC7SvgIHs/NAgjA14nZVqjMEHrTzv4qov+NWnU04ducnO+Bk38NaUaDY0SF4hBL0U3AIyZ/yyC Dy5M7KxoyKCTZ/71fvPr1o2CBqi6hVSor1a9F3s8LGtrJ0UvYNJqP97HCy6vHOfVaNNHWYT8puy F1ZGbNyOVlGVHc8l2aFm1vNgVEfhEJk2Ut9qs+z1zitbNQQhnVbqlrgmBXl5DghCPFR+VGEEEi2 +udClotWDKMoxcBDczvyxCyRmSE/M3Mo+UCoVP4rIduPmjwAPdUlzUKdFDgzFa2zNPj5b6QLLYP T8KnQBA4mCnXwI6FLfVrxDkA9NwtY1DgjRNHgl X-Received: by 2002:a05:6a00:800a:b0:834:e15a:19f7 with SMTP id d2e1a72fcca58-83f05d5ff3bmr1328113b3a.44.1778647817871; Tue, 12 May 2026 21:50:17 -0700 (PDT) Received: from [127.0.1.1] ([203.99.159.230]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965c30ddasm32311914b3a.21.2026.05.12.21.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 21:50:17 -0700 (PDT) From: Javier Carrasco Date: Wed, 13 May 2026 17:49:41 +1300 Subject: [PATCH v2 1/4] iio: light: veml6030: remove unnecessary read of IT index Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260513-veml6031x00-v2-1-4703ca661a1d@gmail.com> References: <20260513-veml6031x00-v2-0-4703ca661a1d@gmail.com> In-Reply-To: <20260513-veml6031x00-v2-0-4703ca661a1d@gmail.com> To: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rishi Gupta , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Matti Vaittinen Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Carrasco , Jonathan Cameron X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778647803; l=1095; i=javier.carrasco.cruz@gmail.com; s=20260111; h=from:subject:message-id; bh=tE0vkv4AeNf9uXj69TTohvhoxtlDeJ+vneLAz78H2GM=; b=ISt3NzjRzb7KhHFzYzU7B2y1enxR6T8lMuDXUlrcwUAm960i6bB641ld75uErc1Haoe7q5PCx UGoUQFOdwnoCTbsG/rQYhHSBEbsZ7VkkHKCRH2y45BPImcvpL4WwIx6 X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=Lge8w8xidNSf/INy7JAIbAW+Hezkp3nsBh2OjKL7lLU= This is dead code as the IT index is not used by gts to set the new scale. In its current form, the value is read but not used afterward. Remove the dead code. Fixes: 22eaca4283b2 ("iio: light: veml6030: fix scale to conform to ABI") Signed-off-by: Javier Carrasco --- drivers/iio/light/veml6030.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c index 6bcacae3863c..745cf3ad7092 100644 --- a/drivers/iio/light/veml6030.c +++ b/drivers/iio/light/veml6030.c @@ -521,13 +521,9 @@ static int veml6030_write_persistence(struct iio_dev *indio_dev, static int veml6030_set_scale(struct iio_dev *indio_dev, int val, int val2) { - int ret, gain_sel, it_idx, it_sel; + int ret, gain_sel, it_sel; struct veml6030_data *data = iio_priv(indio_dev); - ret = regmap_field_read(data->rf.it, &it_idx); - if (ret) - return ret; - ret = iio_gts_find_gain_time_sel_for_scale(&data->gts, val, val2, &gain_sel, &it_sel); if (ret) -- 2.43.0