From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A0CE3E5598 for ; Wed, 13 May 2026 09:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778664124; cv=none; b=ZfliUvSS1uimAA3EDQ24t46YGHqpSw+4SUAxbZKuUvFzrNbjPBWjdPWS/M0FVKEdKB5OVd6KCgHiYKQ6709wA3H8HRx/1PdqEtn5Ghhc5GmqYATms64K+7cx7mz3qJRqKbZYehfFgbNHS3EWSL89yYh4zBWn0PYsGSSrvQOlsII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778664124; c=relaxed/simple; bh=CH9aC14Ow+s2U76Td5UWVhiLWQdXRjgzkm3OaUaNA5s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UT2XWpFTIDquIuR6IStil5GHNNBOQ//4RSCVZ/kjg6iM6q5oZ57Jc722pbTdu0BoxGaTIG6dzfxhWUjLq0zLVuBs9H6nrGZB0Z+kl6j8rCv2S3sngJlBjO7s/fZzvyrn57e3NVf4AYxY1MgpEAeHDei+TaWHaOjxjhXm0WKMK1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mP77Ngu6; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mP77Ngu6" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-45b030a5696so152883f8f.0 for ; Wed, 13 May 2026 02:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778664121; x=1779268921; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sI2bUBKrXRudUJ7ah8zfcT6Ih3qhp2uRzxDn72XJgC0=; b=mP77Ngu6SKQ9Sfj9kVR9QsWeW++UIPQvtGDIkfKVDgRRyt3MHKGIOwuPLwPYUW1LCq +x0kv/pAIZGgPtXLiSGETUohRSBxQeqNPLMGWT5CwZbdUwKeGZH3tjfT4DxySXtX1O2d YlhqPSq1cKi40xL8KwPrO7qx/76vRC1HY3xDUOrobOv/S67rG+r5IOiGRBACNaHTNDLm +m6t2jbGZVi1l4YI9LCNuU3rAXVXP/KWl2YhawJO+JNPFssG/1eJRtKd5NnDV5ectWWJ rYgterSfHYXKLTC5ZG4isnDA8As56ROsSrDJrhQz//mECyRYT9ip5Sbwl/ldmjfDRBWK nwPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778664121; x=1779268921; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sI2bUBKrXRudUJ7ah8zfcT6Ih3qhp2uRzxDn72XJgC0=; b=QbZ8a1nsHUPTpqUGlzm1QwvQVJrPsQo/M2echGsNZ23FKuEmX9svGGkO1yRLfxTBY+ HBNR2FbkdK+H8zmgcgg5YI/nYLGez2pla6wawjJzT2I+TtVsi6ocoJi+MNAAgzxVvGp9 7HYUOEDCBwp5/J7BZ/H1axafVvVtcx3KRXJIcokVtU06gzZnZteg25GDgOB6jHSKnSRn AWOMKs8dhsazsfHwyX57/lghcw9nnJ8APgyR1XGTMCM8RR8tBS+N4RXxnKobxYGMeV2e SUd7m7uDqdzAcpuzmDhonS6LtAQ5kFXJhU1z7Z4oj86cA1qJjjhoJMsvm+LNhOvyESEB /bMQ== X-Forwarded-Encrypted: i=1; AFNElJ9z4i1kPWxC3UhjxYgmdf6u7z0GE6UCb3ZOukEbGojFN960m5iwRsOKNi6kgBYA/6xGx/fqd+1PkjDsVds=@vger.kernel.org X-Gm-Message-State: AOJu0YxC7BowM8AXs9kO7+5D5jjLgXC3fElxnBSh6dw7Rq/7ymEx9Fo/ 8pKJrMCrO0aKXEDweHOp/fL5KUbBTQQ5tm0mE93h9o2pIx+SW48wjFPL X-Gm-Gg: Acq92OGxc7ZJZ/WaE7RSdObkcmsBVJxo4GUCrfNS33sYt3ipSY5SzbSO48bDla0E3Yz F44BsWrBDVqAe8e2wOy3+hREw0ivxpAsEIL9CyL0/lcVdhXOkHtuh+2n6+4Nh7pJFqyITIAFyLr xm+BkwPEtHY1D8HAvxCT3SOyda2kOJ0A9hsr+zpuVj/+Xq0YsNKlZu8bptsz0z4gCbBju6vc6v/ qzYKyyX8ThgW+I9TvdOf35Xed+Cx2zc9S0DN5WyrRbHiUIgjazidX7Rxl7OZABAo+KNmRABa0PE 0MHdVjagVEuLzyV3kYYgp9Re2kUEdBnYFiHSQeYm1TrcI9BeekrN/wSB/pWQk6tKoixSnTJhx3E 5RO8krdVRNNAIpGLfXva9VyD9i23B2Z+aAcirJcDKloWACweB6IA3x9rImt2iGvEAp7+qtAQ5C6 QqjRrCCMv+jltoXg== X-Received: by 2002:a05:6000:2909:b0:455:1688:d421 with SMTP id ffacd0b85a97d-45c59dce051mr1505299f8f.3.1778664120692; Wed, 13 May 2026 02:22:00 -0700 (PDT) Received: from skbuf ([2a02:2f04:d003:300:83b8:207a:1814:3806]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4549120ec0asm38402342f8f.17.2026.05.13.02.21.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 02:22:00 -0700 (PDT) Date: Wed, 13 May 2026 12:21:57 +0300 From: Vladimir Oltean To: Hongling Zeng Cc: vkoul@kernel.org, neil.armstrong@linaro.org, johan@kernel.org, kishon@kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, zhongling0719@126.com Subject: Re: [PATCH] phy: ti: pipe3: Fix clock resource leak on probe errors Message-ID: <20260513092157.uvxxsofyoqxqgyqo@skbuf> References: <20260513063902.113956-1-zenghongling@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513063902.113956-1-zenghongling@kylinos.cn> On Wed, May 13, 2026 at 02:39:02PM +0800, Hongling Zeng wrote: > When devm_phy_create() or devm_of_phy_provider_register() fails, > the refclk that was enabled earlier is not disabled, causing a > resource leak. > > Fix this by adding an error handling path to disable the clock > when these functions fail. > > Fixes: 234738ea3390 ("phy: ti-pipe3: Add PHY driver for TI PIPE3 PHY") > Signed-off-by: Hongling Zeng > --- Fixes tag: Fixes: 234738ea3390 ("phy: ti-pipe3: Add PHY driver for TI PIPE3 PHY") Has these problem(s): - Subject does not match target commit subject Just use git log -1 --format='Fixes: %h ("%s")'