From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7DD244A730 for ; Wed, 13 May 2026 14:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778683474; cv=none; b=SChbtiQZIZbdX5Q1W35Oq27QZJ1clOFS2cFVboBwPVO1ItE1YpfoXa70PpM1BONhmUA/thb5Kj4rlDwshJUHZb4QQoiUgg9xqfpN+hvPKqn5CGPsRjOftdH549w89SEf5LjYLUM/w/oEEy81mmO6PgHgFja8QI6sVMh5WqkBxvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778683474; c=relaxed/simple; bh=au+mOMR8czIiSMhZyNPY5z9ArSGWfnPUhHacyjBoQtY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VIictMuDZY3KuBu0gtR8IrambwzxkhyJ1mDeaiks3lln+QMVljhTd60N2yzZRP/hDeCakRmyhsVVHIfQXXlX8qLCW4MblCUgafu7O7BHEAZt9YwIaEUc+KxYqgJHSIZiTj//LmNMmPQylvcFtRNRERp/Q9xH3VimF/rUq3KpZTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SfcLahxg; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SfcLahxg" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-132830d8281so2225827c88.1 for ; Wed, 13 May 2026 07:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778683467; x=1779288267; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f2XlaJwSBpPWg5uTVaQnN9+A5FFLDYX24zRCV5h5kec=; b=SfcLahxgAznAUhz7kdUP7MYW9RSRciQFE8cKCFiKjcWEQFvAE9BlYZJeuO2nKqFEJB sXH82dr0KQMsYWCshmII61+g3XPVm7d6f0aCBw5UedQf9zIQ786GZtpWNOcFLfU3q55I 8KtOi8G1RdqMRvb2x7CeawYxLIGnx5GT01erZeoTWM8nsa/ic8TndjMcy2WMsmA19v+9 ZJzSEk3ZtWgthOR1PJY8w8f6xLT7KTFeYY+RGX/S2ysIA3nUHLn7KB8Tv/Zbw68oTxNm IfkSXQw/f8sdpAXiJsD9Dt5Dxx0/i5XZXkiBtl2YJ5y69hgTNiwuRLTuSipZvBFgbIWV c6hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778683467; x=1779288267; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f2XlaJwSBpPWg5uTVaQnN9+A5FFLDYX24zRCV5h5kec=; b=K3hjhZbtAnx3YX3TJdLdXRYbxZgLUrx8L4rNa4t/Hj1rndjyxtJR310ceoHiJE0kyK Yq74P+HZQZTYsCECE0DrOxK3IyapTbcojUvwEjs/9RkXccj/ZDFagSCvw3PsH2C07RCZ VvgmVy7dmgUUV28r3QSm0h4Z796zfWBe568dcliSS9TajuCM/dRtwrp0OXtypgsjiZP7 T9QhM+dsz7gyBPirOHz3SLFb+t2/kpPtIvPocWK8jfJmzhUAIFjpmK1MWml8/yBwIcla O9OP2VcKWvAaMiggjSNlZSR7dFKnZ4SEQ+4UUKF91p+zg8cIQcz04hPQ/XPlXmDv3UUe 7+ag== X-Forwarded-Encrypted: i=1; AFNElJ8mQu3EM4eBbNrkQu2uRoDMpVn2uQth8lUAUKWT/OTt4zeDgIDvaC8M7P5oWIlpjkAWI5NZyJiZm0KBNPc=@vger.kernel.org X-Gm-Message-State: AOJu0YySlF4eUSIApPzPcF9vNYpYangOJbUFzENNh/fzzL7nppk23YT1 BpWpU6qqLznu/daTOG0IPqk6Ey/EpQLzyNIcFtjYDels5Vx0o30viozG X-Gm-Gg: Acq92OEaNe2u2yT602zS1gwPF1q3lWrq6LQPps2UiZ00cXpZDWCOIVvf+hK4SMvb5Hy U0XiAzhCfuaZCUCOBvDOeIhT6+8P/wT7LApz4C3EaTezbDlutndFm5hi478gB3OjGn0vtLWA524 3zQx1sdCWILCMQTgrcowEpoxmnhvcsNQ9jZCKZ0ohimw95EUWHSGcF9QCh6QQgLUxSxj2qxE9yH lwZUKV0lilHZqfB86G8xNv4qUe8QPLgV5PxKwIzP1SRqhJQFcwo9iC95oTVDUJAiTdTwW8TRUSf +cs2NjycUUEdeBuRRTFwfk0pbdV9LPvrNx3gC2lDbE67bUy7tYvAk/XFzigkAZ+08nIo9O2FzpI s3Bn1zt+aAVYuBbZEQGOQe3X4j/Gxf5qMKjc9u8bBLw0gEMiVNAmOvHG6ZmprVPKfChx/qdl1o1 +VSEgsShfrLGhAAv3YR1i61Oq1sAJn6YAlSBIr X-Received: by 2002:a05:7022:128c:b0:132:83e6:41 with SMTP id a92af1059eb24-1342f2230ddmr2313170c88.13.1778683467152; Wed, 13 May 2026 07:44:27 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a53:11:5d6e:9aed:ce1b:4ae9]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1327865955fsm29768228c88.11.2026.05.13.07.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 07:44:26 -0700 (PDT) From: Jun Yan To: linusw@kernel.org Cc: alexandre.torgue@st.com, andersson@kernel.org, andre.przywara@arm.com, andrew@lunn.ch, baruch@tkos.co.il, conor+dt@kernel.org, devicetree@vger.kernel.org, gregory.clement@bootlin.com, jerrysteve1101@gmail.com, konradybcio@kernel.org, krzk+dt@kernel.org, krzk@kernel.org, lee@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, paul.barker@sancloud.com, pavel@kernel.org, pavel@ucw.cz, peda@axentia.se, robert.marko@sartura.hr, robh@kernel.org, romain.perier@gmail.com, sebastian.hesselbarth@gmail.com, vincent.knecht@mailoo.org, von81@163.com, xuwei5@hisilicon.com Subject: Re: [PATCH 2/5] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Date: Wed, 13 May 2026 22:44:10 +0800 Message-ID: <20260513144414.244968-1-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit > On Fri, May 8, 2026 at 5:26=E2=80=AFPM Jun Yan w= > rote: > > > 1. Per IS31FL319x datasheet [1], the hardware shutdown pin (SDB) is > > active-low. > > So that means that driving the line low will shut down the hardware. Yes, that is right. > > > - is31->shutdown_gpio =3D devm_gpiod_get_optional(dev, "shutdown", = > GPIOD_OUT_HIGH); > > + is31->shutdown_gpio =3D devm_gpiod_get_optional(dev, "shutdown", = > GPIOD_OUT_LOW); > > Add a comment here that this will in fact drive the line high, > because the GPIO line will be flagged as GPIO_ACTIVE_LOW > in the provider (such as the device tree). > > At least write this in the commit message, it's a missing piece > that helps readers understand what is going on. Okay, I will add the necessary comment in the V2 version. > > Have you checked any existing device trees so you don't > break something here? I have modified the problematic device trees and CC'd the relevant platform mailing lists as well as the device‑tree mailing list [1]. [1] https://lore.kernel.org/linux-devicetree/20260508152435.21389-1-jerrysteve1101@gmail.com/ > > If you're breaking platforms you may need a fixup in > drivers/gpio/gpiolib-of.c to force the consumer active > low for legacy device trees. Thanks for the reminder. I will add the necessary fixup in the V2 version. > > Yours, > Linus Walleij > > Yours, > Linus Walleij