From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC7B13D904D for ; Thu, 14 May 2026 08:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747167; cv=none; b=K3ihNha35z8mzMYNT5Ny3NFyWWQ0PX705fffozEluItDlaEhRvWNfVw72TcKT9hTLTNIj45dgLeqcabCuv74KoPpNfYfM28QuUYFOzbz5Cko7g1eC6/s/zph6ldvOKDZUmUMFi0aNilOL5w8CG1AYWcH03YBbnD6CRrmCH6ltKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747167; c=relaxed/simple; bh=aaNOXqVJslECMUlTkP9KNemoHAJsvHiIdYYefjAnxgg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MwPRiXa6w5WSYy9UOYZWzDFBkMDA5jroNXlt5FJoMeFTxvx5ws3Z6AbwcmGR9l0PVkx7xaICuLATHhZjFSNA5xGzTt0PbGzfVr1rb0ODv0w9iFOXVEyWvnKd8Ho4cG8+wItQQ5M6aDI95nXIypJSczk2GKZTbVQS3two4DkRDoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=oYtY3QWB; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="oYtY3QWB" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c8025aecc40so3837696a12.0 for ; Thu, 14 May 2026 01:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778747164; x=1779351964; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4r44B3WqzqqOS4+0yZVm7MlIZp2ZYEB2HNnv71bMuBw=; b=oYtY3QWBvWnNQfJ9iYtDy34uwIjcmPjJydL+pdKMozvPw8EXoaF0jhg0qxPlVx6Ht2 9CgxPXKyzTXRfr0maeLaORztubY+XdQcOmw9vaW7grigWVWmUxTYebElnZxj+/7WiHGY moIgj/RLJwJMtexdStRWBCK3mmVkVroZqq9IBTklTZ+GpVodRn6zfosNmy40OQnF97pc r7gRdLlLAQXnsUl8ntiVPThYIcWFVtO0/YjJgn5pUo7LTqhiG6yQRs2AJFp0rRHZPQbq mzbs92fueIkPtwhF8ZeT9Yf0X0P5POzzkIXszBGmuLsds19ck/oAFKGw/XGq0Hwhnfwa tlRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747164; x=1779351964; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4r44B3WqzqqOS4+0yZVm7MlIZp2ZYEB2HNnv71bMuBw=; b=V4a+FkdTpYyVHdnfb+CiMbRJme+S4GgZmpfVbtVqez1LZ5OrysyUbGVqzkaQ6yHpwD lS4pf4NyCU6ipIwgJ1+wCE1Zj+r0lrDcNrsw0KQXRCDSkxg5yve5mug4orPnrvhCaIGx JEzt4uqc7ZiIFJEXnpjsynlGQtA5/Kc9HcnetHpfkQ+t23saDkC4GSsSVeWIpOqaEvFX M8oPE3dLcxDKyR+FaYaRzxp2UKmWGIHotMRMgoqgT0EdDNSkMyKkCMBvIMbhf6gYevg7 pk9RKQd873QpRDYhv4NZjWo4vSccZc3rL+fNwxEvY9YNLtCtXjgmJFSpIx+DO8GSH1ox 7vSQ== X-Forwarded-Encrypted: i=1; AFNElJ/CNEHOR8IH6CusDCaMEdwUehuXNkLvKgxzBl9no4m+t6Ybn+OOalR2QBSqJ1DFqPeYXNXfRgQi8nfDTU8=@vger.kernel.org X-Gm-Message-State: AOJu0YwUQP+vXcg8I9/sqGbN200BDPWoujbEZ3WhxmpBcnK4+3c8k/pI 9Dya1Hp3uRsTUljBwKSB/AyTUR8KTvKbZ0eNHDAbsmR8m1lA/IBxL5uoxSQod874SCs= X-Gm-Gg: Acq92OFv2/fkEJyIYpfFQX3Hi74TtWswYcxFThx/A1zXDS9G1TxW6546f5cxYVXjeLS M33xNtkThQsiTfjpSGGrBu3vLzplMBOJYLEKgj4wRI7dXgRaJvkbmTqj05YV9TDELAJenKd1fV5 UycIQ1Nm3UBjClsIV1vXew+be3rLpD0Na+np7IBJmnW3i4ipNwF9bYrgZmLu4iCoa6g+eqZQuXp u7WYTGAdy6a7LcaDIe+vjADAcYXKlOpb9zBvBn8R742hsb5t6SrYNRMtvumAo5t0RR5EXNzDCun RapiydD7RSfFxm52kmsu53JY21BGsbnOyPS3dqubDeVFXGriV5bWa/HjoiVFXJl3tLvG85VkUUe 42bEmWctnvmYiZag/YZzRNuxTwbbIASQIBa7H6yCZBkd/9IR6brXr3UWmzqMlJ5hStmFA6lvdo1 wWYGi06grBRj7ufTxmQEyJBnjwJGQiUiuYlxxOgubvrzB7qV9E0+5NoVCqBehudgwWdEZHYcHKi spQfSK42MMuL5mT5PGwdXHmTuSZ1Rz4H228SmXBxS4L X-Received: by 2002:a05:6a20:ba07:b0:39f:c93e:c7f7 with SMTP id adf61e73a8af0-3b0bacce1e9mr2039565637.0.1778747164402; Thu, 14 May 2026 01:26:04 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c82bb06875bsm1589102a12.3.2026.05.14.01.25.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:26:03 -0700 (PDT) From: Abdun Nihaal Date: Thu, 14 May 2026 13:54:39 +0530 Subject: [PATCH 10/14] fbdev: tridentfb: fix potential memory leak in trident_pci_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260514-fbdev-v1-10-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 In trident_pci_probe(), the memory allocated for modelist using fb_videomode_to_modelist() is not freed in subsequent error paths. Fix that by calling fb_destroy_modelist(). Fixes: 6a5e3bd0c8bc ("tridentfb: Add DDC support") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/video/fbdev/tridentfb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index a8fdbae83a80..9f055ba776c8 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -1706,6 +1706,7 @@ static int trident_pci_probe(struct pci_dev *dev, return 0; out_unmap2: + fb_destroy_modelist(&info->modelist); if (default_par->ddc_registered) i2c_del_adapter(&default_par->ddc_adapter); kfree(info->pixmap.addr); -- 2.43.0