From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F34E3D9040 for ; Thu, 14 May 2026 08:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747176; cv=none; b=FhxSypbCMRIcsuSgXMj5a19co+RMwjnSDx5xh6z3nQjPlUx1KzORQIJvwztHoyXtyOe5CwEXtND7TGG5NJg1PwDn1Fiadmv41MuhRYRAZtm8bQ/sJyqBl/+R0SEFs/nAGh5u+yg6EQfqKn6ULlvsXuCoeZCFgEwbVzFRHMNVfdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747176; c=relaxed/simple; bh=Clp/7+dps7CMjUewVBlwf75eLhdxMdYd3dH4NKEEqKc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=D1dBmpf6kdPMqXrJWwy0OMlib05ZPnDuilz5saEKLtd/r5gcyZZU408vB8i/ZAFIeyEeKgk0Nk4+mYICAtqbguncTdHCUV+Ak/+cHFTZEda2bPLK80v9SSkcZ4iPb1neVPd6S8mSmc3a4xbQK7LJFVPbiqe03WU/eZjp06XRE0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=k91Y4giH; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="k91Y4giH" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c795f441ff7so5654482a12.2 for ; Thu, 14 May 2026 01:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778747172; x=1779351972; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GheaXfm6WhMIcKtl8e6E9+wMuBUvLISEtMm7ivNoGig=; b=k91Y4giHff01yxWojuLia/M9fAL4RljVppDZPb60vAs3vI6vvXcysEMJ4dM+ZdJPRo rtJuyF9e0tOv+mefyYhoCtda8ZaXIoexCsB4eNz5j0k+9K3Mn8BRb6qBX2WdJLt3TIdY MMa/8DMmkrqKDq+XL0tX5VARTK1ndH3c25lmdhhLwCdBXBOk7e0MHxg6Cdjgqk+6WbmU yRmjb3iZPgkJU1SK4I5tWOlhkAQmhiiaZlqD7dtI27z3Bpi0At628qbrFY9zY7ImF7BT HgnZrsjVZT+3qpC/MUteJT/Jts/unfTCx8NcMF7rud8jEeF7LFVHMDnJt3rj7F2kutJD EAwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747172; x=1779351972; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GheaXfm6WhMIcKtl8e6E9+wMuBUvLISEtMm7ivNoGig=; b=TlOTKGrCwESuWqfE/CIlhdDsgR4+nCLaHNZ5rR24iWrQP1FtkuhwsTcXYV3xTuCNaQ qlz+4dmbO+LlQzaOxzYFr7mgTA6t4WeqBsSTRgyhtCPekQkcmt7ZtivmOZVgK/Cqos8H LqsKLHBAD9aVeGO/yHdTacFnkqZCAsY7AUOgUeZx8R20eTZFzPSO0OiNr13j7Ct/4/MP HvKOAMci+rnn85kK4zm6T7xrowNKAoTC5C8ENoC56P7y/vZc9AHMFYCuHPzZFcyUFAQ7 JROcOI15h/eCa0lu+Wag66FrJiUi+YTCRXDNSMmxDkMLZn/SIuiTX6X8owau211Lw8oa eXdg== X-Forwarded-Encrypted: i=1; AFNElJ/N9zWmZwlk/KcwLejqCB++3UNxgxo6eWiBqL6R3S0E7+JC6Luw2BVC6u4sQAu8FuMaiLN7KPOusk1WaGg=@vger.kernel.org X-Gm-Message-State: AOJu0YwUthrbXlv3E+lw3kKc3E8jgq3KCUNeydD5lEXatacNiJ61K1Yl nUNxfGiqnystvYOArhfJTL+hNfjAPk3+M3Wp7AiVH/aem1PB+ti8mhgPXpIs49KFGG4= X-Gm-Gg: Acq92OFIv01KujnIwm7UAsGrBe+SqzBITvhSkGzf27OvgAGrvKRMa5F0EG+WZAi/xxh vAqNArx/bDPwJT2cmwRT7RbAEBCn7UlCaKd4r97g3YfR5Ef6KZU9jqAkGTCOl3N3U+eVLlY/trS 5hTGDAQOSCmYpmUTa9gJCfKsdt9fXDvw5HjDRnWu2Z+Rg82GvrnRzQClMgksBD4rhU4O4Ggg+Oh myLckmVR7f0IuvIGtbTjcOGwRa3rRsKY5+zfyW/gRYbAVPlq/Oevqmu5eay92alpDactPOGOb6I 4D1q6UIWTHkOakijCde4da5j5dHFPl+CxogcynrfprW/TDphXEFxEYsBOl97C7yyahUEerv6vak ooZV+6W4zaBv+UyWTjsuZAInh2xxngPb572JOIc5jwO8xIa7Sr1QpjAuAp0b6fLJzIkk4hNt6mi qskIdJkaqgpuyJe0u/CJCrk8k+dDre/cU3M1mxBMAXQREnhMCRs2HYKlbnIliZYhvZuutqO+8pf vTXuDydfxUSTnQSm2TRWwWjJw58xArLqHog1SZQMVpd X-Received: by 2002:a05:6a20:7f8e:b0:398:8002:8033 with SMTP id adf61e73a8af0-3afb0524b0fmr7156205637.49.1778747171713; Thu, 14 May 2026 01:26:11 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c82bb06875bsm1589102a12.3.2026.05.14.01.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:26:11 -0700 (PDT) From: Abdun Nihaal Date: Thu, 14 May 2026 13:54:40 +0530 Subject: [PATCH 11/14] fbdev: uvesafb: fix potential memory leak in uvesafb_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260514-fbdev-v1-11-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 Due to an incorrect goto label, memory allocated for modedb and modelist in uvesafb_vbe_init() is not freed in some error paths. Fix this by updating the goto label. Fixes: 8bdb3a2d7df4 ("uvesafb: the driver core") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/video/fbdev/uvesafb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c index 88667fccc27b..9d82326c744f 100644 --- a/drivers/video/fbdev/uvesafb.c +++ b/drivers/video/fbdev/uvesafb.c @@ -1694,14 +1694,14 @@ static int uvesafb_probe(struct platform_device *dev) i = uvesafb_vbe_init_mode(info); if (i < 0) { err = -EINVAL; - goto out; + goto out_mode; } else { mode = &par->vbe_modes[i]; } if (fb_alloc_cmap(&info->cmap, 256, 0) < 0) { err = -ENXIO; - goto out; + goto out_mode; } uvesafb_init_info(info, mode); -- 2.43.0