From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90F0A3D9DA9 for ; Thu, 14 May 2026 08:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747183; cv=none; b=cHRrY3e5eB2KrsKrrAd1VVfMZLVPyUwrdn7Ue+GYS0huCvZpMg3sCa8eTWP6CqyE5UBmB4VwmIpTrvgy8srkDBDd1FaonRlPWtFFFv3Zvpi8L0QPop1bemEVRP9UqVv5Na6CieokmGOLOaKFFrE8YRVWM7QX9/mRcDgv12BimkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747183; c=relaxed/simple; bh=IYxpemUzApEKYrRLdtgG2hm2hB0JVowGXr41xfSQwNc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ErqLVszOOJBRWZNFz5/o04tNjEjUa5UyOcx8L4xLGBdCneOQANMbLCkSVCJT+w3CMU/2PWOzhHboZ9nIf4rilyV3C305MLkrUW3ufmz1/szx/+C7QMfEUVVL5SDJYkONy7bHTNVzyxeCxRj0UxNwF4tq18pD7WKahvZ2QWmGDj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=N4djrP1e; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="N4djrP1e" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c7ffe8eeaf2so3314368a12.0 for ; Thu, 14 May 2026 01:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778747179; x=1779351979; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Bcm+FEfphE7RWlNG6KH2TrNjmFAxIKcw/vHzKLgiSIA=; b=N4djrP1e2EnGfPPSSWpRwc2m+ldSTOCQCL1Ub+kM78RtnJUjpiWxERDjGJGP9iS1G2 fGsO8xXuYbbTU3xjzMprNuTfOXJOfm83B+tP5x+8jMnED+xQSQdzAS1lRq5Kc0CuCs7q h3VEkcrldyXHjgL0uSI6PFIwYLsoyODK6s0vc5yS2lGzwSWc4IZ1qc+azLXMyj2TWnb3 EI+zcL/WigcJub6646lqlZgHkUXkH5PrGEYgCr9HxmbC80XOvGmD6R0fjcMYj2ZZ1bkn U1YNfcgmVwKUGP4oKHsrv/IVAUfdSvfj72ZR7PaXypXO6Kfv7DxDoPfnVwhtHYklDMfW JgrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747179; x=1779351979; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Bcm+FEfphE7RWlNG6KH2TrNjmFAxIKcw/vHzKLgiSIA=; b=haq/CZsuOWa5Fa203/GciRAoaIz7CWaQocagg/k88psX1uJG9Y0lYjm1YYa+9uftVE GuBPd0hmPINGzMnQTN6G/f8Y7wZ22DeQ/6n9XFqnRDSf3cOGbjjVtU8H6I6ceaxfUAQ8 xReWgiZ4UmPInoe+6xA46Z+ll5U8HIvQV0FmzpXUP11qAW1mp17wHBKd3X7IvhkHsnVD M37Bsjt3MWms4qbdxLsXZ2xNX3OAEiQwCbVGM9CmbvM87hVvb1H1mOYEPzDcbVKQnYZS OlDo6fn/UszwzWVh5ArdVPkKZMMHqsDW3ORwmof62O4yNDw0BdeUCHSl0M2A3qZ23NoU nJAw== X-Forwarded-Encrypted: i=1; AFNElJ/WCcubU3u5rmvG34VxLydUSQKAFewo/EeBP0wxjsUTM+YTCOgfPB2ZRmZVkcto3K8Gj634m7qIR6QazOM=@vger.kernel.org X-Gm-Message-State: AOJu0YyamNaRvEiDFCokG5xETqJwd9x/QSa1I6/B9Fz0VeltBXRlO1Kn 6Yz4DcQwehUaSUrqmEVjSXCPV77hKjkwRo7MOiuYttYvaFO4W7lBN2v71SH7vrJRgHI= X-Gm-Gg: Acq92OEI3gfrsGQil3ZNADbqo/gCAwLM/f5JddkyAIKgf1ZCXjdFVHlwzl5mMKSDY5b 5p4rAR0FAidTNgQchXthiX+qZXuKqKoLjz0dN3AXlm74bcCsWv6CSUQppitaqUtT0xuXG4Fw2m1 RpXnIB/7asgCJodXR/OJ5tHOtQHKDc5i9/989Dc+WHVArzj56CoW1fLOMC0G4Wnzlp6GL8Ev30O DQc2WmyuKey7ORS78YrNumcZqDiMFNJVH/Mqcect12YF8ZBDCNApHJ96GoO0SV0Tnx57wIQ4DtG T6GqiyZ4h2YOnqyiu3oNMYC+1itL06GGGyZ3qSp2DhJFgCq9zYpR7paFaH4SN26ituVlT8scsId Ljo0HbwDrcAfI2vOkflwmlu96wuZUFXJS8hBYmOEnRDItQKxyCj8GvlLH9+/duYCOl5kGRDXVl9 izetLB6A4g9l+Hm8iItszDXtZlsE4nPso0zITNfyc1AiUBkmlB4Uq2K25eGx0CpVw+q+X56r/Rh LAmYS950FVW0Po3TXLT9v4naMlrokjRXrap66/MLHPK X-Received: by 2002:a05:6a21:998e:b0:3ab:13f4:c721 with SMTP id adf61e73a8af0-3afaf522ea5mr6800186637.18.1778747178988; Thu, 14 May 2026 01:26:18 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c82bb06875bsm1589102a12.3.2026.05.14.01.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:26:18 -0700 (PDT) From: Abdun Nihaal Date: Thu, 14 May 2026 13:54:41 +0530 Subject: [PATCH 12/14] fbdev: efifb: fix memory leak in efifb_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260514-fbdev-v1-12-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 Since commit 73ce73c30ba9 ("fbdev: Transfer video= option strings to caller; clarify ownership") the string returned from fb_get_options() is expected to be freed by the caller, but the string is not freed in efifb_probe(). Fix that by freeing the option string after setup. Fixes: 73ce73c30ba9 ("fbdev: Transfer video= option strings to caller; clarify ownership") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/video/fbdev/efifb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c index 47ebc0107209..ad8dec7807c3 100644 --- a/drivers/video/fbdev/efifb.c +++ b/drivers/video/fbdev/efifb.c @@ -377,6 +377,7 @@ static int efifb_probe(struct platform_device *dev) if (fb_get_options("efifb", &option)) return -ENODEV; efifb_setup(si, option); + kfree(option); /* We don't get linelength from UGA Draw Protocol, only from * EFI Graphics Protocol. So if it's not in DMI, and it's not -- 2.43.0