From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC73F3D891A for ; Thu, 14 May 2026 08:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747112; cv=none; b=l9x9X8+lZCsnPXJEgzZl0nBukSdKBRFSCvv79j9JcGTWXKkeKtu65iTg3QXXGKgd4HtPbsM2z5vXfxmUF0PBRFp2W4ItbnQfuk/xO9mdnh1qirHB8fnKWQ8bhwpTBOPluNZW0mg6FC/8rggGGcuZyPJvuZ+3C79KM8x9BRlmRro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747112; c=relaxed/simple; bh=dZgpmxfLNwwdiD2CNYqlBA39ykctJlwlXlveZmO+QuM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NfywQ/lCAORw08aocEjs4vDR0yYKpWdlLzP9NaQhjQUReezQDvHlKkiMi4qMnIH6mySiy6eSAuypqvew4DH9HLOsPn6RMAE1T8TlU5KI/b3KEQMPGphzQtIeO4y3OTxuj5+XDHT6jWLe5UEfAuLxy1CFCfTtBaArGKbAMlQQ8ak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=bpD81+ur; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="bpD81+ur" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c8173b2af32so5657882a12.0 for ; Thu, 14 May 2026 01:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778747110; x=1779351910; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cETLUD+cFYpJj1ZB4GUnM/Wn7jURn1pWYkE3ZLuZekk=; b=bpD81+urT8tGzlWXOLkwEyRjzcJDmonJiyLuddpCUYmRUbh/Ahg3UmGKUho1sh0A+4 eqB8g1aDp5xAZcKkgF9RBAvYDJoTyy8nDjBNE2WAIlOA2fiB0n0nupwUr3jlYdy/beHZ Ax6tms5oK+XorZvCST8na+ycm/LELSDAcqhrX7KJaxYmQF1exF76x6RVZKHaioA+JFg+ 2L8SsxpUjK2wmvOi9l+T0P49L3P6WEVnoszJU2cK07UXpPWIkFn7gatX70b0P1by4eOT N6BoQNUXbpzfRvIgivOaxgCPcsxc5j6KkHOYRIVPoYbXuUB/urMZtejpqOH+V4cYSj1K C40w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747110; x=1779351910; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cETLUD+cFYpJj1ZB4GUnM/Wn7jURn1pWYkE3ZLuZekk=; b=rZUMjNfOEwmlL5UPuc1xLEnClricj3Gf1xoMLDGwpEAY5xWOLPDnwtBUIE8KicA5T0 ZDP0rEN2UXOQk0nFviInxLnUxQWuY4fqM7DSVqeVb+uPoxCHmcScIgVs2qk4rMfh2Vmg bfSpzFvHdOcjBlmhWXTyM8H/dG0Z0WxKZZ+F9UNt+Q9TRCYqId+t2TdjUFUJ6z69tCvZ EDZeYf8+BiBGj/gnKa72pQ9HKAW0plw0Zc7PIAlciw8zZFI/Hc+SWJVq+PA9CaP9GY92 bjvni3gM0bgegJFSxh9mub9nG7Z1WKhHuCtYLKIrK+EkyL8AhYSenI1zqZZW0ETJLxz7 nBAw== X-Forwarded-Encrypted: i=1; AFNElJ94YMksZNfYhYKUWhhen6pPFgHNFyuHnGe7Vm6E27J9acVJ3yLzs8/HnqqUrq97e9HuUe3rTiuW8AzJvvM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj55dSfonOWm1RGX9FBu4ub3gDnFDlXOQI7wYKiURTGS2QSUsN Kc66zBnryFI1myZqUM7NcCL8+s6lglgcsC8L4fZ776sU52zIhC+nxkSibAbIaYvXjgQ= X-Gm-Gg: Acq92OFS45gUn1IUazIVhHAF7ul3ZCGiA4/7eXqbfSKEIE4kZoJxcDxz/m99mE9waYR 1nx4+YLwPQjEywKpTvNMHycX/9MShefY0x0DiwsXRVc9uto6FgDpf1A9LW55SS8pr3kx67YfKAf lp/3PSxeOdaF9FHolMm4+w2ZF7LefhZlnqrEOqwxueDLg7Wfy4D0z/dWxKhNiTTJmQg6zNw/WNh 1s68dp0aw/9DYGPAuJyZLRBoQYmr+For9tRUu+HJZRXYr4x4/a5erDltOJCdQP/kYSM564C2is1 29se68wNNNJW7RnkC6dC0VvPUUGyhELFEFk+CTYqCWyOTNra5b/Yq6ttXfnXLkg1FASNK8rw3sO U4W9FyN09CSfwPY5mYSDay7qZBcDnEb2KxilIAWKoXAfQW/XZpp+iaTBg+ASDxeH1GlalGA+Gw/ jmb8xO+wAtKburPK8mFPWc019nJptTXtW3llAlJy+JpwpL2361ygzgtL/bz7QL5eZrN2z1t4yKD 0OYmkJgyuCyHvmKS5XAGa8v0+CbiHSkmmGjxZd5GFSh X-Received: by 2002:a05:6a21:4ec4:20b0:3b1:8cf6:8f79 with SMTP id adf61e73a8af0-3b18cf6979cmr603100637.44.1778747109771; Thu, 14 May 2026 01:25:09 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c82bb06875bsm1589102a12.3.2026.05.14.01.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:25:09 -0700 (PDT) From: Abdun Nihaal Date: Thu, 14 May 2026 13:54:32 +0530 Subject: [PATCH 03/14] fbdev: metronomefb: fix potential memory leak in metronomefb_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260514-fbdev-v1-3-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 The memory allocated for pagerefs in fb_deferred_io_init() is not freed on the error path. Fix it by calling fb_deferred_io_cleanup(). Fixes: 56c134f7f1b5 ("fbdev: Track deferred-I/O pages in pageref struct") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/video/fbdev/metronomefb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/metronomefb.c b/drivers/video/fbdev/metronomefb.c index 6f0942c6e5f1..83c614963a0a 100644 --- a/drivers/video/fbdev/metronomefb.c +++ b/drivers/video/fbdev/metronomefb.c @@ -645,12 +645,14 @@ static int metronomefb_probe(struct platform_device *dev) info->flags = FBINFO_VIRTFB; info->fbdefio = &metronomefb_defio; - fb_deferred_io_init(info); + retval = fb_deferred_io_init(info); + if (retval) + goto err_free_irq; retval = fb_alloc_cmap(&info->cmap, 8, 0); if (retval < 0) { dev_err(&dev->dev, "Failed to allocate colormap\n"); - goto err_free_irq; + goto err_fbdefio; } /* set cmap */ @@ -673,6 +675,8 @@ static int metronomefb_probe(struct platform_device *dev) err_cmap: fb_dealloc_cmap(&info->cmap); +err_fbdefio: + fb_deferred_io_cleanup(info); err_free_irq: board->cleanup(par); err_csum_table: -- 2.43.0