From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DBEF3D9024 for ; Thu, 14 May 2026 08:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747119; cv=none; b=FPBsTcsAw0goBhLCk/jYopmv9hKWP/91I6ZkHarenHTWF8kUh5pzcFyUEKjMcgVpduBn1QLwkwYIfB4JcSX84v+qLhovBOSAbwoWtqGFAn3b1sa9LXiSGCdtuwizQllw2N3hJrhPUex/2vILo8FsBHJOanh2LgTe3Vawh2kDers= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747119; c=relaxed/simple; bh=s7vOJa8zQULdRpt82vMyDCCkIAR3Vt7Pe6/FpWy2FrI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FMaJ72eyzy9+VDl84sU+IJIB5i17BXqVMC4u3ESF8Eg5l19ubGi7jCT5i7/TNMhrS869uD/vKFGGoSUXaVMFU9U/wV78dDx9eyE+GwcV/nj3hOugoLADuE/QzRGXgkVjGRPE1FYmCOYX3oOUtcd9S3GmGxJ3mfP+h0+eXrBiwHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=tcuT8auE; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="tcuT8auE" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c80203b9d7bso3208317a12.0 for ; Thu, 14 May 2026 01:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778747117; x=1779351917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fJh4Y1vJpYq92CQsC3/GcBHFFxqYLe8usjdVpu9K90E=; b=tcuT8auEbn6gOYZ72sU9YTaYv0dH8GExcpdHV4HPr82hDl83wGoqCpq43XY8XTrpQb 3wRlqXczsJDiswRLRSVMa3vIH6EgaL/j96QJT6fWcswSUlAZc2h3M8J+fS2fnd4qhnRx KGm8ZcH86jrR3d1hwrW7KU5W68xrECBHMU+GkQgFDMMXBboLVa4jT45FQl7otf4IEUM4 +bdYLwZGsNy6KUPiAkZ9SaJ3k0NpThHzLoiKoFarbFIGXb3Y9EAcTUenHT6ZVFJspBus 7U6KkLYf5Y0LfPsTBo2ncYJMbmtctcuhbhtH3DWUcMyFyVQmZ/tGe6T9fXggBNHe8sWZ 0EJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747117; x=1779351917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fJh4Y1vJpYq92CQsC3/GcBHFFxqYLe8usjdVpu9K90E=; b=NrNTfOUWUrJZ6Usf8fGLAAiZlkFuzqXH30yr1D9OKuPc1QbpZCTely6Sf/GYi2PqtK ja7FwP2sa6Bug+dZ47f9cnD+uQ0eVAvTWwpBUJxuFRpErUhIYLY6iz69MBc6YfL3Ye/T bKYd8zmegawHMMZvcXB1zeTqo4QiIV7JVQMzPpIkSfb/Bo8koetvGYuK9YaBbmtj/k4U bn6PcMML2ZmuVA2NibQKSd4HRSzTLaokfNge6sf5vzAoM0NfJPNBEkGz0BHRE7tOyJ3W OmucnhZUfgkr424EN2uY0yV7z0s3IYCUpI00jxSHjT2v8wAYBR0dIMWIWzdRs+HPTtEu whnw== X-Forwarded-Encrypted: i=1; AFNElJ80bFRoWO9q/U9y2PYByd2rYTHTy/IPuQlPEvVQgJEWf3YD0LHuZ7pTgkZOJJ9BB6b1DBuLamIy9xAzah8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6df3FAsPs8IHvuCxuECxcBPOhbRiX3ILOjZ85xTCI33JoowhD EX7VrMBGnO3RnGN2ovpNIRD+f3vDXyAURY05TW4dT0cb3lfk+aTusIrtyVoL6+hlAr0= X-Gm-Gg: Acq92OHbtkvaGoPj2XqT9TzLDpnu4uLj/CUoP5DEoPYC1pK3fWj4vkfLaVEnXCqLkVC iHgaWlvDy06rpUPWEPcxEJfGmbfruBeIHZYRTGETRvlNsqVutKYuXYAvOFs+0/R5YoH3dKekuH9 f0pHdBmpDYTxu+nFmZAzAHIoaqQAQ5mh79hblCjDF9vVnUmTlDDvfIoF0ubVmPM2E4u0trizrlr gqwrX593UZuqjuTZWfI/ogYEvidDh3DSdo+72SObxpMupZTnKWAcUk6Kcg6XLnnSBjhnU6g44tK 9hlOkEpgNFEMGKanWqyM2jPnc8/psmYR2zRepxP9zVG1Sy5vk7A2PxSb48Wmpmzvuiww5wFe4qg TPY9grdjdpCjQwk/RN+PFwD22nFvTu/le5Eu5dU53yGtPQ7Uq2bPQ3px3tB/AqBZHDfmmLlXu9a Yee9qzsGXMRk6fh5J90zU4fvFWqEUPp+pX8DlhG7S1yn/pz31WDHe0CehZPyjdnvntHspND+rIi tjB4XxVzZ2aT85ADcyESZwMyEP0vFIt3IagNbDcrvoXGxYuz1xzOUI= X-Received: by 2002:a05:6a20:939e:b0:3aa:c99b:5c63 with SMTP id adf61e73a8af0-3af7f25ba7fmr7209249637.18.1778747117417; Thu, 14 May 2026 01:25:17 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c82bb06875bsm1589102a12.3.2026.05.14.01.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:25:16 -0700 (PDT) From: Abdun Nihaal Date: Thu, 14 May 2026 13:54:33 +0530 Subject: [PATCH 04/14] fbdev: radeon: fix potential memory leak in radeonfb_pci_register() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260514-fbdev-v1-4-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 The function radeonfb_pci_register() allocates memory for modelist (by calling radeon_check_modes() which calls fb_add_videomode()). The memory is appended to info->modelist, but is not freed in subsequent error paths. Fix this by calling fb_destroy_modelist(). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/video/fbdev/aty/radeon_base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c index adb03489bedf..b6b058cee751 100644 --- a/drivers/video/fbdev/aty/radeon_base.c +++ b/drivers/video/fbdev/aty/radeon_base.c @@ -2476,6 +2476,7 @@ static int radeonfb_pci_register(struct pci_dev *pdev, return 0; err_unmap_fb: iounmap(rinfo->fb_base); + fb_destroy_modelist(&info->modelist); err_unmap_rom: kfree(rinfo->mon1_EDID); kfree(rinfo->mon2_EDID); -- 2.43.0