From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF2703AEF34 for ; Thu, 14 May 2026 08:25:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747143; cv=none; b=i9O+UzQFLDsWTyuB0h9FHmhLE7mpJaNQJmilpyukyEDzFOpvg3vciPQQ5kv5CL9g+MPkYPfcbcnASksNEJUiQ/L7HxCuj9pGREPhzOtPLeWKbDEWhFWXT9zHouauNMT8+BhTLDJOYtNRKdnyvoS1ik1y5dtAQNKD/xDa6ArYBGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778747143; c=relaxed/simple; bh=UAStXm3OSu9RI1NNHAXC/tKQ3QUcpDehqql4Ja1eUUQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f9a+j8vP7NraXuCEbBjNMa3wW7vLVFKhAgZg4jcmkOxhXQWSwOBVTWsq0vOnrdb5c5T34pcJT01layygaV8awbAQbQ42FTxREVKvgHhenAMQeOTHA4qVNUAO2+ffBs2e302yTRL6az5rHYGclVCCvpKTrqFWYX0DvXY+WdUgKF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=uMfigl6P; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="uMfigl6P" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c801912c903so3649880a12.0 for ; Thu, 14 May 2026 01:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778747141; x=1779351941; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XqQpLk2INDxanrU5EbiD7pVjr54bhFQM7xaG69RB0RA=; b=uMfigl6Pt73NSZmj0+Pz4EcgcXP2WXDNJHMPSGy3ceT/co1nGyAEN5723UIeBehawk moiC/5qdGTNM/TFBRMtR3YwWH8126Rkqv8AEnWMPEenONu0q+MfBJKUcHcWwT53Yjxmq j886aQMsY3N55sV5xIeM+nft4qMYUFtQYbSaTu4CKUKKoQOsEkfCd7yUZBCU9f507bVl YYM4OnsIC0vS42/AjzFvTlgyzP/XypjQEziYopmglIbO1bKTWqbefWsE0/8trDyDznZu qYngcuRkA/HrhBcaIKlSWUPLfTxOfgskTm4hWav0LdXJrnOh8GgrUXRcdpqcFXBPmGP5 Kk8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778747141; x=1779351941; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XqQpLk2INDxanrU5EbiD7pVjr54bhFQM7xaG69RB0RA=; b=oAwErwCj7yGC3RxZ7CoHAJgw+5NSF16M+hkVGP5qOf5Aa8E2Mpr3ClbS6kyhaBBhNl k7T5ypGLn6lEM1IAIJtGaDZRQWd4MShy9IrIqqijDr4EpsmsmtjlU92NY9+uq3Mw32FJ iySkC4nznQ9doGjZDhUQARsCuPInXZqOgTp4hFD3o2eVaGdtGPnE7XG9fgd+at38QSbA 1AF/eAEuUpalsm5LjNv53+lKem8HDcY+CE2GLbORV6JhCBPA1kYtRW6677of/3Z3uWau pYTdQ6/f/eCYTpkzdhfSWwqhd7tuMoK4OFaiu09crJ2aVVxkLtGULTw0z/kArzFIYqcQ YTCg== X-Forwarded-Encrypted: i=1; AFNElJ+lP04QEpo4MQAk7HkKkpjAvtrnWY8gqJ2nhV0vI9jpeKctC0XJakMqiZF5ct+XMbuyxJEGYXC78oQXB70=@vger.kernel.org X-Gm-Message-State: AOJu0YwIcqFZDsz1+Oa1rB1qsBHZZDgk1LBcvSeL7gUTHiZSWhkLgYLi Snmq/mALVArDp6ad48GqQ0aqeZvSWxcvP9g4z/ynIjnN1ttx8RCtgPEzklkmITlPe5c= X-Gm-Gg: Acq92OEGZ1+genU+V+BTk9ftuDNej/OuX/xQ7cZEy30669Jc3+1b39EXEyON8lI5mr8 ZID6MrmYAZjr4F0JhgqW80k0F/riuhvQPGHyKwvb8YDhpsK3rIUml3rtoBt0QeB/UyEsiu68zgS uy97aQIW0D20lWoct/MXXvy88Ev38O8WlZGG/WjVEmMYyUqe6jTJJ2LGr35mgQEeCzGMR31Wbcc titrdgsSDWsb8bAqVQ+Qe6dXFgjzfNdy7/TxTIzqsa0RMMk3HDXtsOVOyfEQwHl8L56hFm3o7/L NmxgMOcMxpQh9yNItg0Wt56ybjPuzHoeO9u+qTz0/WiwhODXSyyUvP8e21HphJbmapivytz9svi XnOnaUCc5wvegcfNZDAPwsX0yl1heqGYfgYmVvRnZfoXHr9sDSm8BnMezjhIMjv6ApC3P9Nrv8+ lsVX16pklIMn2z86WyiSXtJ9Jk/u9UWZgmJlpdEUJ/OPG1XmrIiQp8eBSK+jHhkAFlTkD7tKQbt Io6mITiFvfwLh7jzqUJR+UoAxF3drCobBKHX+PT88yG X-Received: by 2002:a05:6a20:431c:b0:398:7eea:50a0 with SMTP id adf61e73a8af0-3af7f86f95amr7286510637.18.1778747140737; Thu, 14 May 2026 01:25:40 -0700 (PDT) Received: from [127.0.1.1] ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c82bb06875bsm1589102a12.3.2026.05.14.01.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 01:25:39 -0700 (PDT) From: Abdun Nihaal Date: Thu, 14 May 2026 13:54:36 +0530 Subject: [PATCH 07/14] fbdev: nvidia: fix potential memory leak in nvidiafb_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260514-fbdev-v1-7-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> To: Helge Deller , Javier Martinez Canillas , Thomas Zimmermann , Benjamin Herrenschmidt , Andrew Morton , Sebastian Siewior , Florian Tobias Schandinat , Ondrej Zary , Antonino Daplas , Paul Mundt , Krzysztof Helt , Tomi Valkeinen , Michal Januszewski , Heiko Schocher , Peter Jones Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abdun Nihaal X-Mailer: b4 0.13.0 In nvidiafb_probe(), the memory allocated for modelist in nvidia_set_fbinfo() is not freed in the subsequent error paths. Fix that by calling fb_destroy_modelist(). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- drivers/video/fbdev/nvidia/nvidia.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c index da2d486022e8..7d20c4087aeb 100644 --- a/drivers/video/fbdev/nvidia/nvidia.c +++ b/drivers/video/fbdev/nvidia/nvidia.c @@ -1424,6 +1424,7 @@ static int nvidiafb_probe(struct pci_dev *pd, const struct pci_device_id *ent) err_out_iounmap_fb: iounmap(info->screen_base); + fb_destroy_modelist(&info->modelist); err_out_free_base1: fb_destroy_modedb(info->monspecs.modedb); nvidia_delete_i2c_busses(par); -- 2.43.0