From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6339C40757E for ; Thu, 14 May 2026 13:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778766881; cv=none; b=PwPvxtWPwbLf7CsNJD7zpMaBu+ymbiVCRxN6AtBDn0dWDKlOGcd8NfVTBeX1f4ei4/y0l7DlnkWFIxYxtKqma3HO/4/nEtauqlB4gDv2uKUbyJ/AVNZcv4A1U5MfuZOK8BrGWqhpgSRMvnsF2h4biDzeH1bUjN1sk0T5BedqU0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778766881; c=relaxed/simple; bh=Go4EyvhlQyWzHCh2p+9M+OIk/P0VvfEAaU7NdiQe9WE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Oc7QkndLAM9t7vsJ378SOZ4l/A1o2yYP6wsxCT0hESwzU98TvhegNbs6FcSPKuFxewU4Ctz9Ex77354H//otFayLbD7f3VZ/nH/nwtTkTeN/R86yHhpoHg7OkJuTOjoqY+Wh1KQ36WEvFtR+/fqq0PYnaI62xxnBr48YUnUWEWw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bB1NJuNy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DUiJwDGz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bB1NJuNy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DUiJwDGz" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64EBeV2i2713286 for ; Thu, 14 May 2026 13:54:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Rv3QXoFqyvR 3pKOjjPZUAdbwE5pf1YjcLxou3Iv6008=; b=bB1NJuNyqhGZYoB2UByMtpH1iEq dvl2cWOj9TZpqH5wBD5+cVCo9lqPkWjpRmh3FFH2DO90NzLNyL0FTYoOPQOoTq1T vaZ/lYPdLe3fBvy6QIzf2eJgYuzitLmllS4c10+DwxOf+7r3yq2EMO5INynEHM0C gCgGYHh5eFwobxuPPoTFrrCiz1j1pvWwrFrgKzAnmoFSyjcFxk9FF7L9uqj0kC7q qgyHYPqX6RDsqO0nqCqu0vEqDjUCS6JfFk79yxhUA6x3D95E+Bk5EkdbMAsVwcV3 US3CFuAtEOY/x5jayfrUehSiFmrQNGYAqm9WVI9O4VNfUErXFFd5ADGbJpA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e58v89h9s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 14 May 2026 13:54:38 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-83536dc3be5so8872526b3a.1 for ; Thu, 14 May 2026 06:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778766878; x=1779371678; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rv3QXoFqyvR3pKOjjPZUAdbwE5pf1YjcLxou3Iv6008=; b=DUiJwDGzEPxf6CFzuVUkIdH2uzhnFogdZ8dku/fxEeYwxxLWjTQWeDHyw/46UqUGwJ vJo5D0TxDkLEjMm7tmJE4GLM9E28fyJlv4Wgx9E8L0km2gFAGf5oiYB1e4rLZYxSPQBo oTuLlP9+qEDHNfqVtnqKcz5l/1Tb8H2k66y9jeQfLAHqR8cfeTCB272AJwFcgdQEhArQ 8GziNqEN/bvNDPGtgZSWayxu5OUGNQ4xpYWXmqgwqYb8QQSBadFJNcEj1eErdcalPGww fdlSxtFcgrCJDVYkGw3cafMjcI1fGRVpMpp0Mun2KkwJ6OJo0cfz10eOoP9wEPbbz6f1 adfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778766878; x=1779371678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rv3QXoFqyvR3pKOjjPZUAdbwE5pf1YjcLxou3Iv6008=; b=nWvoW6QyDg3kDDWQAHt9cPD5Z7YONWGUDPN6MwYAxGkBRsSHLH7lzc8ZD3aEiGzJNB kVm0d8456mS5IZehDcKwDprbi9pW6mYTgYIzTIFgmrRY/q3SCxFdTzhHU+rbAxM8K9Sg 5a0ZNiYXvnP1kLAuH84Lg1rTU1WInb58uvpYkKt1yv9+MfNIi3efU4PXxSZWKqkSRaPX cfi/gmfXvZXGXE7/g2o0xarRXVW34+1vgqrMo89MhHzLriAjYIzdQU+T2EzFYRRw30rH CxJTjF8mUUr8/7Wp1dWCm4bml2z8/6qj1Y60mC0mlvPvNpvdSBlG5ooLFRcSPxydREzA ulnA== X-Forwarded-Encrypted: i=1; AFNElJ+TK4yYvu+SHgcEXiDdB+a/xkjsy2yZsprnRbzKzwL25/SH3Q2euWXq/SFUSUUYJSKgjQtVmrTdDE8iuGY=@vger.kernel.org X-Gm-Message-State: AOJu0YxjgZGShs7l1v9fFyyVowFQZDkzoZQWEdhGs+1KV3/UVaPyVQDq ZDyP49S2jtNMPBZkvsMi7IiE+2jCUnIjs6uEexAZG4a20XY9YPBPoRJmyf5YMM8M9CJUqp3NhwM F/4K+1R8MJ2Ot9kvP9JI/o1a6nlKEwu5e/qMsOr09xeLNgIAoXsFaJmydGOFkWEeW6iI= X-Gm-Gg: Acq92OE67WNE4/HXX0fowwyXIVBYX8Sa5KNTTmrXSfDYYcLzShGtMempvOK1MalRsHB kHZOlB7fNatuSVdRb8b4VvlY0T8IDOPHh6zBJdhFJO3SHUAqXE47HFMxal1WHl0idQHsbSxU1DX 2mktXFjqRxW+f9WcjoOzJrwxkEtgPUEtyRePiDsGhr8NORaLNQMlMK6L/dI//GMwEwSN5VzpjUf EnsJ6vXVJsguVSpcGo35o9ftK9aHAzwQGsXIE83Jq/koqw0xwQEygHoVBK10GeqdR+XmnI66Ye/ p9xzEbk2Xruhq5jSiexNSNQ58o4W4ufAQwS+OW77XL3/sQkEMZfStG62uux975CWOjWazsORpJw uDX+87G2uvvjQe5s+75zfzhWpCRHyLxW0 X-Received: by 2002:a05:6a00:44c6:b0:83a:7516:5be0 with SMTP id d2e1a72fcca58-83f05bfdfa7mr7252559b3a.50.1778766877708; Thu, 14 May 2026 06:54:37 -0700 (PDT) X-Received: by 2002:a05:6a00:44c6:b0:83a:7516:5be0 with SMTP id d2e1a72fcca58-83f05bfdfa7mr7252531b3a.50.1778766877167; Thu, 14 May 2026 06:54:37 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c5c020sm2828875b3a.30.2026.05.14.06.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 06:54:36 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Anna Maniscalco , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 12/16] drm/msm/a8xx: Add perfcntr flush sequence Date: Thu, 14 May 2026 06:40:00 -0700 Message-ID: <20260514134052.361771-13-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260514134052.361771-1-robin.clark@oss.qualcomm.com> References: <20260514134052.361771-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE0MDE0MCBTYWx0ZWRfX5tvEgprHnDPi 52qTM778hvrtjIG9uhSM3GLGWHGexjyRdHhSTnjfxKugE/U9zzfIBU+2RvR+b0YHDM/bHsUU0bF oYHs+BVka6y5r/2TUj11s980wxo0qcS0nqwpdVC6JUX0wNFFA3upl48qfOENyTzPFmlpUJAw+Ts VUS/JgsygqIHMZYVDv2a0Tufy6IRVvblOVDqERu5TvMJPQvFY9MNMsCROMoOdhguZN7vXFZoQAA 91GGbFqlawWRSdkpwLPL2AUp+w6Vg1lmv9mdMmIUcfE2FSRCCg/Dd2Jxtikp2hRXGTPOrQKgdGh BuPUHz2Hnu+XGLe+yvukRkFhW9BQER0MAqTY2GBBHSt2EfZZqu67gq1UucN18G8o1YX2QaoqRtt A/ppSZYJx+AkMp/aoDior74hU228X1IYIqV1iZhXTSWVZt6F2V9n/hmstm094his3JD9oKpfr5V U4d8mqcGhFDsPoIgidw== X-Proofpoint-GUID: 3CF_d85Quj2mr8G9WOdhFIzpPZtmvsrA X-Authority-Analysis: v=2.4 cv=YZSNIQRf c=1 sm=1 tr=0 ts=6a05d41e cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=W-43u8CF5Pkpiqpb4b0A:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: 3CF_d85Quj2mr8G9WOdhFIzpPZtmvsrA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_03,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 priorityscore=1501 spamscore=0 bulkscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605140140 With the slice architecture, we need to flush the slice and unslice counters to perf RAM before reading counters. Signed-off-by: Rob Clark Reviewed-by: Anna Maniscalco --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 20 ++++++++++++++++++++ 3 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 30df9bfa9ef8..a329d20033d7 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -2921,6 +2921,7 @@ const struct adreno_gpu_funcs a8xx_gpu_funcs = { .progress = a8xx_progress, .sysprof_setup = a6xx_gmu_sysprof_setup, .perfcntr_configure = a6xx_perfcntr_configure, + .perfcntr_flush = a8xx_perfcntr_flush, }, .init = a6xx_gpu_init, .get_timestamp = a8xx_gmu_get_timestamp, diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h index 99c3e55f5ca8..3491a24a9320 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h @@ -334,5 +334,6 @@ void a8xx_preempt_hw_init(struct msm_gpu *gpu); void a8xx_preempt_trigger(struct msm_gpu *gpu); void a8xx_preempt_irq(struct msm_gpu *gpu); bool a8xx_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring); +void a8xx_perfcntr_flush(struct msm_gpu *gpu); void a8xx_recover(struct msm_gpu *gpu); #endif /* __A6XX_GPU_H__ */ diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c index 124d315b2469..6c040f718176 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -1345,3 +1345,23 @@ bool a8xx_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring) { return true; } + +void a8xx_perfcntr_flush(struct msm_gpu *gpu) +{ + u32 val; + + /* + * Flush delta counters (both perf counters and pipe stats) present in + * RBBM_S and RBBM_US to perf RAM logic to get the latest data. + */ + gpu_write(gpu, REG_A8XX_RBBM_PERFCTR_FLUSH_HOST_CMD, BIT(0)); + gpu_write(gpu, REG_A8XX_RBBM_SLICE_PERFCTR_FLUSH_HOST_CMD, BIT(0)); + + /* Ensure all writes are posted before polling status register */ + wmb(); + + if (gpu_poll_timeout(gpu, REG_A8XX_RBBM_PERFCTR_FLUSH_HOST_STATUS, val, + val & BIT(0), 100, 100 * 1000)) { + dev_err(&gpu->pdev->dev, "Perfcounter flush timed out: status=0x%08x\n", val); + } +} -- 2.54.0