From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B6AD3C1403 for ; Thu, 14 May 2026 13:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778766853; cv=none; b=Be79QiFlFSUeYhKJclcUs1sm4FTqDUXxHQBH9ahu3Pki7vhAzDtCqpW7xI7gK6mGPBv4D7jeDfNDZbVHwcWQugr9VPUPYdbsDuhM0upWB3UWDgoggcxLNQdob0BJpk/cDzcp4dHQ/jLQG3Cn3Oj/0lFUCYCspJ4OjxEI2O2l6Tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778766853; c=relaxed/simple; bh=hNYajq5FoO8Ohwqtcny4uUuWTPmnir7ozBVWoOEnOkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nGdWtpN4XQVy6532InaYIpzwvFL0xA9nWSRa8TJD6vwSz4E51U+hkOr330Ubo2Zp8oUmq0xqYCGUNR7NSL25VboTaFr7UFNcplLX7/Tp27c6BysOlI6HddYjDV3pklkA8DlUCQXYLO6LgBugKxRUbY3sirP59sHR/rWsIqVDK7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cCqwSZDZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UFMvO6Q4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cCqwSZDZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UFMvO6Q4" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64EBel1Q3952422 for ; Thu, 14 May 2026 13:54:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=r626fk8GTYQ 7mVDurnFWdbX+Kfuz+zSekrPETuLYfy4=; b=cCqwSZDZA/ZNXKBJmVr7z7Bktxx UVxsaLFxNfkUHMEgmLfDrTkhlkQAn1d8jSnNYEkqL+DnIdkZhebLnz/56GLpNrAD JQDkci1gMWs3NvdVMsAiAEDjbmA9sSsu0eUA+Ha1jDTMFlwyFDEp4N7CEK/GeXBd e1FzjkuHX2n06UoQqE9xx1Fw0LfN+R5uT2P8KUPQIqDs+OP1mnTrr665pUDQI4ZF +HQ4NXS9nPEn3VcF59xxp+kxzOLeDBvQQGOxsizT4SbiMWyaYyE96W8XgahQIWWl nsJWKBWKlNkUUcJ5r62dmrQSWruq5LPCqn3dxViJY/qrm3w/OrTdG+HMLDw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e57kssscf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 14 May 2026 13:54:11 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c828659ecd4so2783437a12.0 for ; Thu, 14 May 2026 06:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778766850; x=1779371650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r626fk8GTYQ7mVDurnFWdbX+Kfuz+zSekrPETuLYfy4=; b=UFMvO6Q4nRRdfKnx7GevLiOqNbuRKBiBEEnvscHfXFnn8JoEjQEbd86FEyH4vqZAkc wHm8PIrKgLJLDmdTMMUItT13baf2iUaFL9E2utijSaW4r9VTFuafCBazUqulHOLjige3 /ih5SjKa9vV0opzhz2rtYp8kysBCPF7PjKS1FGiSUBHvvRXGe8Dw9qUOodXh5euqvxbq 1gAmqqYrzpp9CFTG20fLJK2GAaHcaeSZwn77oCM4FF/U00wNgaIAGWamQ+WY1PeIEPtc PmDyUxWXUYSyOqGrE2rIPEXSkbRzL2i4hN4P+Rytfdbnaj36VfZjSLiNXuJN4T5DleYd 2Q7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778766850; x=1779371650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r626fk8GTYQ7mVDurnFWdbX+Kfuz+zSekrPETuLYfy4=; b=QXzJchl076E+wyY0VHARhCJDk45/U5N4wiVBxLBzxbsAQH6reY6yP+qT5Vi4HhY53Y pWgFzy+m1kB5IlTIJwERjOU97mNer0axJvB+NaHsF+xcWQ+WaMZijSIRAg0rEOF2uA3F m+5xhzdWa+Y5IheRHYQiQP8HSI335+Ufw14UHh+RMnck0aKm2dsCQCeeSIHd8K/ynTmm tlLym/gi5s89U9z2MXAgag4L5Dsfq1eNQbH0X74+XACOPw9+yomyvtX4/7LLzenKw/w2 PUusK0Oo10+4XX70F9SGvDJLjlN+rJw0Xt0u8/PtdgXdHR5Xtax9oTZdGK6WgWsVUb69 hJpw== X-Forwarded-Encrypted: i=1; AFNElJ8Ot6gEDE/16AtzOhb79CIhwk+VefTKn6X/OGQmp2ENZEYMkNv8Eku3pPPE7jSvcMxAGTGWlfVC2yIkhkA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzolg9OOsXHkuzuFZGu5fgHNQNu87e5xXuKSyqJS1QL40dzZtNN +hqXTGt4rnfNSpQFhSHzpm7UGDdq5ObJXrluCCFDw9re7Z1u1TqJz5O9mv/+VodaN/x5p5Wzl3Q 187PlQpZv3L7OsFlySbqbTOKtAeFnBy6+sUvo5HSfUF2dwjfU/U3qJkSyHaGg9BhFDSk= X-Gm-Gg: Acq92OEx0s8tIUI42DmzNcIKdKD5/kWQtltfEzWzglviRSAo1L8ps7brvdPpllgk+1i c9ZBNc7q9bmjV1H4azaaKT0pRgTd7Y+TW5YzEoycz2pL01IBKS6kvCPQXR5zSKvxrVYghXos780 GObM2+pB4sFfbbqQVfcGKWlyapNHKtQDWZnOLlz/1Ev/0pTzKkbvCRSyjUA6MDeo4qqWJZRXi6L kKUMDGNYYZ0WZoC2ehxTF/1D2yao3wFt57hMnUM6lzhyQBkSCUJPAbF0VXtWiU+YBCtT2EEteBG v9kXgR6AjOjKUoGwk+tsnLI2bwUO4J9fjiQ4yjsNT9RvG1SwFp/SdeprctoIG8J+FKJmCqpEiV1 grP/1HLukXYqOojqIA/hsTgI6DEUvoISB X-Received: by 2002:a05:6a20:7354:b0:3a2:f402:50e0 with SMTP id adf61e73a8af0-3afb0b13093mr8611811637.52.1778766850489; Thu, 14 May 2026 06:54:10 -0700 (PDT) X-Received: by 2002:a05:6a20:7354:b0:3a2:f402:50e0 with SMTP id adf61e73a8af0-3afb0b13093mr8611753637.52.1778766849955; Thu, 14 May 2026 06:54:09 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c82bb07d2f2sm2417535a12.10.2026.05.14.06.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 06:54:09 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Anna Maniscalco , Rob Clark , Dmitry Baryshkov , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Date: Thu, 14 May 2026 06:39:50 -0700 Message-ID: <20260514134052.361771-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260514134052.361771-1-robin.clark@oss.qualcomm.com> References: <20260514134052.361771-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: zh7E_mcQaMwQPq_JOilkiUb5epzaVDf3 X-Authority-Analysis: v=2.4 cv=KZbidwYD c=1 sm=1 tr=0 ts=6a05d403 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=ZRXlmS4ShPoOlOK7p90A:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE0MDE0MCBTYWx0ZWRfX4MPnvqJXweMs j3nWTvrIc0t4AHOdGs/D0Er5JSJwZpqzDTrMquGbRfoEzb84JjUQUx2sI/gABXZNzFo9LLcS4p0 9VDMxKEnB/nqdPCEXYvJpj6PpEyJCE2vo7OM9Fx5odF1n0YzW/FK018JPfQdQvRx1jOselb2XTg FsI7KAgUzvATubpu4IyFsUNuKsEE8vaEPekB6c2nIdfvU9njmzIFq5FTr7b+ZKSGGP0vNNF28Ku k/XQlza2UdGx7n/yTX7IixkRRnGAaCrR7Ipa2DbrTzya4dbpQMpq+ebV6WH/hdtdmcc72vfkqzw 5J//nPIsxfMsUi7lBnHQbCgAYk/6ZEaCutJj5Y8z74QDZYMsXM/GDV3Qa/E5DnZ7dIpcpNBbvJA V3+94OT/DHPN/dDsnsA5LedLK0XfEbAZQmDqAx4akt8YNH3Ji0pPV3tDgwat0Ilz/1Jo0jBynio /+R0KFJsgp157XRrqeg== X-Proofpoint-ORIG-GUID: zh7E_mcQaMwQPq_JOilkiUb5epzaVDf3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_03,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605140140 Use perfmon_capable() which checks both CAP_SYS_ADMIN and CAP_PERFMON. This matches what i915 and xe do, and seems more appropriate. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Anna Maniscalco --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..72b71e9e44f0 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -494,7 +494,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return 0; } case MSM_PARAM_SYSPROF: - if (!capable(CAP_SYS_ADMIN)) + if (!perfmon_capable()) return UERR(EPERM, drm, "invalid permissions"); return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: -- 2.54.0