From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AD6440629F for ; Fri, 15 May 2026 09:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778837304; cv=none; b=Yo0wy6iwrFEmMkpHjA4SNcOK+/zEh9ImhoIREDFX4QvnKbqd4o+f/f1pv/xyWiQX8jwy6ztbsooBjoA5Hbvrv0zJZkXiw9QqzILvJ+U9jT/jHt4VDqDS++gX99g+TVsmZNqGNaX7LRZmRrkSxSABVtuEK5t82gAmyfCUY8zvmPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778837304; c=relaxed/simple; bh=1lusloKra2BcMV6oSg1yvQoWUz9lgQJjDW5VorLGWfI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S7/MHsr3q3QbmgbKQwVcC9TGQqMRURVYWgjlMBci2yR3LGmgqv+kG1yg/lfdi09ck/TvMx2tsylFs0+qjze4EouxjDZZQvriLj8Ws/nLyA8yn5XbRXoYqym9IS5bMVtSOt3MhFcmlVDFkYyHs2ZJ8OiF2y52r/dz3kyCqd+nWUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hQqpRUCI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hQqpRUCI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8635DC2BCB0; Fri, 15 May 2026 09:28:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778837303; bh=1lusloKra2BcMV6oSg1yvQoWUz9lgQJjDW5VorLGWfI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hQqpRUCI4pL8YaurygELdkvcOn0sVJ/3YZKDUGp/BZMWqoecAijk2Jpe1FGil8wvJ 35XS/e/8G+bkQEYKO22+y/kQqoRg0tAKGmAmmtI79M6DWPm0Ijo7cLpAUmQMD2LbjG walH923XdXB+GLmAxt/zMAxM1HCaYnjpYJ/kqSTFRG7Zw1RH5r3WfTBRIpaHgrsC7D Ujxw4GqjEfC5c/v7EFM/kmjW1ZZHjKi7gEYjPgtVVj9jvojLYT8zCuhvXeEXrl0hb3 LBvqY36WpTib4PB8Rbvuz1TL08vcSy7zRez1ttDfDgUGUkj+stRGB+q5WqFrhrxrgI 9s7BCB2BSJHpQ== Date: Fri, 15 May 2026 11:28:21 +0200 From: Maxime Ripard To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Andrzej Hajda , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Neil Armstrong , Phong LE , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 3/3] drm/bridge: ite-it66121: Select HDMI or DVI mode based on sink type Message-ID: <20260515-divergent-placid-avocet-ed0ffb@houat> References: <20260515090220.809830-1-javierm@redhat.com> <20260515090220.809830-4-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="ae4ypa4vk7xyfysr" Content-Disposition: inline In-Reply-To: <20260515090220.809830-4-javierm@redhat.com> --ae4ypa4vk7xyfysr Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v4 3/3] drm/bridge: ite-it66121: Select HDMI or DVI mode based on sink type MIME-Version: 1.0 On Fri, May 15, 2026 at 11:02:11AM +0200, Javier Martinez Canillas wrote: > The driver unconditionally sets the transmission mode to HDMI, which leads > to display output not working with DVI monitors. Check connector's display > information sink type to identify the correct mode to configure the bridg= e. >=20 > Signed-off-by: Javier Martinez Canillas > --- >=20 > Changes in v4: > - Convert the driver to use the HDMI helpers (Maxime Ripard). > - Move .mode_set logic to .atomic_enable (Maxime Ripard). >=20 > Changes in v3: > - Move the HDMI/DVI mode set to the .atomic_enable handler (Maxime Ripard= ). >=20 > Changes in v2: > - Don't store the sink type in a per-commit bridge state (Maxime Ripard). >=20 > drivers/gpu/drm/bridge/ite-it66121.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridg= e/ite-it66121.c > index c8795247cfa8..95ee98a4a8df 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -184,6 +184,7 @@ > =20 > #define IT66121_HDMI_MODE_REG 0xC0 > #define IT66121_HDMI_MODE_HDMI BIT(0) > +#define IT66121_HDMI_MODE_DVI 0 > =20 > #define IT66121_SYS_STATUS_REG 0x0E > #define IT66121_SYS_STATUS_ACTIVE_IRQ BIT(7) > @@ -658,6 +659,7 @@ static void it66121_set_mode(struct it66121_ctx *ctx, > struct drm_atomic_commit *state) > { > struct drm_connector *connector =3D ctx->connector; > + unsigned int tx_mode =3D IT66121_HDMI_MODE_HDMI; > const struct drm_crtc_state *crtc_state; > const struct drm_display_mode *mode; > struct drm_crtc *crtc; > @@ -666,10 +668,13 @@ static void it66121_set_mode(struct it66121_ctx *ct= x, > crtc_state =3D drm_atomic_get_new_crtc_state(state, crtc); > mode =3D &crtc_state->adjusted_mode; > =20 > + if (!connector->display_info.is_hdmi) > + tx_mode =3D IT66121_HDMI_MODE_DVI; > + > mutex_lock(&ctx->lock); > =20 > - /* Set TX mode to HDMI */ > - if (regmap_write(ctx->regmap, IT66121_HDMI_MODE_REG, IT66121_HDMI_MODE_= HDMI)) > + /* Set TX mode to HDMI or DVI */ > + if (regmap_write(ctx->regmap, IT66121_HDMI_MODE_REG, tx_mode)) A ternary operator would probably be better here? Maxime --ae4ypa4vk7xyfysr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCagbnNAAKCRAnX84Zoj2+ dhV0AYDOQYmT0ioUwk81s3iOZ18oO9qVkpMAS4n0orBtCspXw0lIxeueX/vlTcFn mge5s9EBf1GERcsAS0jB4e7Z7w5uJDd7sadtsqBe/R8pYLjy0HoFkXiNKFHqEXGA 6rH35Axt3Q== =x1+U -----END PGP SIGNATURE----- --ae4ypa4vk7xyfysr--