From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C52143D646D for ; Fri, 15 May 2026 09:27:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778837240; cv=none; b=WTAQzTF6s1u3HEhMkN7HZesApREe0HTidWMnoQUtkVdIN33CuS1Wc/Iu9tmYvNKM0fReV2BtZHAkBh7CXbgv69nu81PA6bluxWjla5KdSLDJ3EFDI/BDNOWSdjU3JoAeYP8hcGvNwDJYIrl/fneMf8Cj0mkiptTSfpwE6afmMjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778837240; c=relaxed/simple; bh=erUBs5cK2N3XSfkmt0GpuG5nflxsc4iX+Hw1B7hsDnI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VtvF33eSah1Y2FputLFFF3QYO6ehIOlUO0KjJehATYcBem1RQfKLaCBPgFE7HQAjsKbp+W45vPMgaFx0WQsQbtqpRIkiE4A1HnugUwvU3sltO0oajLTJ+I/w5GO/6Ny1oTGJY7Fvvk3cWD7seO6G7tFJu0jTyclNx8SFsWSiPms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mqBysT39; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mqBysT39" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52BA5C2BCB0; Fri, 15 May 2026 09:27:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778837240; bh=erUBs5cK2N3XSfkmt0GpuG5nflxsc4iX+Hw1B7hsDnI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mqBysT39AVBME5LqkOfHQ38RVH+GSQN0BLCUhqjAC6n17ByIDvVh3Y+D/YOJgn0Lb qbLnDEyk/zCyGcMfqiZ6grGF1TRIaKbAFHNVC6MzU1S6XPPMVxMcqI9ZEMh13jIq9N jmZLDGk8guwTVXiO5lTSP6/WKB5EGinzMi/UmJPVRqNGEreWZDvu0EB2BqqWHP+jAN tY6HeclOR2nr3mPul6sBhTAlPZ2iN7yU8d4Ge5JNAd7o2a/hJeYhWMer7JjINyjPND I6DUJ+kAjFUouhdAl1uMBWjyFTCSqf6GprkM2S/wfEabTlSRVMqIm4bsoBOIzxwWvG MPkFdv27oDbZg== Date: Fri, 15 May 2026 11:27:17 +0200 From: Maxime Ripard To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Andrzej Hajda , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Neil Armstrong , Phong LE , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 2/3] drm/bridge: ite-it66121: Move logic .mode_set setup to .atomic_enable Message-ID: <20260515-wealthy-awesome-seal-ecd4a3@houat> References: <20260515090220.809830-1-javierm@redhat.com> <20260515090220.809830-3-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="yyn2y4negj7waxwi" Content-Disposition: inline In-Reply-To: <20260515090220.809830-3-javierm@redhat.com> --yyn2y4negj7waxwi Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v4 2/3] drm/bridge: ite-it66121: Move logic .mode_set setup to .atomic_enable MIME-Version: 1.0 On Fri, May 15, 2026 at 11:02:10AM +0200, Javier Martinez Canillas wrote: > Move the existing .mode_set logic to the .atomic_enable callback. The > former is deprecated and drivers are supposed to use the latter instead. >=20 > Suggested-by: Maxime Ripard > Signed-off-by: Javier Martinez Canillas > --- >=20 > Changes in v4: > - New patch for v4 >=20 > drivers/gpu/drm/bridge/ite-it66121.c | 79 +++++++++++++++------------- > 1 file changed, 42 insertions(+), 37 deletions(-) >=20 > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridg= e/ite-it66121.c > index 947b7a0f0a45..c8795247cfa8 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -654,6 +654,47 @@ static int it66121_bridge_attach(struct drm_bridge *= bridge, > return 0; > } > =20 > +static void it66121_set_mode(struct it66121_ctx *ctx, > + struct drm_atomic_commit *state) > +{ > + struct drm_connector *connector =3D ctx->connector; We should drop this entirely now. It's available in atomic_enable, you shou= ld pass it as an argument. > + const struct drm_crtc_state *crtc_state; > + const struct drm_display_mode *mode; > + struct drm_crtc *crtc; > + > + crtc =3D drm_atomic_get_new_connector_state(state, connector)->crtc; > + crtc_state =3D drm_atomic_get_new_crtc_state(state, crtc); drm_atomic_get_new_connector_state and drm_atomic_get_new_crtc_state can return a NULL pointer. We should check, warn and return if it's the case. Maxime --yyn2y4negj7waxwi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCagbm9QAKCRAnX84Zoj2+ dvuCAYDe38nSHdrKfMZ5MJ4rBsTXmy2sHpyCaEgbXZyyXyI61Zy1OPF53rZwOgjA IdfJQAYBf0WrAd7lbG0oT2oYW7yUEu54zeh/QKcPLM7wlrSr5552ml2DG3Sausox iN6J/vt27A== =X7TI -----END PGP SIGNATURE----- --yyn2y4negj7waxwi--