From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2098642B726 for ; Fri, 15 May 2026 09:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778835733; cv=none; b=kkmJ7bnOkDE/6jRdZNsP+k067aQ4X4uZc4cU3lppAKR1sXxVFJfM7p91b53zz0nXoptB/6cpJwE1PIw99VtINhsAun3IE9h82YXMQBa69BQv6wwYKGZyiRr+ao0UGC/BdFiDF8INjEhnBlom2BPBcieNimVGakLtWOndZtpTtEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778835733; c=relaxed/simple; bh=aAFwJQgIt7xDHMJ5j64aG3AQ7uDImuBxz1E2PHKbomw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XFFJ6ccIrR+f+AtJBBd9eOmKLKu+hJd+WFk6kiKJrBShdbar1+VDLTQHedmHwR6uaOaxpAt+kMkByiRjmtuXfRXx1BDWqdoW9oTyLfwLzoAviU0uUNG90QviCIqYi6zprh5QZdZtqzZGMNjXXQWhcTxkSPUerEkyZ8gw/nmyjYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=liyPZIAL; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="liyPZIAL" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-365e20fe3b8so5374719a91.3 for ; Fri, 15 May 2026 02:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1778835731; x=1779440531; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VXZt6qBmARZ13tXsBdYUa2P85z9cDemCtuWb0vwC4yk=; b=liyPZIALxM6+z9ZGu5nXZEUgIre9qgeNd9WxG3qRseUNupPzCzh+tPk/eKHRVXJlHd 1j2ITUUxG+UAMVEnnFt66KZw4NDq+aIjgrVwO3uGt8stuh9cz6LBvbMMFXi9TJxexRNy PzUZfQwRC9d2U1vVBxXvikdtfcfu/xMIDAa1k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778835731; x=1779440531; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VXZt6qBmARZ13tXsBdYUa2P85z9cDemCtuWb0vwC4yk=; b=n+K47zUxjKO60JdV5ysyrXQTkABVPKFTc78cVfudldyTtjtqNvzJf8vjxhdvmWFr4q OOyl6J2qlHjxdki7Bb96DXZTQ+jniZORxo/4QTQb38kG63tBH14uCUfV6PDDkaYyh9f5 W5uRM9P8olE8RjhVA0c0Pk3Lq/v09q3qDc5hj8yz9ee/VONHpzYx1PiUAGAdilN9Uk85 7TP3GpqU5UAPs3tAVHodeQr0d/dHEutQrlIPuek125qObvK2XunvjsT9A800Kx6iC3dX qY0bCIvIzV7k5Rj8myAISxI5Gf5WgebbcuTVzeNESJdXR9r/adHJnNXqyibin7oCnfBJ CH1w== X-Forwarded-Encrypted: i=1; AFNElJ8c26Xt0z4RY7Q4IDvn+kx2GV712rEDjGqpNDtjOGhy5XLvH76/jZhReRUFRYxkJP0O2jJ512DGrf4pGjk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1FUdWXdJRY07zrURDDfHIim9Ru6oYI4/qxsD+QXc3aqij/QJ/ NZoSxmIPWDjjNa5VreioVP8hS+mpvUCYPHQRg8F9fZrgGsBv6tQwpKufWmE5heFSNA== X-Gm-Gg: Acq92OFsmsQlLX8ePPyYz4N0E1reX/SIOx+k+QcDmzHqmqpR9+/GLygEEYxvdP7pYdn OHcyYidngjnUXYyPyTuUGkSGzl2gQU51XnLIy5tfQTiUOp5Ce1IhO59dWwKaEvG6GbyRm4A+ETm GMsJ/AcDrQGckQ4b/48jmrcTeUE+/qzGLQhVmJt6oxpQYGJVi9/XcmBaI11WZgWnCaJrXCVwPuO I2fETitIiNBUBS9mut2rti/mHVwsTyJu/Vye/qoDWwX5Wjk4SyChfn3aV+2WDpsOqoP1i0UAlyB ATJFMScWbf8RYFNL9Mv3ZYFHjs7aitAGa0IYKNA00BVC39c6q/v7knh4zJ6ezzTWAgl/4hR5lyQ kNYzE7UZJDz3aCiOoVZ7CGPPDAFcqKE4mIcq3ggFmZH7xwXiOV4Ukd7zUwi/ML3bHc/MxrPM1aT kMmw7qF7eXJMNWh11kqtCaC3gc87CSagavcFceG2juj1LUZAhHHwgrFC0Msg+8jE0OoYsjuYnA7 McRfiIx X-Received: by 2002:a17:90b:548b:b0:366:2668:b5b6 with SMTP id 98e67ed59e1d1-36951b9e004mr3400112a91.22.1778835731362; Fri, 15 May 2026 02:02:11 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:b3d8:e32e:c2fc:c31e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36951584654sm2076537a91.7.2026.05.15.02.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 02:02:10 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH RFC 01/12] power: sequencing: Add index parameter for getting power sequencer Date: Fri, 15 May 2026 17:01:37 +0800 Message-ID: <20260515090149.3169406-2-wenst@chromium.org> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog In-Reply-To: <20260515090149.3169406-1-wenst@chromium.org> References: <20260515090149.3169406-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In some cases more than one sequencer could be associated with a particular device. For example, a USB hub has multiple downstream ports, and each port could be connected to a different M.2 E-key slot. In this case the index would be the port number. The index tells power sequencers for different slots (connected to different hub ports) apart. For the consumer API, add a new pwrseq_get_index() for new users. The original pwrseq_get() now calls pwrseq_get_index() with index = -1. For the provider API, add the index parameter to the .match function signature, and tweak all existing providers to match. Actual use of the new index parameter will be introduced in the next change. Other than the API change, no functional changes are intended. Signed-off-by: Chen-Yu Tsai --- drivers/power/sequencing/core.c | 12 ++++++++---- drivers/power/sequencing/pwrseq-pcie-m2.c | 2 +- drivers/power/sequencing/pwrseq-qcom-wcn.c | 6 +++--- drivers/power/sequencing/pwrseq-thead-gpu.c | 2 +- include/linux/pwrseq/consumer.h | 6 ++++-- include/linux/pwrseq/provider.h | 2 +- 6 files changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/power/sequencing/core.c b/drivers/power/sequencing/core.c index 14335c4f813e..1a91ee6d416f 100644 --- a/drivers/power/sequencing/core.c +++ b/drivers/power/sequencing/core.c @@ -612,6 +612,7 @@ struct pwrseq_match_data { struct pwrseq_desc *desc; struct device *dev; const char *target; + int index; }; static int pwrseq_match_device(struct device *pwrseq_dev, void *data) @@ -627,7 +628,7 @@ static int pwrseq_match_device(struct device *pwrseq_dev, void *data) if (!device_is_registered(&pwrseq->dev)) return 0; - ret = pwrseq->match(pwrseq, match_data->dev); + ret = pwrseq->match(pwrseq, match_data->dev, match_data->index); if (ret == PWRSEQ_NO_MATCH || ret < 0) return ret; @@ -655,16 +656,18 @@ static int pwrseq_match_device(struct device *pwrseq_dev, void *data) } /** - * pwrseq_get() - Get the power sequencer associated with this device. + * pwrseq_get_index() - Get the power sequencer associated with this device. * @dev: Device for which to get the sequencer. * @target: Name of the target exposed by the sequencer this device wants to * reach. + * @index: Index of the sequencer associated with the device. * * Returns: * New power sequencer descriptor for use by the consumer driver or ERR_PTR() * on failure. */ -struct pwrseq_desc *pwrseq_get(struct device *dev, const char *target) +struct pwrseq_desc *pwrseq_get_index(struct device *dev, const char *target, + int index) { struct pwrseq_match_data match_data; int ret; @@ -676,6 +679,7 @@ struct pwrseq_desc *pwrseq_get(struct device *dev, const char *target) match_data.desc = desc; match_data.dev = dev; match_data.target = target; + match_data.index = index; guard(rwsem_read)(&pwrseq_sem); @@ -689,7 +693,7 @@ struct pwrseq_desc *pwrseq_get(struct device *dev, const char *target) return_ptr(desc); } -EXPORT_SYMBOL_GPL(pwrseq_get); +EXPORT_SYMBOL_GPL(pwrseq_get_index); /** * pwrseq_put() - Release the power sequencer descriptor. diff --git a/drivers/power/sequencing/pwrseq-pcie-m2.c b/drivers/power/sequencing/pwrseq-pcie-m2.c index ef69ae268059..16a332f9da7d 100644 --- a/drivers/power/sequencing/pwrseq-pcie-m2.c +++ b/drivers/power/sequencing/pwrseq-pcie-m2.c @@ -158,7 +158,7 @@ static const struct pwrseq_pcie_m2_pdata pwrseq_pcie_m2_m_of_data = { }; static int pwrseq_pcie_m2_match(struct pwrseq_device *pwrseq, - struct device *dev) + struct device *dev, int index) { struct pwrseq_pcie_m2_ctx *ctx = pwrseq_device_get_drvdata(pwrseq); struct device_node *endpoint __free(device_node) = NULL; diff --git a/drivers/power/sequencing/pwrseq-qcom-wcn.c b/drivers/power/sequencing/pwrseq-qcom-wcn.c index b55b4317e21b..ac6b34e01c51 100644 --- a/drivers/power/sequencing/pwrseq-qcom-wcn.c +++ b/drivers/power/sequencing/pwrseq-qcom-wcn.c @@ -335,7 +335,7 @@ static const char *const pwrseq_wcn3990_vregs[] = { }; static int pwrseq_qcom_wcn3990_match(struct pwrseq_device *pwrseq, - struct device *dev); + struct device *dev, int index); static const struct pwrseq_qcom_wcn_pdata pwrseq_wcn3990_of_data = { .vregs = pwrseq_wcn3990_vregs, @@ -436,13 +436,13 @@ static int pwrseq_qcom_wcn_match_regulator(struct pwrseq_device *pwrseq, } static int pwrseq_qcom_wcn_match(struct pwrseq_device *pwrseq, - struct device *dev) + struct device *dev, int index) { return pwrseq_qcom_wcn_match_regulator(pwrseq, dev, "vddaon-supply"); } static int pwrseq_qcom_wcn3990_match(struct pwrseq_device *pwrseq, - struct device *dev) + struct device *dev, int index) { int ret; diff --git a/drivers/power/sequencing/pwrseq-thead-gpu.c b/drivers/power/sequencing/pwrseq-thead-gpu.c index a45318b4b2c1..cb7a6ea66c4b 100644 --- a/drivers/power/sequencing/pwrseq-thead-gpu.c +++ b/drivers/power/sequencing/pwrseq-thead-gpu.c @@ -115,7 +115,7 @@ static const struct pwrseq_target_data *pwrseq_thead_gpu_targets[] = { }; static int pwrseq_thead_gpu_match(struct pwrseq_device *pwrseq, - struct device *dev) + struct device *dev, int index) { struct pwrseq_thead_gpu_ctx *ctx = pwrseq_device_get_drvdata(pwrseq); static const char *const clk_names[] = { "core", "sys" }; diff --git a/include/linux/pwrseq/consumer.h b/include/linux/pwrseq/consumer.h index 7d583b4f266e..d5d57cdb0c8e 100644 --- a/include/linux/pwrseq/consumer.h +++ b/include/linux/pwrseq/consumer.h @@ -11,10 +11,12 @@ struct device; struct pwrseq_desc; +#define pwrseq_get(dev, target) pwrseq_get_index(dev, target, -1) + #if IS_ENABLED(CONFIG_POWER_SEQUENCING) struct pwrseq_desc * __must_check -pwrseq_get(struct device *dev, const char *target); +pwrseq_get_index(struct device *dev, const char *target, int index); void pwrseq_put(struct pwrseq_desc *desc); struct pwrseq_desc * __must_check @@ -26,7 +28,7 @@ int pwrseq_power_off(struct pwrseq_desc *desc); #else /* CONFIG_POWER_SEQUENCING */ static inline struct pwrseq_desc * __must_check -pwrseq_get(struct device *dev, const char *target) +pwrseq_get_index(struct device *dev, const char *target, int index) { return ERR_PTR(-ENOSYS); } diff --git a/include/linux/pwrseq/provider.h b/include/linux/pwrseq/provider.h index 33b3d2c2e39d..a2ec6c612c8b 100644 --- a/include/linux/pwrseq/provider.h +++ b/include/linux/pwrseq/provider.h @@ -11,7 +11,7 @@ struct module; struct pwrseq_device; typedef int (*pwrseq_power_state_func)(struct pwrseq_device *); -typedef int (*pwrseq_match_func)(struct pwrseq_device *, struct device *); +typedef int (*pwrseq_match_func)(struct pwrseq_device *, struct device *, int); #define PWRSEQ_NO_MATCH 0 #define PWRSEQ_MATCH_OK 1 -- 2.54.0.563.g4f69b47b94-goog