From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4ABA3FE67C for ; Fri, 15 May 2026 09:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778835807; cv=none; b=Og4f7uBuUzFE5Qk58jX0Z2/dOshDlpvNPF/5ppLpnJLMGMs/vhJMsJVkS7Rn2PiEujj2k6uztxrd+iFoULeOPnF4jbNh5rkvKh5XfS6yJtR+zj7bIhRf1uSqP4brkHj6X4p1i23HQFOtgaETZUt5ZqInKsml0faCnxweqoUi/40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778835807; c=relaxed/simple; bh=hoH53fTp/9oZ7mpYprFOeWNKfT0wJTXGYD0JSfEjvvw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RybU6WPtkTd/gSRpTypKwVRl2QOl4IqnB+RCji2qCNxU+Bdn4K7ysBpcC5M+23aa2VafraR0fcIKupUVH/aFukF/LACBkTQi6L8xF548cyRphgBu/n3UBIfxQsCu/wMdCGeNFQkPz0TMF27N5MVzvtha6qXigGukxAoXRNzwTO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NAARaofm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CX4SO5mw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NAARaofm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CX4SO5mw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778835804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=LfHDA2lu9SdmcNfUFLEQpGK4hzLMbqXJdHhI2cGEcxc=; b=NAARaofmsV8xozr9D96amk7SQiv5BDl59oBpDaZZRXHQG4hY1QS5d76VMPm2zKut8ATe4f 5HsEgCV8UTYU2lb9iy9hY03+neq3KPj3a+XQ4kz12mWrD0H4y+qlokPbDSfUUXbkuBxTdU +ZpEpkyRHX04Ic2zsVMhitQZdDUmuH0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-n6cBMaCdMGG_mdRh2xYXVA-1; Fri, 15 May 2026 05:03:23 -0400 X-MC-Unique: n6cBMaCdMGG_mdRh2xYXVA-1 X-Mimecast-MFC-AGG-ID: n6cBMaCdMGG_mdRh2xYXVA_1778835802 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48d1b294dfeso77398245e9.0 for ; Fri, 15 May 2026 02:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778835801; x=1779440601; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LfHDA2lu9SdmcNfUFLEQpGK4hzLMbqXJdHhI2cGEcxc=; b=CX4SO5mwfIihbPnLZ1d5he6WYWpy0Om/HqTdKrVz+FmJUB0QgU8koQdX6yn7dNFrdH NFRKSvErN6gLB3T9EF648tcUb1nUhR20UteJeF5zEKD94pMKrI7qWE+I3Of/QQ4uiSwj MyIJUquIC/FhuR23ox4hI3A+qDZUpcKw6uwlhgjT7NFv44UzLuMuDhU3OhWU4s8fUCYK 6EEjRbnnRRq+o5rL4slVmei//CgWwsfHNJVWHPLkC/s8cyOgd1Rb3w2I2gf1qVMLaj9x da8UAOLfIL66gm1POdf4SkqElZc63OVCeLSeN2pIHzMWpj74l5wcOzVz8OzZyiomv7d0 ojug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778835801; x=1779440601; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LfHDA2lu9SdmcNfUFLEQpGK4hzLMbqXJdHhI2cGEcxc=; b=faVJuyhOxvwk5YMdoRvQ6cX6E+Fdx6sqFGQu/ZL+cxlDtgRpFWVxiWlzJPkRj1OgIc 79f7dJgIl0y656MDQnyLnRZ19mpr0HIpvYLexIKb1uBJd+5zvzkBbHhJkxI6q2eGuTIe go5w5EalSfWkb8yajN/cjeplS8PuMbK/PpKT+9dtrdC/yTwCWEBc1ohNsGGRhJ8bS5g6 2dD54JKL/5XMouXadtULXWz7QyFYTbdCWPD+UFTrPOH0B0BaCXQvhYLx9PQ0b+6BUDtM sJY5vzOBUf1eyRMKRIPS4rMwvtxXK3VdF7MpcGl4X6lgpa2Zt3x2+IVUudx2x2V0fiRS m3Uw== X-Gm-Message-State: AOJu0YzQmEOolkwaJFWVS88ZnruyZ1AP14KmIHJ/rEodRMjMN/Wrw5XA kmj8MVQWWyrcgld5vzBkOTrqnPFE9sYDcyUjPhurAeCL4vVueDc30H86ASDZDcD7dg4Cri+Ph6x KFrZ9BapClMxyZgRPCTH6WXjJDhDAs9eeQBIagT29dSd4V6VQnfaiza42lHn8jJttN+3lZja0dm wZvNzPpsvMx+zUvQTPiQ1Nt2U+oPpJXSGyRQy+qMtWgTyueSgo X-Gm-Gg: Acq92OHZxVfXtIbFHGoXC5n9vF1wimIkk6Xt6t4EJfAJUOl/uPjV+3/upKO6LkDJis1 a54mxbrjBdHxeF6tcA0o7skOjcfu1ndMJvKutcHlZn08jmGNFNeAagZsMJifL44HAUkUx91SaUH Vxer4u69wHH4e9DntyCSamXdoHu56liZc4qwLFrCmJsQD/EWGYclZS8koH5yfTRBkxEG6nW9IE/ EGINVwFj90lOY4C4Tf6E1RqmZFwKSm+7ZWyI76lk6ejtNoTf2lXcEckYLKSox6j+dfXOoUW0eMc TvES9cQClhQ8f7Gg3yJiE6z8w3NwEckdmTbBTiN455Yc/f+2306sdM63sYARzSWkRVqy1K+/oAz eZyK0bHDYEDwhWKgHdlsFSDsHLVmzOo5EhAd9ZwSZb+9CDsGyR0vGQYmO2g== X-Received: by 2002:a05:600c:3506:b0:485:40db:d40c with SMTP id 5b1f17b1804b1-48fe60e13d1mr41799815e9.3.1778835801429; Fri, 15 May 2026 02:03:21 -0700 (PDT) X-Received: by 2002:a05:600c:3506:b0:485:40db:d40c with SMTP id 5b1f17b1804b1-48fe60e13d1mr41798765e9.3.1778835800593; Fri, 15 May 2026 02:03:20 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4c88e5asm47427035e9.6.2026.05.15.02.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 02:03:19 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Andrzej Hajda , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Phong LE , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v4 0/3] drm/bridge: ite-it66121: Fix display output for DVI monitors Date: Fri, 15 May 2026 11:02:08 +0200 Message-ID: <20260515090220.809830-1-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Display output does not work when connecting an AM625 BeaglePlay board to a DVI monitor, because the DRM it66121 bridge driver assumes that the sink type is always HDMI. This patch series fixes the issue. Patch #1 reworks the driver to use the HDMI helpers instead of open coding the AVI infoframes buffer management. Patch #2 moves the .mode_set logic to the .atomic_enable handler. Patch #3 finally fixes the mentioned issue by using the display information to determine whether HDMI or DVI mode should be set. This is a v4 of the series, that addresses issues pointed out by Maxime. The patches were tested on both DVI and an HDMI monitors. Changes in v4: - Convert the driver to use the HDMI helpers (Maxime Ripard). - Move .mode_set logic to .atomic_enable (Maxime Ripard). Changes in v3: - Move the HDMI/DVI mode set to the .atomic_enable handler (Maxime Ripard). Changes in v2: - Don't store the sink type in a per-commit bridge state (Maxime Ripard). Javier Martinez Canillas (3): drm/bridge: ite-it66121: Switch to the HDMI connector helpers drm/bridge: ite-it66121: Move logic .mode_set setup to .atomic_enable drm/bridge: ite-it66121: Select HDMI or DVI mode based on sink type drivers/gpu/drm/bridge/Kconfig | 2 + drivers/gpu/drm/bridge/ite-it66121.c | 198 ++++++++++++++++----------- 2 files changed, 121 insertions(+), 79 deletions(-) -- 2.54.0 base-commit: 4c26e162947f91aa78ba57dd4fddd38fc80e7d60 branch: it66121-fix-dvi-mode-v4