From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from acj35aaf124.lhr1.oracleemaildelivery.com (acj35aaf124.lhr1.oracleemaildelivery.com [130.35.116.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 738D8302742 for ; Fri, 15 May 2026 13:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=130.35.116.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778850536; cv=none; b=VT1L3MvAdWE4ZevrQllra3L5bKItXjnF1rSZIa7KQZg5+rfUK8ENF+N+m/Cm5w+ugQtuwuc19r1iGBsrZj4Wrq4k6DAJlYO05XNlCmBi0YK2WGwAEaFa93LPBpApKUv1jZ55RYopdHtd3mNe2Jy+ScEwSri0a0+iwFjnOSjOFcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778850536; c=relaxed/simple; bh=fhyHfyW5NgKKHtnkNTA8/XP0rmI/Np861eMFIdMbxAE=; h=From:To:Cc:Subject:Date:Message-id:In-reply-to:References: MIME-version:Content-type; b=BgqcBAYOr8dAFpCGvnR4mFQMI8mafgqDBrmwL/2698dcR7WJbmL+71ZvDHcGSxrTYKShvcyB5Onrhou7B3t1A+R/56JLaBFgvoPdPKkMm5w2YVEafe3DSICq9krZ57Y24j1reTLXU++M1dn92HwSVVP15Mx83yQ8nI9GkcnPM2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raczylo.com; spf=pass smtp.mailfrom=lhr1.rp.oracleemaildelivery.com; dkim=pass (2048-bit key) header.d=raczylo.com header.i=@raczylo.com header.b=QfGY41ji; dkim=pass (2048-bit key) header.d=lhr1.rp.oracleemaildelivery.com header.i=@lhr1.rp.oracleemaildelivery.com header.b=wOzicmWx; arc=none smtp.client-ip=130.35.116.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raczylo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lhr1.rp.oracleemaildelivery.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raczylo.com header.i=@raczylo.com header.b="QfGY41ji"; dkim=pass (2048-bit key) header.d=lhr1.rp.oracleemaildelivery.com header.i=@lhr1.rp.oracleemaildelivery.com header.b="wOzicmWx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oracle-uk-012026; d=raczylo.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender:List-Unsubscribe:List-Unsubscribe-Post; bh=WmCkvmN6o6bO9QADm6W/QC4PRSk13s/99dA2BWd17CM=; b=QfGY41jiD3rSIaLVYwGgyrroTxbi3pV+iIe44mt2EsjtOunjYreqq4F+sduc2jmeRgJogOwMzkvC wFESWOGkXjZXxw0WBPbzE3VU6lIQfuc6QwY3KeQSENylq8e5XBg4sPaUdm1oDvcI1B4qKmZC84gK kxK1IY3iXoKU2JsXjI1UqFp9ZYXJpNiRvjY7GSDv6X0eC3ycHiXk3LxpXE86IYWWGnZ52+Z245pB YzzJZne5SjDbaVT0LIVwAj2+PGJHWIEaakLEeylDa9nXBfREU16wXhWZYqdHMpY2xw+a6xp/56Bk L3IJlUBwrBpUWwPmlmI4/bRggF08iqN9yw4k8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-lhr-20191104; d=lhr1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender:List-Unsubscribe:List-Unsubscribe-Post; bh=WmCkvmN6o6bO9QADm6W/QC4PRSk13s/99dA2BWd17CM=; b=wOzicmWxaPZb3r3ya3sbNMKiZCMliz+vcVuCR5apwW+rcBWww3cDvIdIRzC5f+VLuosY8hvDPhZM R+a44nKxz8DJUELApdBgnkfsynC4a0cQirVWt4QBh0Ak+9pG5wUrF8uHv/Wyn+u9zWDThi4ZFdgw +g89ry6c8H8eRbNxbFRgEVA+FYum2g1r9+cveWPTXnrpj4li02n5vPChbVXPxm7KCnumTIyJ5MSg 7o5UPU1EGLDd1B+mVbQi03RIY2W60u1V3yuuf9pORYJpnnlvLquF8OcBADnyDLAn3YC3Xxebnt7f 5ioO9iH0XKo6yV6KvXbNYLu7ZtHkcIsX0PozbQ== Received: by omta-ad1-fd3-1401-uk-london-1.omtaad1.vcndplhr.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20260212 64bit (built Feb 12 2026)) with ESMTPS id <0TF21Z7JUXUP8AA0@omta-ad1-fd3-1401-uk-london-1.omtaad1.vcndplhr.oraclevcn.com> for linux-kernel@vger.kernel.org; Fri, 15 May 2026 13:08:49 +0000 (GMT) List-Unsubscribe-Post: List-Unsubscribe=One-Click From: Lukasz Raczylo To: netdev@vger.kernel.org Cc: Theo Lebrun , Andrea della Porta , Nicolas Ferre , Claudiu Beznea , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2 3/3] net: macb: add TX stall watchdog to recover from lost TCOMP interrupts Date: Fri, 15 May 2026 14:08:49 +0100 Message-id: <20260515130849.920-1-lukasz@raczylo.com> X-Mailer: git-send-email 2.54.0 In-reply-to: <20260514215459.36109-4-lukasz@raczylo.com> References: <20260514215459.36109-1-lukasz@raczylo.com> <20260514215459.36109-4-lukasz@raczylo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit Reporting-Meta: AAFF3HPCkK227CD7Se5cCyOO/blLikgODObmwE6SfhbsjUFD20BWLFJliQfsfrvY BFb1EX9GcB+16PC4cMFtM4XkUsoI59cMbEc/G/MZwqNmPFw5SZuS5y+wCViwv9JD J9XEZRKEH2pDEqN6dxkvAzXYE7W/m7guUzNlLrrDpngKm9KX1nnD5WI+JRlL3t0s ZBBhUDRMcHnPEl7CBt1klYIUW95GIikvenn17USt0lY+l4PRNfMJPrNmHFT4thTr rB3woBYDwQgrsPK0iMvsf2hXJ9ttJKB25Eu3umh58llBkBw4dJJrrOn7ZC4t+8y7 o4ksVc2IdGRIvw0/WLOvgSGMWCBGDExMjgjv4QWWwBYX6x1Urz99bGlMkgDBcpbH zfnNM1B4awm2K1SRa5hdYP3TlOC7S6c/wLBfwX5r6uxbKs26KsewfJfCtk6p0rAI zA== self NACK This patch references netdev_warn_ratelimited(), which does not exist in mainline net-next or in raspberrypi/linux rpi-6.18.y -- no netdev_*_ratelimited() helper is defined. I confused it with the existing net_warn_ratelimited() / pr_warn_ratelimited() / dev_warn_ratelimited() family while authoring v2. The result fails to build with implicit-function-declaration on every kernel that includes . The bug was caught by John Laur via an independent build test on the Talos Linux Pi 5 build and reported at: https://github.com/siderolabs/sbc-raspberrypi/issues/91#issuecomment-4456874307 I incorrectly tried to address this by sending a standalone fix-up patch to netdev as: https://lore.kernel.org/netdev/20260515095336.92237-1-lukasz@raczylo.com/T/ Andrew Lunn pointed out that this is not the correct workflow on netdev -- the right thing to do is self-NACK the broken patch on the original thread, wait 24 hours, and resend the whole series as v3. Apologies for the noise; this reply is that self-NACK. Patches 1/3 and 2/3 do not reference netdev_warn_ratelimited() and are unaffected by this build break; their content stands. In v3: * 3/3 will use `if (printk_ratelimit()) netdev_warn(...)` in place of the non-existent netdev_warn_ratelimited(), matching the semantics intended in v2 (bounded log noise, retains the netdev prefix in the message). * The standalone fix-up patch above (Message-ID <20260515095336.92237-1-lukasz@raczylo.com>) should be considered withdrawn -- v3 supersedes it. * Cover letter will carry a changelog noting the v2->v3 delta and this self-NACK. I will send v3 no earlier than 24 hours from this message, per Andrew's guidance and standard netdev practice. Signed-off-by: Lukasz Raczylo