mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>,
	 "parthiban.veerasooran@microchip.com"
	<parthiban.veerasooran@microchip.com>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	 "davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	 "kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	 "robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	 "conor+dt@kernel.org" <conor+dt@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	 "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered
Date: Sat, 16 May 2026 12:04:23 +0200	[thread overview]
Message-ID: <20260516-acoustic-rapid-lorikeet-7c1a2f@quoll> (raw)
In-Reply-To: <3bfd9650-bf67-4abb-8820-2cab95ef6402@lunn.ch>

On Fri, May 15, 2026 at 06:40:45PM +0200, Andrew Lunn wrote:
> > Also, did you consider the board layout?
> 
> Hum. How would a board design convert a level interrupt into an edge
> interrupt?

I don't know how feasible or useful in practice, but such converters in
theory are simple:

1. RC differentiator + Schmitt trigger
2. Logic-gate edge detector
3. Monostable (“one-shot”) pulse generator
4. Flip-flop / synchronizer logic in CPLD/FPGA/MCU
5. Dedicated interrupt-controller or GPIO expander ICs

Different point is that Rob said these flags should represent what the
device expects. I disagree with that, because except RC delay GPIO
bindings, we do not have representation of any inverters, thus this flag
should rather represent the final board layout.

> 
> Use the level signal to gate a clock signal? So while the interrupt is
> low, you get a stream of edges? Does that really exist?
> 
>      Andrew

  reply	other threads:[~2026-05-16 10:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 16:13 Selvamani Rajagopal
2026-05-15 16:15 ` Krzysztof Kozlowski
2026-05-15 16:40   ` Andrew Lunn
2026-05-16 10:04     ` Krzysztof Kozlowski [this message]
2026-05-15 16:44   ` Selvamani Rajagopal
2026-05-15 19:06   ` Andrew Lunn
2026-05-16 10:05     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260516-acoustic-rapid-lorikeet-7c1a2f@quoll \
    --to=krzk@kernel.org \
    --cc=Selvamani.Rajagopal@onsemi.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=parthiban.veerasooran@microchip.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®