From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DCFD30C143 for ; Sun, 17 May 2026 07:38:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779003523; cv=none; b=C0UOJnp+3ZIXp4ZluYj8k9z6Cqd+YzlN3r7mHCJl2VrAE5wcIiZX82f7gblth3HaBF9QqIlNt2NyC0sjSQq4vyJyr1Zh/fiLnhPqjmY44TWyIFtooJF/sPTDStRYb/jxn/8w/Jct8YLjsEiEkFZyMhfPnH+tsoBOSryKOvpEiu4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779003523; c=relaxed/simple; bh=+bAYzSMtgGe6jAWIBLroL6sWqUmQ3b+44DTNSpTptZE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ln3O5c+X50ExC499UFUqmkVF835V2MrIHPO/w0JN0NtVS2mNI6GeWOybmk/nSS69i3b7daybt0rpbmYyeiUwD51GGz/KFt9k0OwIQHFaCmtB2wmqEgF0jvcGYxjOqQV/Y7nbXkdD841E23zwxnLcZgfZKslS6xz+qCbzgfJEsXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eqZ1jV7o; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eqZ1jV7o" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488ac04e13dso1455375e9.1 for ; Sun, 17 May 2026 00:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779003520; x=1779608320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yz7DhL9krHcmEm4nIRswzkcLhOJC+H+xp62jTsPy1Ss=; b=eqZ1jV7oEY/CbSqWC0AC3UuyML2oEzHqCF1Y2bWRLrFECUpcoSGI9XVJLPqI7GfILM jcP6BX21/Q7UINbqhlbBtxV3nlPtjOyMTG0yRtke4Pj3kexwHeemWgAMCKqGSL7zHfab CkKu4zbCOrNuGX1rrgMRwuMJGu9KfUg7b4kMph1rIKxPe5dJIve2iUIPqjeM9icrhzK7 xKZmH1jCZO8HssUmcCJGGnPb83o+HboMDdkCDlYifjig0bjJfonJgKt9WuoAUnTDhO7k qE0V2sx55oAM4B7lmLJPNBOWVTK5cWzw4VL54kU4/UvRfORcX6wByiZ0haKyIn1pQ2hx Fq7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779003520; x=1779608320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Yz7DhL9krHcmEm4nIRswzkcLhOJC+H+xp62jTsPy1Ss=; b=lPUvfzUI5AzhOFrTrXhgczbeobqdN1wERC2H1G01RBqn1H4LoiCavFIsJXjBrbsss8 Zyai1nAGlOScuiI19Bs08Mefq3TOVLGrRdqeFvuKWmb62OiDXMmbX/B8uOcgCnb+1b1k 63jRHs/h88ktdblRFVjCXw1I/RjyqyfmmlvMfUWOTBXcD+i0JUjEXOZabVeV4SryJYLl Xsn7rXvslS8n5R4CnTzNFShvkPi5h/A2RPBSIQ5jp59eFCvScsiQSWz6U4eX2B97Neu+ EQZLKn2u2SYDOzPig4m7hBarn1fK/tFIPtRJU0gKjapTovRfrey198kgH2Wu1fFXyBrw aSNQ== X-Forwarded-Encrypted: i=1; AFNElJ/o1WyqOXKvM0penpHTTvwkDZtnBdzLm8C5TQ0n3s74v9yBhQPbxfpX1CM3fDHDjTZH5dfZWFLV7L7ZalA=@vger.kernel.org X-Gm-Message-State: AOJu0YxKWHGo8y87eGIwDpFzlc1+5uS/22tuUBjP7/Ev7A6CvIoaDtMy p5uMVo045XaU0xfsRRRrI+/lwSaq6AF45Vs+lzUKMPmFKKYeawOML8Nb X-Gm-Gg: Acq92OEeRYyYwYmlEb2x+cXy2MskM4x35QUexrfXfJcL/UQ3D7lcGjWR3hjq1MDcn1R 98DZ5tCqQIC5WFPKJQCHMkYkG5WJ5ZWuo0klPhl99ft86z1OSbdGhi4Af/5yI8149vmddHMUDqf E2vif6ciefIQWuBS97OEYe6z6CHd1RAgYVuAHBSqeLBVpa+SsE/CNNSm0zMJJbNhtVz8wV5b+Br f9QB+57+Qf6x7c3tMtNDPsonzrDSWL6zOghiyRuXWDnGpUH+vgrqKuSx/W6OcD/G33sxIkKVwEI S7wD3rZMTZnyWoDg7FDM/KrXDoZL07lrEqv10UsBdIBfkdcxJwLfgX+fMqj+1VDxIebx+sX2rfq Cj/nOgWNFLfKYbAefkrFlelX+c69reOfyuE2SZiFnQWEbnacwR0CXKzWFhJ5nF5yxXs/b0UkCov PYFUuLFZTMOsajgzih1rLfXoyCkkof89phgyCtDpgQpc1uwQjDX2Bfvc4= X-Received: by 2002:a05:6000:4404:b0:45e:73a2:3093 with SMTP id ffacd0b85a97d-45e73a230eemr634420f8f.4.1779003520494; Sun, 17 May 2026 00:38:40 -0700 (PDT) Received: from localhost.localdomain ([82.215.118.79]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe248dsm27487015f8f.30.2026.05.17.00.38.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 00:38:40 -0700 (PDT) From: Stepan Ionichev To: salah.triki@gmail.com Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Stepan Ionichev Subject: Re: [PATCH v7] iio: humidity: ens210: Extend I2C functionality check Date: Sun, 17 May 2026 12:38:22 +0500 Message-Id: <20260517073823.1280-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <20260516173148.3209f7fe@jic23-huawei> References: <20260516173148.3209f7fe@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, May 16, 2026, Jonathan Cameron wrote: > Sashiko pointed this out... Take a look at definition of I2C_FUNC_SMBUS_BYTE_DATA > and consider if the line above makes sense. Check for other instances of > this. grep across the driver shows what actually gets called: i2c_smbus_read_byte_data -> I2C_FUNC_SMBUS_READ_BYTE_DATA i2c_smbus_write_byte_data -> I2C_FUNC_SMBUS_WRITE_BYTE_DATA i2c_smbus_read_word_data -> I2C_FUNC_SMBUS_READ_WORD_DATA i2c_smbus_read_i2c_block_data -> I2C_FUNC_SMBUS_READ_I2C_BLOCK i2c_smbus_write_byte() (without _data) is not called anywhere in the driver, so the WRITE_BYTE flag in the current mask is dead. WORD_DATA asks for both read and write word data, but only the read side is used. Minimal correct mask: I2C_FUNC_SMBUS_BYTE_DATA | /* read + write byte data */ I2C_FUNC_SMBUS_READ_WORD_DATA | I2C_FUNC_SMBUS_READ_I2C_BLOCK Stepan