From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA957310785 for ; Sun, 17 May 2026 07:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779003826; cv=none; b=Eve/0pwMiQkIWrGUMU1nBim8NAYhyM/ls+ml2pTRYEOIVIUrXN7Ebl9xnJGO7G7uLHUmtyHTJFJFt+MmuaYtMO59z8+7BKGWsTgUOJ5JEKFvBXbzWqFdo9fMKV3p7feR7WYhZMaE8QgzfEIZ5gnN+TZwz1f+HOW/WOmXz/zCN38= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779003826; c=relaxed/simple; bh=YDvzhtpKlF4YyG+3rcF4wl/f1z7vrexwv/RtY92FvxI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lOKwGX7sn3r1fDdE9g2/e3gljPDP/RhF4Dfy2bz6O2zb/gP1uGY/KFLWF3K0plSz3iCSb/E6t0LtE+fBrEcC9v0d5jWjhVLo70yv9h5Sy7h/mPRWlGYvJ0YuSHXbMFJYRIK6PUgbnBZ7l2rDJdCAgwT7BYeRg2l9vcLE2uWMNGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vwer9Jlt; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vwer9Jlt" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-452169ae568so690978f8f.3 for ; Sun, 17 May 2026 00:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779003819; x=1779608619; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0LzbpjsuKPCXdtxH83s9qoUUdpBAxIBv3nnvj0Qfzzw=; b=Vwer9JltXQOWgcvgTjf2dSCnv7RIw5v1yF4JR02LuTu6WcQbmJyNODS9iKnIXJYCq7 8cZ0Q+qKM5jgfaoWeCDGEsAk+7UnwWvJUfmvQkJMe4KCNR2B5unVLJ0gmbvLmLUWzSbj Weswr4xAkLH8DqLvjxPCU+EJMetfboFl0qvCFxB7dPIMR9RzrgVS7M7mArDWzcIiuNvN 0N4BOL3s8Lu93bIq1t835Q54RnbNIr1Bsrl3yMX7uJ7ZWAn8/nXUv1nkeVfzLZgbcLLd liLOUroMTrMbjVdV4mbge5R94uskFopQatOCMGn74eOs8MHi0wWlnMFon2Bg7xOIYB2g pGhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779003819; x=1779608619; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0LzbpjsuKPCXdtxH83s9qoUUdpBAxIBv3nnvj0Qfzzw=; b=Z/P4+zf14sMs6ZZ30OXKHo9RuF+p4hHQfzB3aFk5TD4hVs8ik+280liQwCE/+qY324 +/omngjGhNNXFZcKIwLKYTilJ321MfgpjtcS2DgmeXNQgIn8NRY2lNZUJDXOJ2FUdiV9 JJWJ+S3RMPRYzpl6Tzq1eQUOCbQs5rT7kuYKufa+jzLwwWlh18tHVY52sRFzUQRxBOnk 3Apw0PWivgCUnESf67GVtDSJozYdXo7VTv27e0XyKiermTTtPSj6S5e9pomaUCt/CgPP 2jpNV5/+RpoKomCHyfSulqlUojzS7WfBs11zwB/n7ghu8aWoS+e4pNPmbszqETBSq8yv cIWA== X-Forwarded-Encrypted: i=1; AFNElJ8f37Imp99Yh0ajnaiIaWgEpu+Io4ZiaOkbRScxtUbeG4AnDe7NKyVEKihAWqexHHHA718hVIUXLrTUwaM=@vger.kernel.org X-Gm-Message-State: AOJu0YwP7la59a3luLwwJOSOwP+mj3Ix71YuMCbicn2D9uK6+QZ6JY7I 98ZoFXtD1wANzKQM6A6L4Au56O90fVxADnM3oZJGBcCCK7yQSW3EJHH8 X-Gm-Gg: Acq92OEj0Ss0Q/qSh30gm7sJcT/Jga350BNB6vMrYp9u18bnGD8wVBOww1IIbt/WW9r S+MyfgHoFlIub5JnIAc2KqbVGwFzYJ31kUV7IQjkPOgSKwZGwfAv44sU09Jy9bs0cA3C1d0SMrN QG45ZYaYsm4xKfJKC6il6TvYAVm00qq5DJO2dkm18WtTRGkTYgZkhkwmFos2zyi4P1Rwp6RwgkX cvktD7m/Il+aS7SjVmTiUoPUFGzUyE5cTkDZv5xAyIxdFBA0CzPa8eZ9wjmC1py3smkhgddhIrn 1AieziLS9G0BbTucEN4+UCLy2lhn211YTf+IYBJYCXpO114uHOCyNeefA9TPHybs13Ik00KqlDg g/ATOSZ27GtHVPB5DKV9U0nRnqeaWaM9jb8zTL9oGfBr2srZ/bh1HfR8E/fy4U1KHmkyH7GyxOJ soYg8PqEnysQHC X-Received: by 2002:a05:6000:603:b0:43d:7c6c:a0dd with SMTP id ffacd0b85a97d-45e5c609a1dmr15044926f8f.35.1779003818881; Sun, 17 May 2026 00:43:38 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe248dsm27512864f8f.30.2026.05.17.00.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 00:43:38 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Helge Deller , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v1 5/6] video: backlight: lm3533_bl: Set initial mapping mode from DT Date: Sun, 17 May 2026 10:43:05 +0300 Message-ID: <20260517074306.30937-6-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260517074306.30937-1-clamor95@gmail.com> References: <20260517074306.30937-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support to obtain the initial mapping mode from DT instead of leaving it unconfigured. Additionally, update the linear sysfs code, which uses a similar coding pattern. Signed-off-by: Svyatoslav Ryhel --- drivers/video/backlight/lm3533_bl.c | 32 ++++++++++++++++------------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm3533_bl.c index 42da652df58d..be9114b7e0ad 100644 --- a/drivers/video/backlight/lm3533_bl.c +++ b/drivers/video/backlight/lm3533_bl.c @@ -22,6 +22,7 @@ #define LM3533_BL_MAX_BRIGHTNESS 255 #define LM3533_REG_CTRLBANK_AB_BCONF 0x1a +#define CTRLBANK_AB_BCONF_MODE(n) BIT(2 * (n) + 1) struct lm3533_bl { @@ -32,6 +33,7 @@ struct lm3533_bl { u32 max_current; u32 pwm; + bool linear; }; @@ -135,8 +137,9 @@ static ssize_t show_linear(struct device *dev, struct device_attribute *attr, char *buf) { struct lm3533_bl *bl = dev_get_drvdata(dev); + int id = lm3533_bl_get_ctrlbank_id(bl); + u8 mask = CTRLBANK_AB_BCONF_MODE(id); u8 val; - u8 mask; int linear; int ret; @@ -144,8 +147,6 @@ static ssize_t show_linear(struct device *dev, if (ret) return ret; - mask = 1 << (2 * lm3533_bl_get_ctrlbank_id(bl) + 1); - if (val & mask) linear = 1; else @@ -159,23 +160,16 @@ static ssize_t store_linear(struct device *dev, const char *buf, size_t len) { struct lm3533_bl *bl = dev_get_drvdata(dev); + int id = lm3533_bl_get_ctrlbank_id(bl); unsigned long linear; - u8 mask; - u8 val; int ret; if (kstrtoul(buf, 0, &linear)) return -EINVAL; - mask = 1 << (2 * lm3533_bl_get_ctrlbank_id(bl) + 1); - - if (linear) - val = mask; - else - val = 0; - - ret = lm3533_update(bl->lm3533, LM3533_REG_CTRLBANK_AB_BCONF, val, - mask); + ret = lm3533_update(bl->lm3533, LM3533_REG_CTRLBANK_AB_BCONF, + linear ? CTRLBANK_AB_BCONF_MODE(id) : 0, + CTRLBANK_AB_BCONF_MODE(id)); if (ret) return ret; @@ -253,8 +247,15 @@ static struct attribute_group lm3533_bl_attribute_group = { static int lm3533_bl_setup(struct lm3533_bl *bl) { + int id = lm3533_bl_get_ctrlbank_id(bl); int ret; + ret = lm3533_update(bl->lm3533, LM3533_REG_CTRLBANK_AB_BCONF, + bl->linear ? CTRLBANK_AB_BCONF_MODE(id) : 0, + CTRLBANK_AB_BCONF_MODE(id)); + if (ret) + return ret; + ret = lm3533_ctrlbank_set_max_current(&bl->cb, bl->max_current); if (ret) return ret; @@ -333,6 +334,9 @@ static int lm3533_bl_probe(struct platform_device *pdev) bl->pwm = 0; device_property_read_u32(&pdev->dev, "ti,pwm-config-mask", &bl->pwm); + bl->linear = device_property_read_bool(&pdev->dev, + "ti,linear-mapping-mode"); + ret = lm3533_bl_setup(bl); if (ret) goto err_sysfs_remove; -- 2.51.0