From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 298A0313E34 for ; Sun, 17 May 2026 07:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779003826; cv=none; b=i3VEkaqRMH3lKp30C8Hlx2hTL7VzkPQM4rUwbQbT8gg8LllaCDnFBOt3lV7W3AgHlf9CI+AqKfiVB7xyBGy1p5DU/vqBzaGm9EilZbY2Qc4IYOTVXjWwHvdcGpEHfmoRzIziC/BhU8ZC3pn0/QJv2ZAKZwXo9GsuOgkS7MrDug0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779003826; c=relaxed/simple; bh=txOclh6WzEZ2psojIZqT/u47okXxsKm65cDAQQqxUbU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V83AhSkSQ6hXts51xRkQ5VbFgoyekrvyWHmR4beG26kHNZ3fYyo8U6Ii0AJx1KfpJQe3SyFLn1P9aBDQK/qby+c5laZDzOt1XV1ifiJVhEsGNMiKXHOPsGTHCTSjXvdurmaTujYZ1L0R8QdlWLe4owtYCef+yBOS7NIs986qpqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y0m7rJCl; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y0m7rJCl" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-43d73422431so711140f8f.2 for ; Sun, 17 May 2026 00:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779003820; x=1779608620; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fIRirlk7+iVvv+aIkrP/TTxntKDqtRTgAMbNyHeeulc=; b=Y0m7rJCl3WVA+TclXfdJwwP0opYEszxaDLhFF1gewLciSbIslwjl/fgle3gZY8flZW rM/RUX+stF1OeJIvEECD9KFd9hTCkqFOLMC0cs0MVhm+4NymBz/+gby+O14NEQDauLiC bujCgC/Ik3T43kMC49yXr6xfInG7amndCbykpg/VSsnTx7F/bTVZuqCOrSAUNLpxFgXK vvgC7KDyKE6wF23INni8Wx2CaJBGzKWmYoDx29C4UBkIitljt1964NkZhrbdXPwk0XUU laYqHxKb4vsd2Nqygibm4x4l6UNq2tsS3uW1Qb2lZ1ycH7UFN413Rsgj7QOalasYewPY lYtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779003820; x=1779608620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fIRirlk7+iVvv+aIkrP/TTxntKDqtRTgAMbNyHeeulc=; b=GhhZgn3fEBO9/p4xZRKbUlcZOQh7xaAN7rTz1KjS3TQ25YjnD4e16xXBENbXC7shrt XoJSJJDQxSPt3v3b1bbC96eu2YqbIt04CxjwICQOWV6CHkxZipkVPaMv28AifdNe5cOn vA4ij/psvAQnA/6Te8Zdy92YKTs1XF8Ek8IU8HilrQqRajsFpBv1cyo+oEqAifKeGWhQ JZNwNXHJbY/1wHvKt9zCDTydjxa3BGl9BybQwNC8OhhZIoPtkCQEsG0/zR1FyGBwBAne 5glJmqUt0xHHntus9LDQWXRVivt2wza5qEc1SVJCF+4LGSlcT9u5aBRKaDhKdvlX7HSc ywLg== X-Forwarded-Encrypted: i=1; AFNElJ/jh8OPdOxX8mrs5Uz6D4JfO0J/ym/mDOvpZ8+4PkjF5m/MwodeTVYv99KgKYMY66CrFCL8yUmVYx0W8SI=@vger.kernel.org X-Gm-Message-State: AOJu0YztMhfk+wcC0mR+VYa1MJXtH+NfPmWA+w7sTk/0DeK0L+Vijeqr hkixu89AylJgDCdUxwX/DfM/40xU/bdRLFcwG791YVc7BIVE4xaDSUjk X-Gm-Gg: Acq92OFVbAjFPdmK2TFlvdQn0uWl8J2HG7C72lrYmzi1zxyHJdlYSXq83Hrzsop8+2j 10Vlhm8fiE+TJgPEipaU0I1au8/CoVz6ztPd/A+R8Y6ve/BcxhycObTDWz3JXx2W+B3jLPDMr4k I0cATFxa/GS2mpE/8n4Ki1txAV/Y9PUwdnOrvSjWW+ixJyTzy67WmWpYE12MDGAbcbzQLInHQUw DA9s+5zTZ+K3s37n7etYqM9T6Zix3xeGwCwiCwNa6AoV3N7pNodkLKK27HKchryrGL4APTmKYKb lNUlMaJPZdrCRVNAxktkGzd1GRumZw49P7+JKdr7exzjVgkWLbizAhQYAHncWV6Z25i2+bPtUn4 D3WJHP6Itr4HPkD2OT/UMjMe+raJj1olT1k0islaLwPhjS8ggmQz5zpT88NAZwcB1fbryA6cJKJ EoYWxj9J4rcR/f X-Received: by 2002:a05:6000:22c5:b0:43d:7d24:b510 with SMTP id ffacd0b85a97d-45e5c5fd8demr15790172f8f.22.1779003820408; Sun, 17 May 2026 00:43:40 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe248dsm27512864f8f.30.2026.05.17.00.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 00:43:39 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Helge Deller , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v1 6/6] video: leds: backlight: lm3533: Support getting LED sources from DT Date: Sun, 17 May 2026 10:43:06 +0300 Message-ID: <20260517074306.30937-7-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260517074306.30937-1-clamor95@gmail.com> References: <20260517074306.30937-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add Control Bank to HVLED/LVLED muxing support based on the led-sources defined in the device tree. Signed-off-by: Svyatoslav Ryhel --- drivers/leds/leds-lm3533.c | 55 +++++++++++++++++++++++++++-- drivers/video/backlight/lm3533_bl.c | 39 +++++++++++++++++++- 2 files changed, 91 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c index f6345bc1f443..c4eaf30880a1 100644 --- a/drivers/leds/leds-lm3533.c +++ b/drivers/leds/leds-lm3533.c @@ -7,6 +7,7 @@ * Author: Johan Hovold */ +#include #include #include #include @@ -26,6 +27,12 @@ #define LM3533_ALS_CHANNEL_LV_MIN 1 #define LM3533_ALS_CHANNEL_LV_MAX 2 +#define LM3533_REG_OUTPUT_CONF1 0x10 +#define OUTPUT_CONF1_MASK GENMASK(7, 2) +#define OUTPUT_CONF1_SHIFT 2 +#define LM3533_REG_OUTPUT_CONF2 0x11 +#define OUTPUT_CONF2_MASK GENMASK(3, 0) +#define OUTPUT_CONF2_SHIFT 6 #define LM3533_REG_CTRLBANK_BCONF_BASE 0x1b #define LM3533_REG_PATTERN_ENABLE 0x28 #define LM3533_REG_PATTERN_LOW_TIME_BASE 0x71 @@ -40,7 +47,7 @@ #define LM3533_REG_CTRLBANK_BCONF_ALS_CHANNEL_MASK 0x01 #define LM3533_LED_FLAG_PATTERN_ENABLE 1 - +#define LM3533_MAX_LEDS 5 struct lm3533_led { struct lm3533 *lm3533; @@ -53,6 +60,9 @@ struct lm3533_led { u32 max_current; u32 pwm; + + u32 num_leds; + u32 leds[LM3533_MAX_LEDS]; }; @@ -639,7 +649,30 @@ static const struct attribute_group *lm3533_led_attribute_groups[] = { static int lm3533_led_setup(struct lm3533_led *led) { - int ret; + u32 output_cfg_shift = 0; + u32 output_cfg_val = 0; + int ret, i; + + if (led->num_leds) { + for (i = 0; i < led->num_leds; i++) { + output_cfg_shift = led->leds[i] * 2; + output_cfg_val |= led->id << output_cfg_shift; + } + + /* LVLED1, LVLED2 and LVLED3 */ + ret = lm3533_update(led->lm3533, LM3533_REG_OUTPUT_CONF1, + output_cfg_val << OUTPUT_CONF1_SHIFT, + OUTPUT_CONF1_MASK); + if (ret) + return ret; + + /* LVLED4 and LVLED5 */ + ret = lm3533_update(led->lm3533, LM3533_REG_OUTPUT_CONF1, + output_cfg_val >> OUTPUT_CONF2_SHIFT, + OUTPUT_CONF2_MASK); + if (ret) + return ret; + } ret = lm3533_ctrlbank_set_max_current(&led->cb, led->max_current); if (ret) @@ -713,6 +746,24 @@ static int lm3533_led_probe(struct platform_device *pdev) led->pwm = 0; device_property_read_u32(&pdev->dev, "ti,pwm-config-mask", &led->pwm); + led->num_leds = device_property_count_u32(&pdev->dev, "led-sources"); + + /* + * If led-sources property is not set then either this Control Bank uses + * its default LVLED or is not linked to any LVLED at all. + */ + if (led->num_leds <= 0 || led->num_leds > LM3533_MAX_LEDS) + led->num_leds = 0; + + if (led->num_leds > 0 && led->num_leds < LM3533_MAX_LEDS) { + ret = device_property_read_u32_array(&pdev->dev, "led-sources", + led->leds, led->num_leds); + if (ret) { + dev_err(&pdev->dev, "failed to get led-sources\n"); + goto err_deregister; + } + } + ret = lm3533_led_setup(led); if (ret) goto err_deregister; diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm3533_bl.c index be9114b7e0ad..2898cb229643 100644 --- a/drivers/video/backlight/lm3533_bl.c +++ b/drivers/video/backlight/lm3533_bl.c @@ -7,6 +7,7 @@ * Author: Johan Hovold */ +#include #include #include #include @@ -21,9 +22,12 @@ #define LM3533_HVCTRLBANK_COUNT 2 #define LM3533_BL_MAX_BRIGHTNESS 255 +#define LM3533_REG_OUTPUT_CONF1 0x10 +#define OUTPUT_CONF1_MASK GENMASK(1, 0) #define LM3533_REG_CTRLBANK_AB_BCONF 0x1a #define CTRLBANK_AB_BCONF_MODE(n) BIT(2 * (n) + 1) +#define LM3533_MAX_LED_STRINGS 2 struct lm3533_bl { struct lm3533 *lm3533; @@ -34,6 +38,9 @@ struct lm3533_bl { u32 max_current; u32 pwm; bool linear; + + u32 num_leds; + u32 led_strings[LM3533_MAX_LED_STRINGS]; }; @@ -248,7 +255,8 @@ static struct attribute_group lm3533_bl_attribute_group = { static int lm3533_bl_setup(struct lm3533_bl *bl) { int id = lm3533_bl_get_ctrlbank_id(bl); - int ret; + u32 output_cfg_val = 0; + int ret, i; ret = lm3533_update(bl->lm3533, LM3533_REG_CTRLBANK_AB_BCONF, bl->linear ? CTRLBANK_AB_BCONF_MODE(id) : 0, @@ -256,6 +264,16 @@ static int lm3533_bl_setup(struct lm3533_bl *bl) if (ret) return ret; + if (bl->num_leds) { + for (i = 0; i < bl->num_leds; i++) + output_cfg_val |= id << bl->led_strings[i]; + + ret = lm3533_update(bl->lm3533, LM3533_REG_OUTPUT_CONF1, + output_cfg_val, OUTPUT_CONF1_MASK); + if (ret) + return ret; + } + ret = lm3533_ctrlbank_set_max_current(&bl->cb, bl->max_current); if (ret) return ret; @@ -337,6 +355,25 @@ static int lm3533_bl_probe(struct platform_device *pdev) bl->linear = device_property_read_bool(&pdev->dev, "ti,linear-mapping-mode"); + bl->num_leds = device_property_count_u32(&pdev->dev, "led-sources"); + + /* + * If led-sources property is not set then either this Control Bank uses + * its default HVLED or is not linked to any HVLED at all. + */ + if (bl->num_leds <= 0 || bl->num_leds > LM3533_MAX_LED_STRINGS) + bl->num_leds = 0; + + if (bl->num_leds > 0 && bl->num_leds < LM3533_MAX_LED_STRINGS) { + ret = device_property_read_u32_array(&pdev->dev, "led-sources", + bl->led_strings, + bl->num_leds); + if (ret) { + dev_err(&pdev->dev, "failed to get led-sources\n"); + goto err_sysfs_remove; + } + } + ret = lm3533_bl_setup(bl); if (ret) goto err_sysfs_remove; -- 2.51.0