From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D999E24E4C4 for ; Sun, 17 May 2026 13:52:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779025943; cv=none; b=r13XT8rw6OF6M0mN3T9u+3hR0ypIgr//VSEXczv6C3DVIj4wTvw8CvqX1PwVpCfigCSlJ5DKhJ7DGAMlqyJDV8JHEZb648apcrAbGEppB/nrycMKh9o9+5DgU5OJ8V9mfmo2mDXI9xCxGfT65EdOFr+OiY0q7G+uk25A5rXBmL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779025943; c=relaxed/simple; bh=yvRThhtFRzgNLNcZCuDT8RcuBgO7/FLtuzpeOVLUW9M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KDfnqv2ZlBi8TvaVp/7ixWd0mj4JsuFZQ0whn5zYsWv46x+cetrXmxzC0+b4KFpvXtZ3I8Dh5q1XDr9HN5BCNh6RfGxktx9S0zldmTAfDgEQcY8DWJ0Bh5+6Gs64xAZII9JfNpN/P3mlAQlGH+5aNnO8qa3CnHLBHWl/06T+U9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BhiAP5RV; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BhiAP5RV" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2bcd3ac3307so7649595ad.0 for ; Sun, 17 May 2026 06:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779025941; x=1779630741; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1t7vRy14fAIhG2Wr4kGou1JDcvmH5z+z8GUCNDyefuA=; b=BhiAP5RVnssOdyMMW3sT74bM4e4o+oiqPzeOm6hNPJMKOjVaQ4Fxj3J4dbg0qZNr7Z XM3cr5Rd37AO7AB70CkJUXU9Qa0UP4aWPc5TOIla705YFg0e54dknqTAV/ojSz0hEWG+ j69n7ezzw56OaZLwflSliHCsqaQUyijnNvdc6I2FHeursV2P6qCMYMjWUGpeUb8rQE10 dBEd+NFPDd6Uxmho0c+hDCTkFXaDO+cYQYOi8lNLWKs7A/bJhbtW0pReIC0BUA7b4QFc dJgwFK7faDWBtejq2360C2PGL74DlEVyYHvbzo0aFBGRqA362KrMRBB/ozVT/PzZdZl3 oaeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779025941; x=1779630741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1t7vRy14fAIhG2Wr4kGou1JDcvmH5z+z8GUCNDyefuA=; b=ShwB7n/nH9UCWZ/lW7WbpzHxU0gsEdaxAmp6X6KCUBaRPutXP2E3zD/YDfwtfAV97D cZLI6HPln6qvEKSTNnwpqd+YWdi1pDwJqVq0k9bm9Mab5DoNxkQ6bAieLTFizOD+zX5P 0vT7eHY7gmY0lhTcCfBXD6P3oqAxrq8Ply5SORZMalHDdauRVbFoPgVsPRI2867TyUpX kfTaFzhGq4wWAMBfhAD0TQioTMYtTQigYIg8/lkDQX0EZm0XflUgJedflK8oDXlctotj k+dR2WmqFHvChFnPMLl70QqiP5K/yKlBPHyOoa3R8P5vFxb/GnztHsha6gde4XjzmIrH 4uZg== X-Forwarded-Encrypted: i=1; AFNElJ/7KuKNvc08E3OYheiKy3extTW9gsIPmRmoNW80z1atq4mM1b4jQG4HeRXT/Qk2EsVhOk+GC/OfI2hYeeU=@vger.kernel.org X-Gm-Message-State: AOJu0YzzyEhcjTwYHPkB5m/grdhJ6I6yv3I+usuhEaC9SPrSXYjtiQLG oqXPIuySgzegyQcrDLyRD7pQI5+glHkA+funD2ACYUU2wGylTK2CvITu X-Gm-Gg: Acq92OFk2Rys/F9TJjA2QG2vtBxThgMcO6ZmTO0tq+GDqvaA2nJI4Di6L74q+KYnef+ ngFCPQIZRZrYNtYIwEyGeE869tCNS5bbsw5K6HdbjwqyWnld5iNGTHsK41jGWja3WNzKIsO5Iqh xjWMsa8G2P0DaaAbWYUERjLGEBfEBbXUWILxJck78IW/PRX+lOQHjVUVGrmzqShcWtJjfVvo08B Jl294G9dgXkHLxhRcBZBWIe1tcEQm7JlXxWLcscm0NSShLw9i+fywTGvGOTPkzT14zmAGkD58dU ZD+jsnws1FX313vgq78Ff20ijbTxHBROH+JAG7EXKW+4mQyPC2OCrOPUXxuBaYc/lFaaVZirUSe Et/bcHsOwpV6un03db2HILvUaMIgBr8TnkcCGcG6hxewGzLtxcAEczG97/3BGzljd3N0PuatmD0 lcl6JqdcdK+Ab+cJZ34BTWF+goKl794OgNOmNVFhmrvOvkQIT5 X-Received: by 2002:a17:902:b60a:b0:2bc:b366:4731 with SMTP id d9443c01a7336-2bd7e9b8086mr84503465ad.31.1779025941162; Sun, 17 May 2026 06:52:21 -0700 (PDT) Received: from jmoon ([118.220.156.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5fc47sm113873385ad.10.2026.05.17.06.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 06:52:20 -0700 (PDT) From: Jinmo Yang To: linux-input@vger.kernel.org Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jinmo Yang Subject: [PATCH 1/4] HID: wacom: validate report length for PL and PTU handlers Date: Sun, 17 May 2026 22:52:12 +0900 Message-ID: <20260517135215.2220117-2-jinmo44.yang@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260517135215.2220117-1-jinmo44.yang@gmail.com> References: <20260517135215.2220117-1-jinmo44.yang@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit wacom_pl_irq() and wacom_ptu_irq() access fixed offsets up to data[7] in the raw HID report buffer without validating the buffer length. These sub-functions are called from wacom_wac_irq() which receives the length parameter but does not pass it to the handlers. A malicious USB device can declare a small HID report in its descriptor and send a matching short report that passes the HID core size check (csize >= rsize), but the driver assumes a full-size hardware report layout, leading to slab-out-of-bounds reads. Add minimum length checks in wacom_wac_irq() before dispatching to wacom_pl_irq() and wacom_ptu_irq(). Fixes: 4104d13fe019 ("Input: move USB tablets under drivers/input/tablet") Cc: stable@vger.kernel.org Signed-off-by: Jinmo Yang --- drivers/hid/wacom_wac.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index da1f0ea85..6d06842b6 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -3453,6 +3453,8 @@ void wacom_wac_irq(struct wacom_wac *wacom_wac, size_t len) break; case PL: + if (len < 8) + return; sync = wacom_pl_irq(wacom_wac); break; @@ -3464,6 +3466,8 @@ void wacom_wac_irq(struct wacom_wac *wacom_wac, size_t len) break; case PTU: + if (len < 8) + return; sync = wacom_ptu_irq(wacom_wac); break; -- 2.53.0