From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47A7F260580 for ; Sun, 17 May 2026 13:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779025948; cv=none; b=GLgJaju39ixl0BMLqbaSKuzSr+8EU7JWSnTTfWH9x0GrtW2vdQNn2ZOetioHBzXtR1avFfUodLiFvbERxasYYScRsKgt4QBTI46llLW1m0D9eyu2Ac3pDNCuffNDFVW/JGwaJXR4h22WHqGGZLmIbv9qCmu8xOh0OXZZmTdyeng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779025948; c=relaxed/simple; bh=DQk88FRBKoFkhbRSS0uCRp3L/0NcM92hszhkFvzYeoo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SVR/o/wfmNWI6lpW415qoH0Bhz8brv4Sefl0QN0qFOtPdgjCULwRiqYjJFfCJiGTxqP5LvtFcrAretNFtL3aBRt5B8JacyMtyaW1Pt2UOep0lX+lmpzjOK5yt4q2wWHXnp3uhZVWhJ9Kvh69ovG0ELdULLwN7rssCzxVtEyT8eY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MG9i7Dgs; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MG9i7Dgs" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2b9ea536877so6582805ad.1 for ; Sun, 17 May 2026 06:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779025945; x=1779630745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VQuWt3uDzlCPMeJpucga5L6Dcu7cKi0WPlFjpk2QwOw=; b=MG9i7DgsjP2oE94PnkUEjycigaWcHjxeCDWeQpYQ//Tdj3/8/jYFJ6dqoJOjqHyrt1 Bh26IQKK2QoXteIKFB1b5TB3g856r2EojoHA/Z0XsfDKCQrXn5L2rQ9EHFPVBHHdO1BB QeMHK0Y/6KBqSzCtO7dTRM9j5SXnhvpwoDeD600TfkjWo72DiXWNSoICgHSgM+CmdWuw mAPGHq65INjYtwPNbT2XsD7CQ9ZYIDJRPFs8QuC8fYfxj7cYi/zD1vcGTKCYxcqXUSoA umrldlLZGh0Zu54q5XAZjFkJNwT9faqrXtVazL/eZRzzSTa/X1SvkKBLsDovnqdehEss KpuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779025945; x=1779630745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VQuWt3uDzlCPMeJpucga5L6Dcu7cKi0WPlFjpk2QwOw=; b=f+IXiQBrARXAvKnf/WCHFsQNzyHpNXt9mc1vvvBBUSwe0PnHWDKdnWc4rLZyMQuebq A+Yf6nMrvYLOIA7aORk50K3Cp/59jwPglOxqLMrnCZOqm7SMTxyNj7t/+6GyRvjDVorj HCnr6msQp7fO2R3i+KXGQE7ZVm1iE8cw16TWBNTQriL2ijBHwtooOU5j12v4NirZWSgk JKfNdQf4DkfyM82R6QC4tfqacCwrFRWa8S0ktfXC1CIkQVyO5Jj72nvYhT9Law4y7nFW nD8FtoyCA3zcDfrS23LmAt8fVIkdpfuBDCyliq1htFtd4vO1R1SlHiHHYHK0O9L3AscD mQWA== X-Forwarded-Encrypted: i=1; AFNElJ/gtcXWGkQvmkDyrLhUIJYdeCnTeMA0SySeS3LJIQXHqHQncZoHcvAa3RVFkbPGwi5lRERg0Kf7h+efHr0=@vger.kernel.org X-Gm-Message-State: AOJu0YysYF7962AIXWJ79929qt7SqVUmhU/m7Dg2v7g1YxYIwRYdUlNl 4AAr376bvZuuixqYeSUU+qirvhEfc/ONR2Ay/inlliyT4yZfQovXHZFq X-Gm-Gg: Acq92OFx08jGueo/SyMrDlc8TqBKZfl7jsqGg5YWvo19g4zMPywgcEq2gffVpXcJZPq 2dD8HCX7vZyb7pukspaSt731p+e47i9AibgssvrflpWT0BfVV+h/oXn1SgEVL5NexrEJKdiqEW3 Y31g4AALGYFJVZ68ITb98NJI+Zzmv6QzjFtZlKdXbBl0s0E4gJbdrRuKU3g3ocYFe7nXCFic72G 511yBEQMmQ8GZigV8apq1wDUZhZYichP9tGzcsfiI9I4W7Imt5tZBQ+FetGUFZq74Vez/jwnpYL 6ZrM3cKuUPRlom288d5N3T9BzhVYWHRGs1hmE+YNHH5S4caP7DuoYqj/2PyX8+95iA1/YegRDaf suQW+BEawSicvWWFl67YzwnRX3pxIgyfs6qHNd5ZPiE+H33LF1b97SvCpe2ypGWD+KBGg0iRa7R lP/8Zs0rxtpJ9AtkqX9O4MEZuqWEOa1tvyuRj516X62agpa9zG X-Received: by 2002:a17:903:2281:b0:2ba:7617:a755 with SMTP id d9443c01a7336-2bd5283b74cmr140145355ad.25.1779025944534; Sun, 17 May 2026 06:52:24 -0700 (PDT) Received: from jmoon ([118.220.156.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5fc47sm113873385ad.10.2026.05.17.06.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 06:52:24 -0700 (PDT) From: Jinmo Yang To: linux-input@vger.kernel.org Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jinmo Yang Subject: [PATCH 3/4] HID: wacom: validate report length for DTUS handler Date: Sun, 17 May 2026 22:52:14 +0900 Message-ID: <20260517135215.2220117-4-jinmo44.yang@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260517135215.2220117-1-jinmo44.yang@gmail.com> References: <20260517135215.2220117-1-jinmo44.yang@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit wacom_dtus_irq() accesses fixed offsets up to data[6] in the raw HID report buffer without validating the buffer length. This sub-function is called from wacom_wac_irq() which receives the length parameter but does not pass it to the handler. A malicious USB device can declare a small HID report in its descriptor and send a matching short report that passes the HID core size check (csize >= rsize), but the driver assumes a full-size hardware report layout, leading to slab-out-of-bounds reads. Add a minimum length check in wacom_wac_irq() before dispatching to wacom_dtus_irq(). Fixes: 497ab1f290a2 ("Input: wacom - add support for DTU-1031") Cc: stable@vger.kernel.org Signed-off-by: Jinmo Yang --- drivers/hid/wacom_wac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 873d58a6d..269e8318f 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -3479,6 +3479,8 @@ void wacom_wac_irq(struct wacom_wac *wacom_wac, size_t len) case DTUS: case DTUSX: + if (len < 7) + return; sync = wacom_dtus_irq(wacom_wac); break; -- 2.53.0