From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF7EA2512DE for ; Sun, 17 May 2026 13:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779025950; cv=none; b=j5Q4Juwuz7T92Rsi+PvSnIMA7jZE6mPffLWiGsVWSJKatWSa64d5LuaWSDDiLvU69q8pqNVKvynjrivfStgCVJSwtu69LSahmf2IQ4FjbxY5iRGGa6Fsz51Qd7t0tF/B6ykU6s9Qm+fB299pcfTeWglMwNDsfIkd9gGCsM5PtrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779025950; c=relaxed/simple; bh=7RVrmuiuxF/rWreRjusc9N9OoV45FUmambe+/N5PACw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BNTs/bNZVC8IKlDXkGEdzLaPFQOY4asvRZUP1Id1Gg97TQqBcqW4Dl/xgDyLpBOatBZqyUjKQE04dyIeIaqE+MYtiT56f1nkCYE922B1RcTTkAkSjOqE2c/WlhCkItusfH8YBpF3+7pIvu1RvHRJdSLaKqre+1EkxxbYtSc04MQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KVxsAaNX; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KVxsAaNX" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2bccb978bd9so14473565ad.0 for ; Sun, 17 May 2026 06:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779025946; x=1779630746; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QO75HleHGDZqT7J517EBpplpM7jMyRvzAuKel4/gPzs=; b=KVxsAaNXKVd8NIY5+lfvKHLi7uvQYiPmIE3KUaqiWZ21yIgRKIf7lAigo+j030sQDJ ufFWkoEYvHiCKan7aRCxV2xm66wrYvrdLtSAQQp8z9C1rjYg4PkTrr6S8/8gZt65/E4A 56v0hZ143Qsh8gGbrXz0qHiB68MKbBVHKCuvtk/zO/VazOe5rRfG8hIyehvaE/0noFGB 4w6Rz4HskipOY4q+N/VzKBJ0n31yIWQtS+hohmRCe0F182Vn+ey4AQfpYxeUnB5d9bww m49X1LHP0mprsPSLDRLmGwZyl4ReINQVVNRdEOkk5qndzzZ/q1WjchUTQxWQddG4Daoa Fu6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779025946; x=1779630746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QO75HleHGDZqT7J517EBpplpM7jMyRvzAuKel4/gPzs=; b=PPmUfkWf6kjcOGO2Nc6xRtglheviaHQz7h4bpcnMVqp6krQY8KDSLIt2bOwHaxcB5B xEjvhk/iNOgcXBRwrm8mLwk+U6zqN3e42QKvW+sTc4SSj6W+bicii+p6hcLXBLJNUYyj UmTZgZE9iBg432B7D116/Wt5LvuSJA5x4Osve1WjYaUG5vMqHcvHkevza+8LR/p3J67m 4UFHYlsQp+Q3pWI//LmBZjICSQA9hh25kOl7KBYjXK3kC88mazeH6LF2VBmLS3cobTP5 jWB1Wa7lLnz2Y+K6/fza4m7MUHaaJLTdWtqgFdz9vm/fRcmgWG8vKIIQolXn/qIgjW9s cp+g== X-Forwarded-Encrypted: i=1; AFNElJ+UhKb6ZAYxwAWyA8cL9+sAsY3Ycpc8H0ZW12vCd/mYfT0uLDWS1T3dUiJR+XE0yoejGEMBgsdx+rHst4g=@vger.kernel.org X-Gm-Message-State: AOJu0YwK1V8XCYCwpjEeAav5LuNFbTCLozxnXK+u+plrk/LF+ofx7ue9 aFjtvxc3E9XDdgN706NOYjHEkLPz6W1EmxDE9S0Ff+u/6fSUSMcjaokk X-Gm-Gg: Acq92OE7RKVX2/WKF92Kv8EuUzsQa1/D6JnRsnzC7Gl7VcQ74lbir1H2YlrJ90flL/V XA42TfkcwmY9SgorEVMmJbLaoi1Pfs0ebwJX3T1cHRd576qy9lHCpgatLt66Nn7MyotOH0n3DRy iKAAKvg2cXgJj5gq/ITvzUDBzk5VP2+lXlOosET40NapSO4pcwPHQ3cJGp9qDyrqf2LFJl3k1XP nDCTj6YjpByIsHaK89GHD3VPuYzfcd7YTjyM50ScwH7Nw0fTHw+K+ah9U6Ouv5KXspkgGbhm3UM BDnVi2czrLG+T4r8P2IvhA0v9Um1h0p0BPatX+SEaThwu0GKuZHlPUUNco3OeYsEiUQEu0vyd6+ jBtlULBt0SkMEWWbSw7KtOOfUnPVQcJe4LVcEWuCPmsTPEdSbqe3ZC1pTZDPTq2qNSb+FagjjOj NZl13iSeosfMTPmI04/I6r+9t9r8/I6/g7hu07bL5kTcnCGonr X-Received: by 2002:a17:903:1210:b0:2bd:c60d:2968 with SMTP id d9443c01a7336-2bdc60d2bdcmr28937195ad.12.1779025946291; Sun, 17 May 2026 06:52:26 -0700 (PDT) Received: from jmoon ([118.220.156.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5fc47sm113873385ad.10.2026.05.17.06.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 06:52:26 -0700 (PDT) From: Jinmo Yang To: linux-input@vger.kernel.org Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jinmo Yang Subject: [PATCH 4/4] HID: wacom: validate report length for 24HDT and 27QHDT handlers Date: Sun, 17 May 2026 22:52:15 +0900 Message-ID: <20260517135215.2220117-5-jinmo44.yang@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260517135215.2220117-1-jinmo44.yang@gmail.com> References: <20260517135215.2220117-1-jinmo44.yang@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit wacom_24hdt_irq() accesses data[61] for WACOM_24HDT and data[63] for WACOM_27QHDT in the raw HID report buffer without validating the buffer length. This sub-function is called from wacom_wac_irq() which receives the length parameter but does not pass it to the handler. A malicious USB device can declare a small HID report in its descriptor and send a matching short report that passes the HID core size check (csize >= rsize), but the driver assumes a full-size hardware report layout, leading to slab-out-of-bounds reads. Add minimum length checks in wacom_wac_irq() before dispatching to wacom_24hdt_irq() for both device types. Fixes: b1e4279e4ef5 ("Input: wacom - add touch sensor support for Cintiq 24HD touch") Cc: stable@vger.kernel.org Signed-off-by: Jinmo Yang --- drivers/hid/wacom_wac.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c index 269e8318f..2fd1c4e80 100644 --- a/drivers/hid/wacom_wac.c +++ b/drivers/hid/wacom_wac.c @@ -3509,7 +3509,14 @@ void wacom_wac_irq(struct wacom_wac *wacom_wac, size_t len) break; case WACOM_24HDT: + if (len < 62) + return; + sync = wacom_24hdt_irq(wacom_wac); + break; + case WACOM_27QHDT: + if (len < 64) + return; sync = wacom_24hdt_irq(wacom_wac); break; -- 2.53.0