From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C8B126C3BD for ; Sun, 17 May 2026 13:54:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779026067; cv=none; b=WD36htnlmZZk4r7R3dKd6TMaJCKgNZtzOlro1alk9SD+eOLbA4gMWELnxOhjftY9f3yTqVJuijs8IKJG3G6mPel7YKXH9TDIRrkwT3hWbbctdPaMPYyKyQlXDvTBF+DaFqybecLgccP/17anhFUarT/d49dwRBaHcAVxoengO1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779026067; c=relaxed/simple; bh=YbQLRrWkp8woT6noIkN8JFge1QfEm+EnvuLpmYJvGB0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=slerH0Sa8TzxQ6+3ogfBiK9uGDl5VuE3+cVTxMMVph2TNNRP2n6+gcLTwwj68HiRd6VJMeBhAMI/CFBlolP3u4uyiVvVxB2nS+BC7uqbWOk0s5cQ7pcSC58XSQ69SjbNDMytsfZmooxRcBgvDKNKThv7mEorhL8hEZp8+mNJsGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZllJxf05; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZllJxf05" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48a3e9862f0so7085475e9.1 for ; Sun, 17 May 2026 06:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779026064; x=1779630864; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=uCmNoyXACxi7HeEYBB30N/6mk1BYNcK6sHffQdI0OFI=; b=ZllJxf05exQ35V9kJNbCa6kXgPnbPXGRFeP7tQASncY3fo4wmU5hXUO2Z2zNGNga4h wAhGkbWMHCMIwdurQwnWYfBMsCoWfPFCHbQUrx6/jEuTeyRy5+Au1qv5Sokl3miBUkIT jx0kHjWtKGEHBREHjPYcLjT7j1Xs/SOYh3edWxpYkBUAwOqCmPNR+FhYsrjo5AxfEzHy zry/tU8fa5kBF4s2ZboFpxldjEN8aGkO+Sq2YovSfIqg+WXiHFP7JV0FS6A0BAAmRsTM fDMA5idiBMU2mn4EZbybYwwy8HtLzkzBjVcEaG2stSSWobhs9DRvMYJlqEy4W4rfVS6B rKTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779026064; x=1779630864; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uCmNoyXACxi7HeEYBB30N/6mk1BYNcK6sHffQdI0OFI=; b=GDxMVzzdaYvqJ7hfG20GEk4fxgc21lT7zov1P/Et0LogbWY44+NkXrWWp8tuEz43xH jMKSy7+KfOotzSoeq9nXuHS+N7WdGS98Bd4KAhvXtDCXD4dQRxRdWdzJ97jIaK0BgM0U aBTolUKhcT20jpbXP+e5TASdxrFva11s/+UeWKtcFhiDPr4xXZGvcFiuoAcTNeoNK0ZC Tzg4/zJt17tCMumAKI/laSEsvO80DGCrAPPGxwPv3gjbYALuovvqT2/oXBGL/qa81HMQ ncbobvQWqcrbgL4N/GkopJUtWiPWqkI83eewy+rwoKT2XhnJ0ZhUgM4KvSiJCLV9XdAk f9dg== X-Gm-Message-State: AOJu0YxqhGRijbpKnxXF8JY5ZFDZgVM+RagBQWrdq/WH6H6kQigNbbQg JBx7QtnwT5MhnIdaRI4rppisAZdGacl3su6UrzLhl+vuwLwFHBV9AkYO X-Gm-Gg: Acq92OFajEJ04snNyMRHis5PHmMqakPzks7wdkZrdmHqmoUZA8/fncmC07XijYxFCxI EW9IDl70a12cWNi4/2XdoASClB6x8w25YQ8c3Gq0wqYwtskqDIafj48MQ9O36WqM7FsAi6916EZ EenfT2Izwi5pwuxrrySKKJ1orwTrEasBhhuhoo3S43DqI/mRInWqDEjlc7n7AfpwAS4hQT/Be3i S37YMYY48C692jlQRKdxcqKJTIR4cXzE5jqF5a+gdh2dUb0cTl+vmF2r+4usYcJ3IPyCHz6GDaY 3A1+PIHOyqPS5tNlyPD3L/ETi/qm7XQvHJTpYnWz5R3ScK3Lwa3C6WS83wMiCtpguh+KydRpdLn hegNEFwgDVkI3BcCvisuIlzU+2C6SlE1XuN7W7Kre5yNPf/Mjxs2LkNMbbQztrUCIpuWYylQ8Mw aFw7PUC5kBSrFUCSILMrnR7RTc0vvh3d7kFq/ztKrEfICHKimaxRGGtlKShaf1dPDc19rMWtYJy fBkHh9PwRYmDA== X-Received: by 2002:a05:600c:5010:b0:486:faa8:9e4 with SMTP id 5b1f17b1804b1-48fe5388407mr154115835e9.12.1779026064317; Sun, 17 May 2026 06:54:24 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4dac000sm196019465e9.0.2026.05.17.06.54.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 06:54:24 -0700 (PDT) Date: Sun, 17 May 2026 14:54:21 +0100 From: David Laight To: Mingcong Bai Cc: linux-kernel@vger.kernel.org, Xi Ruoyao , Kexy Biscuit , stable@vger.kernel.org, kernel test robot , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: define __LITTLE_ENDIAN and __BIG_ENDIAN for math-emu Message-ID: <20260517145421.2d1ac77c@pumpkin> In-Reply-To: <20260517041423.71243-1-jeffbai@aosc.io> References: <20260517041423.71243-1-jeffbai@aosc.io> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 17 May 2026 12:14:21 +0800 Mingcong Bai wrote: > Similar to commit b929926f01f2 ("sh: define __BIG_ENDIAN for math-emu"), > define __LITTLE_ENDIAN and __BIG_ENDIAN as 0 to mitigate build-time > warnings: >=20 > ./include/math-emu/double.h:59:21: error: =E2=80=98__BIG_ENDIAN=E2=80= =99 is not defined, evaluates to =E2=80=980=E2=80=99 [-Werror=3Dundef] > 59 | #if __BYTE_ORDER =3D=3D __BIG_ENDIAN > | >=20 > Cc: stable@vger.kernel.org > Fixes: 13da9e200fe4 ("Revert "endian: #define __BYTE_ORDER"") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202507301656.7FEX6J5W-lkp@i= ntel.com/ > Signed-off-by: Mingcong Bai > --- > arch/powerpc/include/asm/sfp-machine.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/arch/powerpc/include/asm/sfp-machine.h b/arch/powerpc/includ= e/asm/sfp-machine.h > index 8b957aabb826d..db8525605c026 100644 > --- a/arch/powerpc/include/asm/sfp-machine.h > +++ b/arch/powerpc/include/asm/sfp-machine.h > @@ -319,10 +319,12 @@ > #define abort() \ > return 0 > =20 > -#ifdef __BIG_ENDIAN > +#ifdef __BIG_ENDIAN__ > #define __BYTE_ORDER __BIG_ENDIAN > +#define __LITTLE_ENDIAN 0 > #else > #define __BYTE_ORDER __LITTLE_ENDIAN > +#define __BIG_ENDIAN 0 > #endif I thought the expected/correct value for __BYTE_ORDER__ was either 1234 or = 4321. (apart from pdp11's 2143). -- David > =20 > /* Exception flags. */