From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB74F3C4B77 for ; Sun, 17 May 2026 17:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779038320; cv=none; b=MDvbwvwDh1ir+aG8tDojF8fywMEYDY6fWK/Ot3EXOxvMBwqnsaWWWHqjSywM4U+HP7CO0OzCm/QGlAjphx2ppQh5oL68HB+oslMxz3UrvGLdyPaeLpXpx5BisTQ6VzF6PuG5MO9C7o7RoHtFQvcYz6XPYwhFIBedlH3ZG5Xdyvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779038320; c=relaxed/simple; bh=sC7gGKV7ozm/WzcKRL8dyf5wyvuKoJ9tCvD0h0m34KA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PUeMADx+SzcFRRj9gUg0oCPIMLBW/SY6oJVozdkJnZ81ymGHJzLGfHaEG7C9k0xjf1cv9JrjsOBeXQy/oK+2PjXvqJTWjlPjT//+y15c0dHZTNHb+lsVbMhv32lqKa7sY2k2z8h6wfUWJVlcE7ucOqChaoGcG/8cOt1X4EW6cEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eZT8YHCl; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eZT8YHCl" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48fde653997so1831805e9.2 for ; Sun, 17 May 2026 10:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779038317; x=1779643117; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sC7gGKV7ozm/WzcKRL8dyf5wyvuKoJ9tCvD0h0m34KA=; b=eZT8YHCl9SLDA7CfoQ6j3M+c1Iaflh/BAv+/Wc/EriQzKp0bUCe5CfdCgitKl7GXxa t1+UrR/KdIX0YNfijHS+RMhpVMolS1AUmCFUn4EnkBvDqUVvTP0k+lAI9u4z6OKRZ2bM gL/A//PLT2/M/x6iFszzmehWSpGrmmk/2fT8nWIVR2ncwwabFF2sUfHhyYUIqnLwHLTR REaKLSfVn4GM5/z6F+m0VJRV8Ds6+E4hGQOoKtwxL4yCWWLMfWw7SzgGK6cIb/0EI0Ao dkp6TLBmMm3OOgW2Tyk+obOGXdlOhSsmBM7tPKrlEO4uDLnoPETFieqOHPTauMbtefWF VlpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779038317; x=1779643117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sC7gGKV7ozm/WzcKRL8dyf5wyvuKoJ9tCvD0h0m34KA=; b=TlII7V1szLrX4wh4DCE1vM6S1p6s6LEpD8HGQ8pWydaBCeTynIHPqMjCHS5CWcXafC SQfX6BcqGGnLzWPnOoXSbqjYWIOJGBa3ng3ccE5HvkXSCxWMkONQbe+8x56khwYz6JWX QGy16fo+lINAXKfuaJeblvdZA+HpNv9iOBbWxONeZTaucJFBkwnjIMzVd99b1yg1sT1Q ZgfEdWoATqxPH/xFCskHrDz8jJqLs0UOpaIITAzUCroPHw7nR37G6kutgbp6zf83bD10 QDfsyRRMFC9vDYNJyKzWMdzCcLVAWgiSj/mXlgLXz18RIPtrIgqvkFT5TaZtJOavTHSc B7aA== X-Forwarded-Encrypted: i=1; AFNElJ9zbghMVeq1m4bXIEOqbwf+YtnTC3ZP5pzJkkbP2SJ8Ri9gS/mBaIK5hLwG0rdsoMehqIDm6udnVtHSB8g=@vger.kernel.org X-Gm-Message-State: AOJu0YxQWwxIbisgotvEIbNNE5nReny/u96VMITWWZyR4DN9YGEBpB6m FaLxaVwb7Pb3COh5CKW9zY3sWN5ZRk5H3bSu5uuhwjhsGed9aBWMveQW X-Gm-Gg: Acq92OFv793a9CJrBqOnvtm5RKOEEsSjxV4CoP5/GZl7quw+X/J7lzjALNb47hhuYsl La7gz5pF2K3BW3Ctf0HJwFMeYvuXFh5m6RUfJYvuySIgx/yzdr6r4/DnMYp4yi2b20SpEXRnUIm 3YQxJEEJMCLhi89s+yWaTBF7lLi4w5BmtzjyM7GU5nkGbzNa4WrkK9OEaktrwThAzIHOxhWzvpd LJbLxepKZCI4EALwGvzeULrm0P5sJGjWqVp5+Pb5QimNcEGGmkXl/eCB+BVyEC0Evz8nO1OlH8b vhBi5osdkxHzGzR9IAJYIMq0lPsagedAQR72Gq6tTRyTHOeFJFImDjDUWs2W4KBCQZkPDsGoi3F 2f2wx1r8q2TmvMs6FUf/r03QVHtymC7nf3DazGhkNgnrpSpjQ/si5jqL9d4Mh60JtZMj73BvzsP r/J0A//rPDqyegSx9h9kUhGiA6V5JAWIphCUwJFv1ojYHH X-Received: by 2002:a05:600c:3b07:b0:48e:6db5:76e6 with SMTP id 5b1f17b1804b1-48fe63099c6mr95495075e9.2.1779038317040; Sun, 17 May 2026 10:18:37 -0700 (PDT) Received: from localhost.localdomain ([82.215.118.79]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ec3acf7sm30645659f8f.12.2026.05.17.10.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 10:18:36 -0700 (PDT) From: Stepan Ionichev To: dlechner@baylibre.com Cc: mazziesaccount@gmail.com, jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Stepan Ionichev Subject: Re: [PATCH] iio: pressure: rohm-bm1390: notify trigger on all error paths Date: Sun, 17 May 2026 22:18:24 +0500 Message-Id: <20260517171824.1845-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <54ee1fba-3209-4192-82c3-674a1ae3ca8f@baylibre.com> References: <54ee1fba-3209-4192-82c3-674a1ae3ca8f@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, May 17, 2026, David Lechner wrote: > IRQ_NONE means that the interrupt wasn't handled, so it won't be cleared > and the handler will likely just run again immediately. So it probably > isn't the right thing to be returning in the first place. Right -- though here it is called via handle_nested_irq() from the threaded pollfunc, so the return value does not feed the IRQ controller and the immediate re-fire concern is moot in practice. But the IRQ_NONE choice is still odd. Matti, do you want a v2 that always returns IRQ_HANDLED on the error paths instead, or keep the current shape and just fix the missing notify_done()? Stepan