From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EF273CBE7F for ; Sun, 17 May 2026 18:06:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779041228; cv=none; b=cSpkw13rVrzvgANlFv6eLXZCBJCvcSMVfo+yAlPqYW3ULiICk2NROHAW7FNqxjyBBkkqrZfdHuSI/FsrFB//11g6hsSAaTVXXm4jKfUxBH8w9agAyZzzdfa/dyZRGs/fdo8JgiOu4gKmDr9MfEr3Bk80o2a8OxYi94kMwFKq7HA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779041228; c=relaxed/simple; bh=3LM6h2aHFdhtzdJtTIft4eZwUciZz65DnEuEQv8YulQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aLr+UhZLoS9rfOUxWTCxZwu0mrMjf7kNfr4rKwQzolqQyfT7O3EBu4eVc032GCI/Oy2OVs5yPw3U3liGlla5wybeMqFwj7F5LDpZeLclsjX2RkmJ0ymeG7LdWVoZeVXJ9zv2ipZUsnsQdTXsEXeXTMjVd5of3Ye5SPtCAheNbG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iE33QWGz; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iE33QWGz" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48fe7a40e51so1518215e9.0 for ; Sun, 17 May 2026 11:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779041215; x=1779646015; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=msTE632b5gRHZXchhXxhyfIjZMxg97RrD6+uOCX904A=; b=iE33QWGzcC7EIY8h++wi1AE7Sk3KKpj8uzUPUuola/BVmET7msXZy1cZ5fXgn5F3Rj c9Ik9+62Ul7z4vDqPBxWoGYNWozKuUwyKbpgyICh6DVVOweRCgL+MVlTbTNL19qRkHtq zzHAumWZGkc68OtlmnRWcluWWwbQTBijbyLAA+Bgu57+XCttUpdF2wBHKdE012M2iVPv bFNwtEun9yKpOmdbTiMEj7ETCP3wOL2CNUDjPZRSVNKMpKIjnBW5R3i8O+e6lIBs9Wqm Si8P7pYfATk7swU7u1qhp+kedk/zCwpTcROc9PQ0/Jzd2ZdG9gRE3I0dnM0SSp4bNf7m 3MQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779041215; x=1779646015; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=msTE632b5gRHZXchhXxhyfIjZMxg97RrD6+uOCX904A=; b=fPUto4UVLJmOw7uktaLNfb7hgo6e8Lz928wkrcrvsj1S9Ulo46+OVtm/O25mVJShm2 UX1W/CBDeEzRC8BRF/R7vAjD5Iqi8yUdWjtKdUZTKjGmMSDluqSPbq92PKIlpru0GYBE BpgjQhv8577DIsdFqOUbCJLd+NT5GgEo5rFaqL6947Xt+heP4zIy+G6OZUwPjB6QEXrW BkcU2H//PJT09ewF+bRabtjJzWR0XfPcm3jeC4+ymSHto9JINqPknMuXqNlu6JSbTYoz 8VRAYrgHj+RhXMzbpqPkekRNiBFGnIEKRUm6Zprf35uNEQqYPERSxNHP8X7IjxZUq6j9 3EkA== X-Forwarded-Encrypted: i=1; AFNElJ8hrcYF55LWHKJZbopLXs2OhVQ6VMOlwj4/zkx4x00obzkxakxskEyGSVk53wmHZNY56xC/n+J7UTMJdzE=@vger.kernel.org X-Gm-Message-State: AOJu0YxWR7no8bYkbqMmXLvlvv5W0gMiaQV4MzI3CJOEwWRNubbIltS1 IoUm9UU20v7bkUBV0LFNXhSSw28sGuUNBOdA0ZgwI15UCYGMmiHMIOO6 X-Gm-Gg: Acq92OHo2VhOw24jtnhsoIyaidazUSic+I3nwd7C93FO54Z4GwcoN7/djFoqmiDGf30 B6GYSG8foH2+HB7/bWoN4eL2xr7+wlOjsYZ569PICaYIqjY3+mO7REJ2QYcjHLQ6ctr5uoqCnh2 IkXn+Ien/b6UvTRbkNDM+MtzEW+xSUi5u0DBCj1QLpD6Q979iWrR7afumH01oz3h3dhl62JJdNN 0h183iLlPeGbXl+5rEM3qmacl7sETDtNhpDK9NmoZFjR7lHGVPT1IKPrqIS0xd/B7KeG4czCiWc kXGO+lZMq6PvCnsUfMWijQwLBsYglFfCJTspWvErM6Y6w3/prHdZfFUSXJbBhXwosbCbGaMWElv u4dEj3G7a4rXtxhgYKBGjzmWO3LrQTScEl30pcj5Mqkfv3VEZBPks7ZBx6nglusTR7D4DFo6rsZ aCz/kz27XRNUzTgDsq6X5utAJf464ZGodrVtNjCrWE0qnWWTtgA/07W0Ra2BEtTQ4= X-Received: by 2002:a05:6000:4683:b0:45c:e615:56cc with SMTP id ffacd0b85a97d-45e5c5edef7mr5526552f8f.7.1779041214493; Sun, 17 May 2026 11:06:54 -0700 (PDT) Received: from menon.v.cablecom.net (84-74-0-139.dclient.hispeed.ch. [84.74.0.139]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a6454sm31766775f8f.34.2026.05.17.11.06.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 11:06:54 -0700 (PDT) From: Lothar Rubusch To: thorsten.blum@linux.dev, herbert@gondor.apana.org.au, davem@davemloft.net, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, l.rubusch@gmail.com Subject: [PATCH 07/12] crypto: atmel-sha204a - switch to module_i2c_driver Date: Sun, 17 May 2026 18:06:34 +0000 Message-Id: <20260517180639.9657-9-l.rubusch@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260517180639.9657-1-l.rubusch@gmail.com> References: <20260517180639.9657-1-l.rubusch@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace custom module init/exit functions with module_i2c_driver() for driver registration. Update remove path to unregister the client from the shared I2C management list before flushing pending work and cleaning up sysfs and hwrng resources. No functional change intended. Signed-off-by: Lothar Rubusch --- drivers/crypto/atmel-sha204a.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c index cdfdcf2e43a7..613ed5e7b3f6 100644 --- a/drivers/crypto/atmel-sha204a.c +++ b/drivers/crypto/atmel-sha204a.c @@ -216,6 +216,8 @@ static void atmel_sha204a_remove(struct i2c_client *client) struct atmel_i2c_client_priv *i2c_priv = i2c_get_clientdata(client); devm_hwrng_unregister(&client->dev, &i2c_priv->hwrng); + + atmel_i2c_unregister_client(i2c_priv); atmel_i2c_flush_queue(); sysfs_remove_group(&client->dev.kobj, &atmel_sha204a_groups); @@ -246,19 +248,7 @@ static struct i2c_driver atmel_sha204a_driver = { .driver.of_match_table = atmel_sha204a_dt_ids, }; -static int __init atmel_sha204a_init(void) -{ - return i2c_add_driver(&atmel_sha204a_driver); -} - -static void __exit atmel_sha204a_exit(void) -{ - atmel_i2c_flush_queue(); - i2c_del_driver(&atmel_sha204a_driver); -} - -module_init(atmel_sha204a_init); -module_exit(atmel_sha204a_exit); +module_i2c_driver(atmel_sha204a_driver); MODULE_AUTHOR("Ard Biesheuvel "); MODULE_DESCRIPTION("Microchip / Atmel SHA204A (I2C) driver"); -- 2.53.0