From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E2753CAE95 for ; Sun, 17 May 2026 18:08:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779041336; cv=none; b=Nrel8exCsRPX8XPNMBOhsVdn89dj60a0Nk0hpGzfk+Gjs0R/LO57xAB8rxCYzVQKy/e4rCZwvSI65/dHkX2ddYISczlGRpiUzwtdJ15RJaaIJRCBr2/8FTwOVP9pGNdXlhD8KnUfR7ISuwzm6kHy1StKC6oyA08lNLtS4Gd/23I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779041336; c=relaxed/simple; bh=rOgPvVJ9luMy3zvxNUEgiV+7mlyNFSeV5ChMY+xLhFg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rFRSDO8SoCRx/JvQp98Xkj5MkVg+WDOm5L8xXsX0XqHrLPRtMZliV5BtARgt9vLkjpghid+z/W7eGzAFoyf79xbGJ5uVY7LupxA8YTFEWRNWiG9npXc2FTMiMP6PYq5CtSInT1c70rc5Ih+m0fryADyz1H0EAA4N7C2Te+GIlcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZsZ3jaqK; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZsZ3jaqK" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48e56c1bf5dso6123595e9.3 for ; Sun, 17 May 2026 11:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779041334; x=1779646134; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rOgPvVJ9luMy3zvxNUEgiV+7mlyNFSeV5ChMY+xLhFg=; b=ZsZ3jaqKiaMrA38mhvlb8vku3Jq0uuBD+gtuBnO/f+J+d91trvIlRHRXVYDN7NQWKR PUTDQ/IrWbIK76x68eNQ/dozGSFVCwkHhoJnvwjAA59XVEXIQh1u6lxCF5BJtR445wfp c1z6z38STj/er0/mx7/S4bioyJn8gFWGRn8ED+6yC9ZWF2ANigMbTeOHBdCSMjeYwJ7S xcMxVBXDYDPQJBsKHzea18sQcJFqacJXn2od1od9Gb1bEymFt6jTLoRiW09jTkBMgKYI PVd9vDc3R9/XLDpEmTjLcEBUwiAIxEtS3GiufDwdnhZAnCwpr9l6K6ml8MJbCXCt/ISX g72w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779041334; x=1779646134; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rOgPvVJ9luMy3zvxNUEgiV+7mlyNFSeV5ChMY+xLhFg=; b=H0Q14dOp793LNpZopA+Gch6t0mKnTELjyYBSfw7OMIRf1UTNTVECOU8Ckx6ypFIzbZ ZYxfMgHjki4jztL2UQ7bIVNHacEtj/RpMEufm82vlIXLoJjnWPw4TIWV9TUeFud3bmQP 8cG5GvW3FnuK4ENFQRe1RBhrGORXXot9VbWvUktD4h8ELW0Mdn7zHKzg6wlRxIxOn56q vGe2lzfTiSd3CdBgZYr+52NB+bJKabDgiAdOxmy+gyK/6PEOyTeVufZ1Y183a7NzpI6C SppuSF6gDU0JT/60A8w/3WgPVD4UXlnPIx5YQukUdI0Y/nsYVHRg0stzo6P8+/RNN/IC TN9A== X-Forwarded-Encrypted: i=1; AFNElJ+zNWmCmhB4klrLtLO86eyzSFR25VRJcxQezTKSKetDVVVtqRUSN548Qa9u32vyeOD+818p+ingEawoSFs=@vger.kernel.org X-Gm-Message-State: AOJu0YyLTAXV7znBhF0hzlNudZ1Jn1RjlzD2IbRzh5zZxiQ9684UFuJ5 /yjZwjA8VWyyQCCZWxocPgZAw3YMGte9DNohsM2L4VbsFl3U2BdfaKV7YgQiaIk00MBpylwc X-Gm-Gg: Acq92OGio2k4ZU8lAw0JiPDcjccA83QlwbK5NhyOSoJHkhjecRiig7o7BmvJVPvRR7L fdxjhlPpl5x5BNmO9qmKg8qpsrcoXRDL4WD+kLUUTliRPmjeMiR/I4k2UUY+nYFVlmAoMnSEiyZ 0yPaM6mTRUieyIMTFtCV7M6NzK/VLAQaiuRGUPwf4zypL+XoxAQCWP1F/Urd/LT0gl5Qjg+/kd5 ESYQXbKLbSWy1SX979nMigNcxnov8TvOSJ+He++MU9mVmuW4Nva6ivEV0rYpvpVXF6jFMiwoDxM QPj+R1dc5HIEjNG7SACEEmuZKZ3pntdLPMcrQaTGNBG9tY07u397GZnwcEViw6hXLSO3SgYVc4P 2Hc21+yu4zP+heBqoHxv0qjhW8Gva38eJmnmuhxGFRkFIKLLVeCdc7J9A94kTon8oCrOrt5uKIy 1pLU6VaXB0r6fZbap26VKO6vaC/gdagVXk8zGJIYxdt9paCN1T3TA4z2GAGmqJ07jbg5Tjpro0+ Q== X-Received: by 2002:a05:600c:3b12:b0:488:a824:fdff with SMTP id 5b1f17b1804b1-48fe61ed2cfmr169618865e9.22.1779041333535; Sun, 17 May 2026 11:08:53 -0700 (PDT) Received: from node ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe585absm65005075e9.19.2026.05.17.11.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 11:08:52 -0700 (PDT) From: Muhammad Bilal To: pmenzel@molgen.mpg.de Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, marcel@holtmann.org, luiz.dentz@gmail.com, johan.hedberg@gmail.com, stable@vger.kernel.org Subject: Re: [PATCH] Bluetooth: SMP: add missing skb len check in smp_cmd_keypress_notify Date: Sun, 17 May 2026 14:08:32 -0400 Message-ID: <20260517180832.52329-1-meatuni001@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <3a7eaf6e-6e4e-42b1-a136-3ed2befa90e2@molgen.mpg.de> References: <20260517145417.31910-1-meatuni001@gmail.com> <3a7eaf6e-6e4e-42b1-a136-3ed2befa90e2@molgen.mpg.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Paul, Thanks for the review. Moving the check after bt_dev_dbg() would not be safe since the debug statement reads kp->value, which is exactly what the length check is guarding. On a truncated SMP_CMD_KEYPRESS_NOTIFY packet, skb->len may be smaller than sizeof(*kp) when entering the handler, so evaluating kp->value in the debug log would already access out-of-bounds memory before the guard is reached. Therefore the length check needs to remain before any access to kp->value. Regards, Muhammad Bilal