Re: [PATCH] media: ipu7: fix boot config memory leak and replace polling loops

[kernel test robot <lkp@intel.com>]

Hi shayderrr,

kernel test robot noticed the following build warnings:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on staging/staging-next staging/staging-linus sailus-media-tree/master linuxtv-media-pending/master linus/master v7.1-rc4 next-20260508]
[cannot apply to sailus-media-tree/streams]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/shayderrr/media-ipu7-fix-boot-config-memory-leak-and-replace-polling-loops/20260517-223602
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20260517143456.81109-1-darknessshayder%40gmail.com
patch subject: [PATCH] media: ipu7: fix boot config memory leak and replace polling loops
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20260518/202605180756.c4CIIUw4-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260518/202605180756.c4CIIUw4-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605180756.c4CIIUw4-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/staging/media/ipu7/ipu7-boot.c: In function 'ipu7_boot_stop_fw':
>> drivers/staging/media/ipu7/ipu7-boot.c:374:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     374 |         int ret;
         |             ^~~


vim +/ret +374 drivers/staging/media/ipu7/ipu7-boot.c

   369	
   370	int ipu7_boot_stop_fw(const struct ipu7_bus_device *adev)
   371	{
   372		const struct device *dev = &adev->auxdev.dev;
   373		u32 boot_state;
 > 374		int ret;
   375	
   376		boot_state = read_fw_boot_param(adev, IA_GOFO_FW_BOOT_STATE_ID);
   377		if (BOOT_STATE_IS_CRITICAL(boot_state) ||
   378		    !BOOT_STATE_IS_READY(boot_state)) {
   379			dev_err(dev, "fw not ready for shutdown, state 0x%x\n",
   380				boot_state);
   381			return -EBUSY;
   382		}
   383	
   384		dev_dbg(dev, "stopping fw...\n");
   385		write_fw_boot_param(adev, IA_GOFO_FW_BOOT_STATE_ID,
   386				    IA_GOFO_FW_BOOT_STATE_SHUTDOWN_CMD);
   387	
   388		ret = read_poll_timeout(read_fw_boot_param, boot_state,
   389					BOOT_STATE_IS_CRITICAL(boot_state) ||
   390					BOOT_STATE_IS_INACTIVE(boot_state),
   391					1000, IPU_FW_START_STOP_TIMEOUT * 1000ULL,
   392					false, adev, IA_GOFO_FW_BOOT_STATE_ID);
   393	
   394		if (BOOT_STATE_IS_CRITICAL(boot_state)) {
   395			ipu7_dump_fw_error_log(adev);
   396			dev_err(dev, "critical boot state error 0x%x\n", boot_state);
   397			return -EINVAL;
   398		} else if (!BOOT_STATE_IS_INACTIVE(boot_state)) {
   399			dev_err(dev, "stop fw timeout. state: 0x%x\n", boot_state);
   400			return -ETIMEDOUT;
   401		}
   402	
   403		ipu7_boot_cell_stop(adev);
   404		dev_dbg(dev, "stop fw done.\n");
   405	
   406		return 0;
   407	}
   408	EXPORT_SYMBOL_NS_GPL(ipu7_boot_stop_fw, "INTEL_IPU7");
   409	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki