From: Stepan Ionichev <sozdayvek@gmail.com>
To: andriy.shevchenko@intel.com
Cc: geert@linux-m68k.org, andy.shevchenko@gmail.com, andy@kernel.org,
hcazarim@yahoo.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Stepan Ionichev <sozdayvek@gmail.com>
Subject: Re: [PATCH] auxdisplay: line-display: fix OOB read on zero-length message_store()
Date: Mon, 18 May 2026 13:51:20 +0500 [thread overview]
Message-ID: <20260518085120.926-1-sozdayvek@gmail.com> (raw)
In-Reply-To: <agrKhHqSfKIb0N2o@ashevche-desk.local>
On Mon, May 18, 2026 at 11:15:00AM +0300, Andy Shevchenko wrote:
> Good points. Should I drop the patch and ask for a new commit message
> (and Fixes tag)?
The current line-display.c message_store() calls linedisp_display(linedisp,
buf, count) unconditionally, with no count == 0 short-circuit, so
write(fd, "", 0) still reaches msg[-1]. The afcb5a811ff3a fix Geert mentions
was on img-ascii-lcd's own message_store before the shared code was extracted;
when 7e76aece6f03 pulled linedisp_display into line-display.c, the empty-write
guard didn't come with it.
So both paths trigger the same dereference: zero-byte sysfs writes and
PANEL_BOOT_MESSAGE="" via linedisp_attach(). The underlying bug sits in
7e76aece6f03 either way, so I think the existing Fixes is right and no
respin is needed. Happy to send v2 with both commits mentioned in the log
if you'd prefer that.
Stepan
next prev parent reply other threads:[~2026-05-18 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 17:43 Stepan Ionichev
2026-05-15 7:12 ` Andy Shevchenko
2026-05-15 12:44 ` Stepan Ionichev
2026-05-18 8:08 ` Geert Uytterhoeven
2026-05-18 8:15 ` Andy Shevchenko
2026-05-18 8:51 ` Stepan Ionichev [this message]
2026-05-17 5:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518085120.926-1-sozdayvek@gmail.com \
--to=sozdayvek@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hcazarim@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®