From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 033393F23D7 for ; Mon, 18 May 2026 11:00:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779102054; cv=none; b=R6F+q5/y/mwqyT8/vMTdDxqerjfK0QETPJZdueinYOzDggKqGRkNN7JmeKHlJl00AX+ac0f2obnbj31NwmYb+KAPTK/hXRIgYAClwvR1DAWNy1FhlVdoc4BQbjqFCUfcTgc8CprgwHfZ+/tTD+/5Bzhi+MZzAP2j4y/8UovtmTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779102054; c=relaxed/simple; bh=CG4sNB/X7mYFR/iyKu3Bu+fMMI6VKefBNED4rCak/hM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PRK+WT4tG7HEpVzC3uKoupo/iOqR9WLK4xHjNnFkBEV3wLBU8uaVBJBQAAk7Wn53dxEt8J85v8YmueVkRLIFHV+XBz68TEWWaxUk2SnzHO0j/3IlC4oQ+zaiwub9LXeN0IYdM7i/Kz8jwWUOL+t2OJ3gcABGBIMIXcpgzn5lElI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p161nVdn; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p161nVdn" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5a746f9c092so3543991e87.1 for ; Mon, 18 May 2026 04:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779102045; x=1779706845; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JvJX+slfx57snLGLCMB+OXIo54ykizFHdlL5Gp1Pnl4=; b=p161nVdnKqubVEVkuQbgIW5UM4PmIMDVRQdDChT8RvMlDAsHqyStl+b4w+H+2TIPhG MuVaMlVx6H+wglDlGnbwjx7kWS18hp+ehuv4jfrFhzu4sMCxiJf2aKeDs2YjmHyPDyQV F7d9TtXiETrMRU0hQKR0jHQKh8HhMulxiPwzCPtEGYg/kOe3EWyAL/oEXQdMnCM+bneH O5srq2x0WZZmTdhL1PgdUxQH6Hg0Y5ST6i5Eacn8gF1Xx1Qg0pWSeY6ktEEVly8V3kE1 VrN1GNp4XCG6s5/2FqVau/dGldeKzVtyET7+Ks0rfMODaXkGkRVqjioz5MY4pn8W3g/a JzIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779102045; x=1779706845; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JvJX+slfx57snLGLCMB+OXIo54ykizFHdlL5Gp1Pnl4=; b=JpXrcHvNwwKUD2WVs92uTO23mivwDYUoppOyFq7hewf2CdR91boOPiW8QMWK7ZOX4Z OHahPc3Bah3qoYzsNXRlgAAoxBIGMM6a45+J47d0SyyAATllJnCrYiXM5usdGeACc35y zkeRe93GYyCKHZsH1dJqTFsaxHeEmYgXDtLWUJoVTsXotAOMEbRsiFYq7eCMz986jGpx qZy5MgjK5PiGJJ3DTUnljs8E4HLy2xaMfEmrNoGXPxIre4Y0Im5VDDsA4Rt4W4udun8S tz7xB/AoeGZbWz7nX05/BD5sKKrwwi+zhxVN67Ra5wGRssDGFZ4UbMuM9jYB+WQvEmMx Gz4A== X-Forwarded-Encrypted: i=1; AFNElJ/MRU/eLX5QT1aVoax+Kkfycb/oRettc+F6ldMPyidANNo9yw+D6WMmHrFs8KaprgHy8Uk3s4fio2r3Jc8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4O1hOa76TIbF1gpcHgIM04WgsySzjuMSEupVcPhWwVVi8q7Tw APwulqyr/KwOLZOnMUAk8YDe09Z/ppOJRoFJAIbuf4z1Kn/RRVA2Iivpvjiajg== X-Gm-Gg: Acq92OHPU11ddBZJlguQO5/tj4aQUwqCxxeJqnTdSDvliita523uOiDiQs6cP1gKtE8 ORyWqPcE6/f/Wn+n+K6q/tlMxtuR6wBt0sMzoocSTuNkON2ICHrHf6PecXW93ArJAcPaNbUn4WK wNeJrkJYm2Ia7JL8cqNV21uFtlUjgtIxeAGaygC6g0bwRxtOnihgQnH7ngvoHXv4uoYvy0uKxrh DVwM92tScCSVFw1c0WLz/GgSWifSyJKCgUNv9o/b7kf8ocgkp2yWsPnhXtmTzFh7WVbYZYr+mAE M3MX4KVRxaXa1eTyg9GuzMvtNsO9JwPakpL0LylfnPSSuvupEEQf6w2/2yq1t10Y5nL8OewVtVa JElTr2jSdUt+kxG9U6dFyCpICYlMAy1E78W9BHfRSoolzankBwq9EUfTZGm9kbCr3miR5pee3xO 7Q2ifndvp5ZA+dDBpaCntahppZ X-Received: by 2002:a05:6512:114f:b0:5a4:175a:f821 with SMTP id 2adb3069b0e04-5aa0e09d0a6mr3470924e87.17.1779102043360; Mon, 18 May 2026 04:00:43 -0700 (PDT) Received: from NB-6746.. ([188.243.183.222]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a9164bc462sm3239263e87.45.2026.05.18.04.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 04:00:43 -0700 (PDT) From: Artem Shimko To: andriy.shevchenko@intel.com, adrian.hunter@intel.com, ulfh@kernel.org, p.zabel@pengutronix.de Cc: Artem Shimko , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] mmc: sdhci-of-dwcmshc: remove redundant IS_ERR() check Date: Mon, 18 May 2026 14:00:32 +0300 Message-ID: <20260518110034.142587-3-a.shimko.dev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260518110034.142587-1-a.shimko.dev@gmail.com> References: <20260518110034.142587-1-a.shimko.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The clk_disable_unprepare() function has internal protection against ERR_PTR and NULL pointers (IS_ERR_OR_NULL). Remove the redundant IS_ERR() check for bus_clk in dwcmshc_suspend() and in the error path of dwcmshc_resume() to simplify the code. Note that the clk_prepare_enable() call in dwcmshc_resume() must retain its IS_ERR() check because clk_prepare() only handles NULL pointers, not ERR_PTR. No functional change intended. Signed-off-by: Artem Shimko --- drivers/mmc/host/sdhci-of-dwcmshc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c index 8c3ca47c8060..29bb46783ee5 100644 --- a/drivers/mmc/host/sdhci-of-dwcmshc.c +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c @@ -2564,8 +2564,7 @@ static int dwcmshc_suspend(struct device *dev) return ret; clk_disable_unprepare(pltfm_host->clk); - if (!IS_ERR(priv->bus_clk)) - clk_disable_unprepare(priv->bus_clk); + clk_disable_unprepare(priv->bus_clk); clk_bulk_disable_unprepare(priv->num_other_clks, priv->other_clks); @@ -2608,8 +2607,7 @@ static int dwcmshc_resume(struct device *dev) disable_other_clks: clk_bulk_disable_unprepare(priv->num_other_clks, priv->other_clks); disable_bus_clk: - if (!IS_ERR(priv->bus_clk)) - clk_disable_unprepare(priv->bus_clk); + clk_disable_unprepare(priv->bus_clk); disable_clk: clk_disable_unprepare(pltfm_host->clk); return ret; -- 2.43.0