From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 193FD2E762C for ; Mon, 18 May 2026 21:33:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779139996; cv=none; b=JnKBFDyvzWyslSwIsOPkE43+wjWIIYYIuX+bdWd956yqFgtxxhto9vaxiNR/mNJh6NLTiEn6TT37imw/lix4/QBturv4K51oCcDkSWq6psZ7YcwZ4Egq/qZ7YQ8KLz0RpvuODllgcGBKWTmGt6YGAqonNBbPpfP+EMNEBg2SWV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779139996; c=relaxed/simple; bh=XxRzFcUOc98Gp/mHuZcGG64BOJ71fKEnWXZnAvJc0JI=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=fr5zlwRlRRBRChT6aFaa3xa7sh8TkHTvsEX/2L+QsC4v4iIKeDrTUm/kxfb5KThVaq+kaZ7ePk9lz6yXh5FIcug08c5tUg8qfnmZv53bLDVQSvVsBQIRAyQ8zA2lLiNbfkgjn11rac3H5Cv7tU8vkPh02GSwVyERoklTLykKRfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=BiKbDEQz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="BiKbDEQz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 635E1C2BCB7; Mon, 18 May 2026 21:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1779139995; bh=XxRzFcUOc98Gp/mHuZcGG64BOJ71fKEnWXZnAvJc0JI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BiKbDEQzQ58qu0e7GDRbT9hKwt4toitW8/OuRnO44IwCj5IyMyMRRWQwDSNxrRPov N2n28dWcCWG1CciJrF6jsigM6lKnC4WJao28pQYe6evG/VgfdR9OgZn751xt3udzLy Y5nh1z4P/5FeVKZTJm1oZbGriADdKGTtwJE+kfpQ= Date: Mon, 18 May 2026 14:33:14 -0700 From: Andrew Morton To: liuqiangneo@163.com Cc: apopple@nvidia.com, jgg@ziepe.ca, leon@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qiang Liu Subject: Re: [PATCH v2] lib/test_hmm: Check alloc_page_vma() return value Message-Id: <20260518143314.dfd290f5a2b553a8e11cb2a5@linux-foundation.org> In-Reply-To: <20260518031903.63455-1-liuqiangneo@163.com> References: <20260518031903.63455-1-liuqiangneo@163.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 18 May 2026 11:19:03 +0800 liuqiangneo@163.com wrote: > Return VM_FAULT_OOM if page allocation fails, which > avoids a NULL pointer dereference when calling lock_page(). Patch looks good to me, but AI review is saying that two of the calling functions are junk, and should be taught to handle callee errors: https://sashiko.dev/#/patchset/20260518031903.63455-1-liuqiangneo@163.com