From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386BE2D592C for ; Mon, 18 May 2026 15:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779119248; cv=none; b=OI65UCx88VVH5YdJKKJCOYxUtSk55vNcGrWbTTm1WjyzpLo8QpYreHsjGS0BJ6bTwYYxG0BH/zkCF1eCPHKLBNkyuOp/eH4fxhkDKYvgTqLfhBrakoN37SEPBhzPNHhKr1mDFeNoXfmW9hNp40kMC4PeldmV0/wBixEd3GBqL18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779119248; c=relaxed/simple; bh=UO8COcfsaqz02sjdD6/7eGxdxivUik5cN2WpzQTquMs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=RObjuzz31tBjf1bsYBTqW6Vr+rmJ6I7DLVQvdaR4qxKF3PKNTfjcPLlaVianuJLxV3iIINYppl+T0YQZ5gHa/G9y26PA5w6vnMUxUHnvn64Jk46jdLntUZjOUjVHGV5eJfOMFb5kh6NuWbnsWpP72TJyJIW1s6/DfOrIszk17vs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YQinennJ; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YQinennJ" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-2efc342ef15so3385310eec.1 for ; Mon, 18 May 2026 08:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779119230; x=1779724030; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=elI3dCv9to9+reTrmH7gWaOOH/Cw1KfhvnnriZ/0VzQ=; b=YQinennJ2/LJQgmXBz3gMZ7CyttkpVcwJXMrMeHx2mQLenLMTeUngykZbXIHlXouNR G4PZjzpyffIvlUrc/h4Lenazi+T3qQhEpRhkHa2GDZ9CVYBowDTJxboi01Lfov39OwTB 7ejTx/4uXOb//9n166LoA/O47fz52ijYatpFBySJTp2KH/lQLG7s7hVRRWnPg1WeZ/V0 p2j+QAJP/ZbafhDW8APl0/DJNz8p7CM0s1TWnzTk6fdzhaSXg36YjSNJTRdSwr3PFRUn WlSgtfS/ED59N4tfqxI301J5ET19GsprrzV1Zjh0pFyIhoIglZ7s6s5RbWap0SXdEa8Q ROPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779119230; x=1779724030; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=elI3dCv9to9+reTrmH7gWaOOH/Cw1KfhvnnriZ/0VzQ=; b=IbKQww0Eot7zcNHg925g3LLUErBiPQMjWbzzS486BIgp/n2NQ+a2kVWXrrlOXMywVD V0oGhY9pTLcjaXdTJ7v4GiP2YKa/ZW9eocdawF1pCHvDrqCd40ea4R1U4T9u85B51hoz CBkKQ7prgHNSbzxZcG3MOOO2o9etTDNE8syjIPe3FVQSByBYMIFc8qVas2uH9VEQBFhA 9aGEU2VaH2EHdX6VX+bDLcyvRn4Mgb60/+ojMhVos8qTK6qiGlLD//fqmBPcKUP51xMC B+RHKPT4WOiAaU8AJ9r/UfnPgp+GyZFRV7wrs7b2SLqftN9Xrxh4o1XEV+1vD96tEFLN gnLw== X-Forwarded-Encrypted: i=1; AFNElJ+0QkGmh6Auu8X65kkEmdwwnimQtybD41S4adDKktg33KE1jQMm9FDWmVVjimTTV9nVi+Sjo8KLCN7LolE=@vger.kernel.org X-Gm-Message-State: AOJu0YyYkRBNTqfR297MeVlnvU4E6TSxbN1uE3SDQip3SBFUVHFuGVz2 j90xRE984bAe8qzBYhxQNL8oNopUB9xqRM1hMI1RtE8Yygk4qiqOMuw4O7Q1ejtgPWFu2Egv5Uk Y7POjsvTFKQ== X-Received: from dycmx4.prod.google.com ([2002:a05:693c:2884:b0:2ee:de47:cde3]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:d706:b0:2d9:f0b3:1d98 with SMTP id 5a478bee46e88-303982860f0mr6417996eec.7.1779119229503; Mon, 18 May 2026 08:47:09 -0700 (PDT) Date: Mon, 18 May 2026 08:46:36 -0700 In-Reply-To: <20260518154638.2798789-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260518044740.2526802-1-irogers@google.com> <20260518154638.2798789-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog Message-ID: <20260518154638.2798789-13-irogers@google.com> Subject: [PATCH v7 12/14] perf build: Prefix SCRIPTS with output directory to fix continuous rebuilds From: Ian Rogers To: irogers@google.com, acme@kernel.org, namhyung@kernel.org Cc: 9erthalion6@gmail.com, adrian.hunter@intel.com, alex@ghiti.fr, alexandre.chartre@oracle.com, andrii@kernel.org, ankur.a.arora@oracle.com, aou@eecs.berkeley.edu, bpf@vger.kernel.org, collin.funk1@gmail.com, costa.shul@redhat.com, daniel@iogearbox.net, dapeng1.mi@linux.intel.com, dsterba@suse.com, eddyz87@gmail.com, howardchu95@gmail.com, james.clark@linaro.org, jolsa@kernel.org, leo.yan@arm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, martin.lau@linux.dev, memxor@gmail.com, mingo@redhat.com, mmayer@broadcom.com, nathan@kernel.org, palmer@dabbelt.com, peterz@infradead.org, pjw@kernel.org, qmo@kernel.org, ricky.ringler@proton.me, song@kernel.org, swapnil.sapkal@amd.com, terrelln@fb.com, tglozar@redhat.com, thomas.falcon@intel.com, yonghong.song@linux.dev Content-Type: text/plain; charset="UTF-8" In Makefile.perf, ALL_PROGRAMS includes SCRIPTS (perf-archive, perf-iostat). However, unlike PROGRAMS and DLFILTERS, SCRIPTS was not prefixed with $(OUTPUT). During out-of-tree builds (or when O= is specified), Make checked for the unprefixed target 'tools/perf/perf-archive'. Since the actual script was installed into $(OUTPUT)perf-archive, Make concluded the target was missing and continuously re-executed the script installation rule on every single incremental build. Prefix SCRIPTS with $(OUTPUT) and update the static pattern rule to ensure Kbuild correctly tracks generated script prerequisites during incremental builds. Tested-by: James Clark Assisted-by: Gemini:gemini-3.1-pro-preview Signed-off-by: Ian Rogers --- tools/perf/Makefile.perf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index b8a81c9749a8..fc92d6ceac5b 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -405,7 +405,7 @@ python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT # Use the detected configuration -include $(OUTPUT).config-detected -SCRIPTS = $(patsubst %.sh,%,$(SCRIPT_SH)) +SCRIPTS = $(addprefix $(OUTPUT),$(patsubst %.sh,%,$(SCRIPT_SH))) PROGRAMS += $(OUTPUT)perf @@ -592,8 +592,8 @@ $(GTK_IN): FORCE prepare $(OUTPUT)libperf-gtk.so: $(GTK_IN) $(PERFLIBS) $(QUIET_LINK)$(CC) -o $@ -shared $(LDFLAGS) $(filter %.o,$^) $(GTK_LIBS) -$(SCRIPTS) : % : %.sh - $(QUIET_GEN)$(INSTALL) '$@.sh' '$(OUTPUT)$@' +$(SCRIPTS) : $(OUTPUT)% : %.sh + $(QUIET_GEN)$(INSTALL) '$<' '$@' $(OUTPUT)PERF-VERSION-FILE: .FORCE-PERF-VERSION-FILE $(Q)$(SHELL_PATH) util/PERF-VERSION-GEN $(OUTPUT) -- 2.54.0.563.g4f69b47b94-goog