From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37B9D398903 for ; Mon, 18 May 2026 19:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779131309; cv=none; b=stydCLS5M3YBaUm/7q1Gfcwo557K23Hfxis6Ffzu92xuw7Y5d70fWZFeSNcgrWCkTnB5B8MVYHlYcz3/TA8/2O7pxvlYeO7T0O+WgvaTvcpBPJFD8f0fs4dutTWmAI7BuDlAFbYa5bXKw9xC5vYoX6Db7luzWGfEWZXkhl8+Xhg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779131309; c=relaxed/simple; bh=Go4EyvhlQyWzHCh2p+9M+OIk/P0VvfEAaU7NdiQe9WE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FVleGWTxeXZrzBdwPe1Yyq+cl64Kr/RxUgDqjdgY8S6Bd+0EBx7rvIla02DeQUbzAAATOuNX8ME4GQm0ablAZBK+K8VoTDKRxrtKDpmd4rCAd2hgYxcH4XsUYCTzpH0o0Zzz7/UeoXyinEQ/jrP7AXoZBjyun6UEg/eqExx5hxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MATGCAfT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PuMf9Iu4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MATGCAfT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PuMf9Iu4" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IHXOcZ2083007 for ; Mon, 18 May 2026 19:08:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Rv3QXoFqyvR 3pKOjjPZUAdbwE5pf1YjcLxou3Iv6008=; b=MATGCAfTHTjmD2SefqkP28NRyIS 2jeDDNN6lFidk60hs8kkWyKDZsKE6GmUVyQcUHXmVvyZC8BwS+ttmyD4j6rZ1NMb 2VcqgH4v3u2mC2+cNk0ThhD9jvOw74TvKUhrAYUeCFyBDgt2aTqeZE7x59EkOJAS 8wDvsaWa0x52Zf90ABI0zMY5SFOrZUORbeat6pUSdi11d/CGvLU19lEUd2hM2EYv D4ZoZ8fNkkHhVMPUKYdukPbBvssqIm9aZz5W4fFhuGcUpxLH+wsj+qu0ScFGS00b Kw01RkRPFlPuwXMDM2VFcHQbL6TIR/sFr695G4CgWSImq36he+o3KtBNNDQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e81ch9xc3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 19:08:27 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2baf7378ad0so29468895ad.0 for ; Mon, 18 May 2026 12:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779131306; x=1779736106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rv3QXoFqyvR3pKOjjPZUAdbwE5pf1YjcLxou3Iv6008=; b=PuMf9Iu442LDgqhhOevZkfxneVwFg5ypym8wEr7I76CtddQD9/VDPV8fB+03fmrPJX HDmFgCes+KhRlRVw2IUXv7idUZslGjukaJcW3oIigiZLzTTCe0u07xG1M6gPsaYaUMah xzzJtkmEKyNQ8XJ1+jELcWCiE9PYqmwQz+UccAh4QwhisVrqBvo+ixljqpq2MLgiAZRQ zhOL9GEy+LTGAT79zA7/hi1w8pMIjyRrHcpdvmbR2GrgaWlCDzrg4T7RM/Toj7qJkXdW jrPVRR/DXCP95OzaroBaffhZ/nPFdugogowQPo+qJ9f4FHtTHDeoXqrgMIy6etQQ9BTq HpPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779131306; x=1779736106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rv3QXoFqyvR3pKOjjPZUAdbwE5pf1YjcLxou3Iv6008=; b=W3rB9F/MV3z3ZuAcixO5ETKcGpwl3TGRYerajZevBStWK+vKAI+f6bkM9b44J8Ad8n Zeko5ckpnMCX3+4/MCiFi9xtSulJMXoSMot5lG4LptKDXn7wl1mM8MFdCO7FWHwF8W1e tdwpWL5s2eDVRGUhQ7yP5dg9vEM4BJWyysFw4G4FznHIN/iem/Gp+Dcq4bVY9vEfHJ0+ FYe6wx9+klCxlQMw2DEfmOPKtY6i2fkgLCZGkQCrUuFfJoxhK6i86F2r+eD+WMMd7sa2 CN/wCQ/j8TjFxl9pLD/4YrBt1AwRDpeXz2gDxoEaU461M4OIHGiUBS3td6MM2J4ZTLc6 JE+g== X-Forwarded-Encrypted: i=1; AFNElJ+or545TPDOZiiVDehZ4N+qyHzBiBORhg5BhYClDhzS/xvt+D9KbXRm4+AwYDxeAC49ArFONauHLZ72mhU=@vger.kernel.org X-Gm-Message-State: AOJu0YxRUUbMoqb4l7q0Y4wZj6ROmtUwD65+iaT30g6wQ3/iU3JpzbdP 17/bRowbHTYIMSeEQ3nSNkjCnLDPFYyCXD+4msKMkHOnJ+/042o80oTjNzz2X7CKuCBbWcaQr81 VBGJlTuTjoNfbcOhAQS/ZNzN625VOtaf/lxu/zt836Y1e3WMy71PuKgK3RbkYqxvKXiU= X-Gm-Gg: Acq92OHpnmTSdckUaGB6+Rpx0PUGUa0ia2W30Gq7PJk7rvlTTSYBxJttFlPPYOq+Aar tZnv546i9oUy69y2gLpjCwH8R35cs2Hnc9Vjvumqjs15ONVDfY38THy+Qnem5g3hfRZWSqYlPT+ uFrRJIj1x82OxVNoPI1QeY2aM1CZuNwUTzJlK14xQcgAjEQDTNAUXgm/MQbULf24Dq/zPRtZz+8 wuayhQeIPNIZ3eZ3ltnZUrHdeV6ZkHhEZzuzIoQRZF96R1dFV9haeKuql5Y96nVBqh5MBtO3tYl w5Kv8js10pGqab4KD9GADuNDqn+ISzwf+SGnU/47pkNLMuPvKOJTTglm9JuAB3ceQgHbRpfhwHf 5PdnLZZ1vTk99RUCDEVyzyvjnPriR7Lsy X-Received: by 2002:a17:903:1a8f:b0:2b7:86be:7673 with SMTP id d9443c01a7336-2bd7e85fce5mr174140985ad.6.1779131306222; Mon, 18 May 2026 12:08:26 -0700 (PDT) X-Received: by 2002:a17:903:1a8f:b0:2b7:86be:7673 with SMTP id d9443c01a7336-2bd7e85fce5mr174140625ad.6.1779131305705; Mon, 18 May 2026 12:08:25 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5f2dcsm157769815ad.13.2026.05.18.12.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 12:08:25 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Anna Maniscalco , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v7 12/16] drm/msm/a8xx: Add perfcntr flush sequence Date: Mon, 18 May 2026 12:06:39 -0700 Message-ID: <20260518190735.16236-13-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260518190735.16236-1-robin.clark@oss.qualcomm.com> References: <20260518190735.16236-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=a4MAM0SF c=1 sm=1 tr=0 ts=6a0b63ab cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=W-43u8CF5Pkpiqpb4b0A:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDE4OCBTYWx0ZWRfX/GTQUqogulFt tcNi5tyMRNscyNBPfdjFqXa40LQyEI+cFcR9iImNytmLJf7n4TiQgXY06hH/4kmvPW2zesGo+RO UA+fjnMGq9o1Xa5pUCrQ9X4ZLLb0p971DkCLjZeYSh4PUuGFusnefPJkoRGZcuiLO4C7yihFfQm 7R+MH/QZhcf7VTSs9teMYHC8kbMgUdhB039e9eGXS+xOaGBQFHaWorvSPXZAECZWZjYhAqxOjkb K7zvfdniGGQ1ZWo4y8BbsGY4W3CnwmgTtF1yp6uSt1mnwl955H8RLP/vv5lKK83cs8Hf+rW5+zO LawTA/e7F+6f+oclGD1acek7bJ1+MMI1Y+dNfPBlVHtc8OnIp2qG65ZHvv+qMreCe/eXY5oxo4k 2CpFqzW2Iqai24mbzEdV0iCm3iyulTWAh8V+uOaR693ZGk+atRtxHeCIFb8nENu/LA9gTL/j6yA gL2odxCwPeIZYoBc/Gg== X-Proofpoint-ORIG-GUID: C_gi5lNo0BapQraPinya9LfHeMKjP57T X-Proofpoint-GUID: C_gi5lNo0BapQraPinya9LfHeMKjP57T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180188 With the slice architecture, we need to flush the slice and unslice counters to perf RAM before reading counters. Signed-off-by: Rob Clark Reviewed-by: Anna Maniscalco --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 20 ++++++++++++++++++++ 3 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 30df9bfa9ef8..a329d20033d7 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -2921,6 +2921,7 @@ const struct adreno_gpu_funcs a8xx_gpu_funcs = { .progress = a8xx_progress, .sysprof_setup = a6xx_gmu_sysprof_setup, .perfcntr_configure = a6xx_perfcntr_configure, + .perfcntr_flush = a8xx_perfcntr_flush, }, .init = a6xx_gpu_init, .get_timestamp = a8xx_gmu_get_timestamp, diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h index 99c3e55f5ca8..3491a24a9320 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h @@ -334,5 +334,6 @@ void a8xx_preempt_hw_init(struct msm_gpu *gpu); void a8xx_preempt_trigger(struct msm_gpu *gpu); void a8xx_preempt_irq(struct msm_gpu *gpu); bool a8xx_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring); +void a8xx_perfcntr_flush(struct msm_gpu *gpu); void a8xx_recover(struct msm_gpu *gpu); #endif /* __A6XX_GPU_H__ */ diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c index 124d315b2469..6c040f718176 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -1345,3 +1345,23 @@ bool a8xx_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring) { return true; } + +void a8xx_perfcntr_flush(struct msm_gpu *gpu) +{ + u32 val; + + /* + * Flush delta counters (both perf counters and pipe stats) present in + * RBBM_S and RBBM_US to perf RAM logic to get the latest data. + */ + gpu_write(gpu, REG_A8XX_RBBM_PERFCTR_FLUSH_HOST_CMD, BIT(0)); + gpu_write(gpu, REG_A8XX_RBBM_SLICE_PERFCTR_FLUSH_HOST_CMD, BIT(0)); + + /* Ensure all writes are posted before polling status register */ + wmb(); + + if (gpu_poll_timeout(gpu, REG_A8XX_RBBM_PERFCTR_FLUSH_HOST_STATUS, val, + val & BIT(0), 100, 100 * 1000)) { + dev_err(&gpu->pdev->dev, "Perfcounter flush timed out: status=0x%08x\n", val); + } +} -- 2.54.0