From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65DAF39023C for ; Mon, 18 May 2026 19:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779131285; cv=none; b=p6oaX3BkDd/YpIzaYtQwcN/Kj6fAgRWvp6q/vUO83/UhMRWyPQQnndFrPrARaJ9l3wlo8w2jGprxoZyb7Z3IS7oMBM5uUjddVYaBDY2eZHvQd7oZYcfTNafSS+peHsZ3TBe5lG9eEMlUcJWsoix5lQ+i/fF+RsOPl+x02vqtvqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779131285; c=relaxed/simple; bh=hNYajq5FoO8Ohwqtcny4uUuWTPmnir7ozBVWoOEnOkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZU9gsypdlPe0X5nOgsRu7jsNO6GOv+T/AJL5+KTRtPi5V8bDzLzqMGFCr9BQJStHPHto6uAOrXu6VWR1TQIVY/bYSyKd6VnaCJSeJTgYqv8L1TyIP1t7yTRnr9hPWRuTcRev81NoPn/7jBmU5KaAr2GKPNrtGIZDBzEgjiM5R0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CNXTESBp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GUX/Rbk7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CNXTESBp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GUX/Rbk7" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IG73tr2091132 for ; Mon, 18 May 2026 19:08:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=r626fk8GTYQ 7mVDurnFWdbX+Kfuz+zSekrPETuLYfy4=; b=CNXTESBp47U1AEyP0/C8RdCk/Fd ackEbQ4Rot206/j24X7xEnrghkdCQHZJO4J69LbGUe6hLYAwYeflzWwUa2Rx6Iow a40P1PFkkaNtRaYl1eFRTVJpTxbOEgsO9zv/JimfjZjWDU7YhaxQTKFNU2erp7ny +AGllerARffASgVWrm1RnmtZ17OeR6r1Hfqplluq4B3Q6Lgtn0ZkkLA/5v8yUlms 05rQa9ZRTtHfsZnrbAeBtSqFaoXJQyS1Vh1gOpU7/g5ne9i4q/KqgcnGh/5dFIIY PP3yir8P5PIXi5ynyc+mtSsDNUhP49uz6qQRjrPqSJLgxwWuSWUUgSIOstA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e80rpj3we-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 19:08:02 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b9fe2d6793so69405445ad.0 for ; Mon, 18 May 2026 12:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779131281; x=1779736081; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r626fk8GTYQ7mVDurnFWdbX+Kfuz+zSekrPETuLYfy4=; b=GUX/Rbk7MrU+v4S3apZivj1oHDUFhgUV7qBjruaqdkOFqo4XnGChhITmClV2TbE7Jp 9cdOrbEahLFoHn4eGS0RZmyC5Ww7Z4gj6XwCm3dfbVu+121ygwJp7DWeEOBIyOzDlLMv BKrpedPjkiH+VHh22PIW2HvBqwZBcLiIe9ZUwM/y+1oCq9zPenmdMgBgEMFSWmrQs026 3X4m3WS0zEs92Hy7dCPipELQd2w+OOtfIDj7BfQysqsGQkOIVGEPfsmV9LQhzx9YJW9f goI0aLepeUDmIhNNL0MhN3qb02ABWCaG4XKf8TrFLPiUpFCtj7VNjdgHmyosJyzoLMaP jvCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779131281; x=1779736081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r626fk8GTYQ7mVDurnFWdbX+Kfuz+zSekrPETuLYfy4=; b=fKXW9T4ujJ765joXZxOmSmkEZyCiBNrlDwukai4ulJg07QWMguZBySjeRDuYvEmghR 3iq/8R+atqt8Ktc7cVgxSNAXJYMfrMZCcWEXjvZ7m8y8VdYNV6fZL8UnaK+VKc7YMovC Sg2hHi92Jmt02b6s3uGwAW3DRukkyrnQTG5eEopc+PzUc/in2Px7CqZiE5t0McsZ7zfI pMrh9zPlaWgEY6Ss7UhUne14zapZoCuEKuoKvIfwpTgwGt1kIbo7b57/s0PjaVVZtJGF wu+fAEpRaw9IVAQ2ZKqj3/6e9wwXst1baNTVn8h3hdvB6bHWCGZ8Q5YqdvvcvZS+aq5G K3/w== X-Forwarded-Encrypted: i=1; AFNElJ/ih9T0KjGIBI7xfCOCPNuMQ8gEgs53l3/vxIcbJSHQIbZ68hpVV5BtLlrGHP++f8glUNv+1RcXC2Bswys=@vger.kernel.org X-Gm-Message-State: AOJu0Ywuom3n7lZhi/6sAJ0AmYD8OVZLYMocZr/I/EkX7lfN88cPaceM 2HlXv6NnC4ZloZpn2kHNDlLqxBWFztgK6t5OlrSV/YBKO/6yRlUwke7+9PFcVa5KUcmCqxEW5Nk VR8KWFKGPVWtiBn/TLaVjvLlU8jIiZ/zSChNso2cAdGEerCE1RLlWQtnmpl4uzeZ/NrA= X-Gm-Gg: Acq92OFLDWDxvXms9uxuqebQ3LODk3db9U37GU0AiVo3SIRpBLvwbhU8MSu9hTcPb/m x5M6zGsL6QmKCqeF3uepmvtYoReQOUWEHnoXB7OS5YcfZRE9+5fCPJmXi5FXsNGiWe5Ut4E/e0V 1cI2op9uz5dlY/XvZBGZfw1sU6ovSCIbpgiTopuVRPU2RfAQRLqUOGB7AVFCQsWV/mXoMuseJfm 5zC5myTKxIUmYFPkowLPKfClPfb9CtWgk4EJogKT4K9tlsPmtHVPvG4+Hz+EbM8Cx+tS017N2Go gjGZ76crFCY0LUK4LR+4ARzrOZM8ay0v2wC22ST5PP28HfvBnF+047AvPUyMJCk4W5x7G+V6Qzo Nao9sO10twC/4RishOXsxBFyO/oqbJd2z X-Received: by 2002:a17:902:f38e:b0:2b2:4d36:7aa with SMTP id d9443c01a7336-2bd7e8cbc80mr136657745ad.35.1779131281369; Mon, 18 May 2026 12:08:01 -0700 (PDT) X-Received: by 2002:a17:902:f38e:b0:2b2:4d36:7aa with SMTP id d9443c01a7336-2bd7e8cbc80mr136657525ad.35.1779131280870; Mon, 18 May 2026 12:08:00 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5ef27sm202768495ad.8.2026.05.18.12.08.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 12:08:00 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Dmitry Baryshkov , Anna Maniscalco , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v7 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Date: Mon, 18 May 2026 12:06:29 -0700 Message-ID: <20260518190735.16236-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260518190735.16236-1-robin.clark@oss.qualcomm.com> References: <20260518190735.16236-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: JTjb1QNABUBHN-VcCLz_yr8i8juLKOmc X-Proofpoint-ORIG-GUID: JTjb1QNABUBHN-VcCLz_yr8i8juLKOmc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDE4OCBTYWx0ZWRfX35a1GVIRMAYM EqaDxQw36oBVUVwDosl3mffGPQNEuIfN0m31DdYgI5dGP1+B3YWci7Bh8t93clXQYVmYQq47ZWd KcCfi8EUhgycY28UURWIWNB5Caa8u+3JOtM+mvlL7ZjJXpEy119y3+4UkNAeO6ET1qs5oEqhvZh zIf4BezJjfJgxJTv/g3nRmMs0fDctbtvf6RxpjA8hG69fjclTnz2jYTZUBtwR3h12Nf+WNr7wiK DUEKa62TtD8X5vuy+r8/22Szbj6BBvD0dv+AmtreVtVs9RBwkj74q3Sqkr8flidniNb5EQEPOyN +1hZOBMxpFoO3rkrcgWbTkosaN8lR8YqOTAvQhTJMU/NYkXBJ98gXyRBuFSsxZAgUcC8r0p1zks uOb58/0lmtSnq7M+ESkHdYJ1Mqc4l1w3UXtrKL8AV8l0/MTd6xUz1WpBkucSkkiEreEmeag37hz upPnN4EjF163BTIzEnQ== X-Authority-Analysis: v=2.4 cv=ecMNubEH c=1 sm=1 tr=0 ts=6a0b6392 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=ZRXlmS4ShPoOlOK7p90A:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180188 Use perfmon_capable() which checks both CAP_SYS_ADMIN and CAP_PERFMON. This matches what i915 and xe do, and seems more appropriate. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Anna Maniscalco --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..72b71e9e44f0 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -494,7 +494,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return 0; } case MSM_PARAM_SYSPROF: - if (!capable(CAP_SYS_ADMIN)) + if (!perfmon_capable()) return UERR(EPERM, drm, "invalid permissions"); return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: -- 2.54.0