From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C20A391826 for ; Mon, 18 May 2026 19:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779131286; cv=none; b=XDzqgDNFaD2Z3W5l4GrCPrt6MBHzSR+hG45Gp9qd1Vq1NWbBvY2dtJdFNMUPRjwit7sDhZKPmJsuFwgKJkKjFOfnWf3ACQWUIIedVBXeKQt/s2iAgq3opgZwfyL9+3g22pkNQj2Rja4svFI76ByPj55MZxVGaZtauQjMg67lOwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779131286; c=relaxed/simple; bh=OrL3+x1tcgdp6L7F08VxJfvF3uGmnc+Qbsj9WOcFBI0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R+9PDNv+uGfEWQ4CQg9ZM81/RB9Cpz0bU0GRg7EDF8b/rRP+0jxZm5VEy0nUFIfb99ubmGL01XLv2Gb5Vg+cTNXZBQPjTaRHq1mMCsr75xGd5W7gLhnPu0FxYf+VnnFMzY7zMtEgb68BfqCfsFKkjiBbW/VDRUPqVacXsP+NmYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VZuMABIv; arc=none smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VZuMABIv" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-65318dafbcbso2621873d50.2 for ; Mon, 18 May 2026 12:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779131284; x=1779736084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ygoe/8YI/F9vvMO0U7oDJ387wljZe6nsikPiQPuzlSg=; b=VZuMABIvBw4LZZmsjLk22c86RyG3EE1ru0uc+d8CAMnhMyF/3R2SaRNge/ttHytNlZ mDYg+hZgRM0LXco2MwdD/vk+aRCHaDi3jF5Wqb8ur9CP30ElYaJUFfZUIfLcPC2e4I/P GM74eM6V5h5tm6NOlwlekOC0iUw8suGyaA9TkNOvm6WVmulfEJ2QyBpRqSzDRgmqq8H3 toNTt4/eUC9GKX+5jZoGunodmAebkGuabc2X5qpoX/ZNJKUuOBpJMNpCV2w6JlySJsv4 A9+f4WrCfjPx2pOvwuQ610SijPSifCmy7rPi6h1po2O5dX0O9bjYOQdHirGfsz84MMwT y2KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779131284; x=1779736084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ygoe/8YI/F9vvMO0U7oDJ387wljZe6nsikPiQPuzlSg=; b=s9VXGKZYBRd0td+m3NVPqL3hBc9dGXhcC/vu1cJxU2+BaBjPJXjHHmSlzu3GVUZ2YK 6pSwys1vxJoMet2JmBqhXENMkt3/uYCRO2sHbpwvPZEPpIKKkVcB+7cv4C0ANCfsWwHL Yguo+FJSJV5eowK0yFTqs2npJovEjEwKzt1dbVbNfVWgpnss9GW7xpBHJ1ehw/GwHwAX HMGj1GBKhh25Nes9eWd+0gzVehwuRQt9hnVoKri3I4qxq6NlyHQdw06FPWNPV7ttLbyj bJhuvhPVTotHCA3R5Ye2/moK+RC1ZbRqjKPE9xlHimpLyCzyfGz2NTKc3Bg5HYJno+6h MQcg== X-Forwarded-Encrypted: i=1; AFNElJ8J1rk4Nc4dSatNRE9XUFiUFPCWn1Fw/rqFzwTwFjJVu6MS4r1hAE7iqeZ9b6WZEVBZrXNBKX9CnhDtnk0=@vger.kernel.org X-Gm-Message-State: AOJu0YwkrYEB9941JoGk0ZaJjbPxUHqh2Dy34Q3l2XDWJcqRgA6tapbW 0lZT+2AW0RBVqb79rL43a2EoVqN1K0ff7uv0EH40Rx2mkXMAVoAnmUHI X-Gm-Gg: Acq92OHezRYQH8M8vvfSrc+wK6099gYrAT8aKPmQRaNM2nGLEX7L9o6Fk7Vtf2GFu2O R940yH0dLAZm/5GfrKW1wWU6OhGF3N9fqEKArHR+aKIT0k3yy8mYvoGo3F+qQsFI4w2Nbq4hMWN HxzW1KHHCl2wb0L/Y2rAhaTjopdo9d0Rd83MNl1T20QRaSgmfCFsvGUmYEKFLc/MN3GRJjar7Fi iBXGgfAUYO+b7HKHvQXiCCaHS9Tp65w1LbLBepPZdnBrM7oWRPWhsNpQKYL0BtRlGKkgyuTsMIw dn2SzdxGI7Dn8wKssCPVNQBvL/FBBMpzFIJOOANcj8cedKd7UxHI2VkSEvpe0CohdQW2aRxa2YK dDfd7z29EaFV069CcL+jNWlb1DfBkrNv2TYMv39hKlWFE2/iZGWbZTij7Lxn8JZ+tuz2xg31AOi I+4b9vmIVC6RJ6lmL14ju5MDdQT1eJMxIcgE9NFHtfUS9tLjtgzU2btBQ0GI6yjdkmCGmeXvdsx efdSMvb3rESUieq X-Received: by 2002:a05:690e:c47:b0:65e:43a2:82ae with SMTP id 956f58d0204a3-65e43a28920mr9545838d50.57.1779131284347; Mon, 18 May 2026 12:08:04 -0700 (PDT) Received: from localhost.localdomain ([186.151.100.108]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65e0db0b11esm6766160d50.11.2026.05.18.12.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 12:08:03 -0700 (PDT) From: Sebastian Alba Vives To: yilun.xu@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-fpga@vger.kernel.org, conor.dooley@microchip.com, mdf@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sebastian Alba Vives Subject: [PATCH v8 3/3] fpga: microchip-spi: fix zero header_size OOB read in mpf_ops_parse_header() Date: Mon, 18 May 2026 13:07:42 -0600 Message-ID: <20260518190742.61426-4-sebasjosue84@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260518190742.61426-1-sebasjosue84@gmail.com> References: <20260518190742.61426-1-sebasjosue84@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mpf_ops_parse_header() reads header_size from the bitstream at MPF_HEADER_SIZE_OFFSET (24). When header_size is zero, the expression *(buf + header_size - 1) reads one byte before the buffer start. Since initial_header_size is set to 71 in mpf_ops, the fpga-mgr core guarantees the buffer is large enough to reach MPF_HEADER_SIZE_OFFSET. The only real gap is the zero header_size case, which cannot be resolved by providing a larger buffer, so return -EINVAL. Fixes: 5f8d4a900830 ("fpga: microchip-spi: add Microchip MPF FPGA manager") Cc: stable@vger.kernel.org Signed-off-by: Sebastian Alba Vives --- Changes in v8: - No changes. Changes in v7: - Correct the Fixes: tag commit hash and wrap commit message at 75 columns (checkpatch). Changes in v6: - Rebase onto linux-next. Add cover letter. Suggested by Xu Yilun. Changes in v5: - Drop redundant count check since initial_header_size = 71 already guarantees the buffer covers MPF_HEADER_SIZE_OFFSET. Suggested by Xu Yilun. --- drivers/fpga/microchip-spi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c index 6134cea86..cc8f6d7bb 100644 --- a/drivers/fpga/microchip-spi.c +++ b/drivers/fpga/microchip-spi.c @@ -116,6 +116,9 @@ static int mpf_ops_parse_header(struct fpga_manager *mgr, } header_size = *(buf + MPF_HEADER_SIZE_OFFSET); + if (!header_size) + return -EINVAL; + if (header_size > count) { info->header_size = header_size; return -EAGAIN; -- 2.43.0