From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABAB838F927 for ; Mon, 18 May 2026 19:48:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.28.215.223 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779133723; cv=none; b=TlPuT7zB0AmDb+VDa1fOqFuhGChpJ0eoQ4dwn3krRlhpMnbCazXV05yIlT5cvzNTMOsy3cWsyBlQ1AfJAdY2wetsp89N7yhHAEX/D3OpiaqCCjfsSKSoVI9K4vSzNCzwg5eX/GySe3l+gUsXl+9EfiDwZRBiQqTwiy+GLbt8Sro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779133723; c=relaxed/simple; bh=QnoOVgUj5PNhMEkdjGDD7bRgvpp91kbiYlicF4eRMoo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I8Qb/Nk9ik6INluvSGlPkdlu2PEa8x2OFNA346XkcMS0cMI0jeVWiuiGY16jBTcop79xmtUvqMpmK3Lf1LXhp3oIt4A38hQ2MKrX/dQN6ADSO4Iaq5WfNJzDe0ZGFZQNEUMoA3CAgN4+XdKfC9pMeyw3ifgRIkQKNMMNsg9nchw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=gvmSST47; arc=none smtp.client-ip=149.28.215.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="gvmSST47" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Cc: To: From; q=dns/txt; s=fe-e1b5cab7be; t=1779133717; bh=fkGNzPgLT1Dz0z6nTFi2No6Ifen2fpOCha4Dk4M3oxg=; b=gvmSST47T47gQfbb3FNz0wNVzRJcUfXbg6t09B5pSF89TPhmLnFGS3Al5CUpTWPpVx+pyflnC rH7+tA7SUlrzvRUEdN7rnY+/Rh5IHWasdtmPdo7zFVx8bOqQmIOmebGMYUOQw7wXfFvwCxKdgA0 ixIfWU8IuG002mve5iZmc1AS6oIKlUk0k7F2XC7irhbtUdeKIFqzPFJ0wmT0qOGTZEtPYGDS3XS doQDXM2R4+4iw1hfE/s1vTojUcE3ZW34dP9ptZftyyxeoLb4KNgg2LF2SZYyLAB6EL3uPLeMbBC dg4tSFIypOjnEFa4itCZBpIeJvkEfFvVojUwhf+OiuGw== X-Forward-Email-ID: 6a0b6cf1b74b0ebd362eee3b X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.8.12 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net From: Jonas Karlman To: Neil Armstrong , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl , Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jonas Karlman , linux-rockchip@lists.infradead.org Subject: [PATCH 02/13] drm/meson: dw-hdmi: Protect from possible NULL pointer dereference Date: Mon, 18 May 2026 19:47:30 +0000 Message-ID: <20260518194744.2483580-3-jonas@kwiboo.se> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260518194744.2483580-1-jonas@kwiboo.se> References: <20260518194744.2483580-1-jonas@kwiboo.se> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The IRQ handler can be called at any time after the call to devm_request_threaded_irq() completes, even before dw_hdmi->bridge has been assigned later in meson_dw_hdmi_bind(). Protect from a possible NULL pointer dereference in IRQ handler by only calling drm_helper_hpd_irq_event() when bridge has been assigned. Fixes: e67f6037ae1b ("drm/meson: split out encoder from meson_dw_hdmi") Signed-off-by: Jonas Karlman --- I only observed this NULL pointer dereference one time, without being able to reliably re-create a similar timing scenario. I still think this is an issue that possible could happen and likely should be fixed. Note that patches later in this series will fully replace this change. --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c index 993f6d5d4b29..eafe7daf6ff1 100644 --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c @@ -520,7 +520,8 @@ static irqreturn_t dw_hdmi_top_thread_irq(int irq, void *dev_id) u32 stat = dw_hdmi->irq_stat; /* HPD Events */ - if (stat & (HDMITX_TOP_INTR_HPD_RISE | HDMITX_TOP_INTR_HPD_FALL)) { + if (stat & (HDMITX_TOP_INTR_HPD_RISE | HDMITX_TOP_INTR_HPD_FALL) && + dw_hdmi->bridge) { bool hpd_connected = false; if (stat & HDMITX_TOP_INTR_HPD_RISE) -- 2.54.0