From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [121.127.44.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC88A38B7B3 for ; Mon, 18 May 2026 19:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=121.127.44.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779133697; cv=none; b=rie0KCSPg82ZAsITh3q6wDlIv3Wb+qkNpoFJTUlkApNeEghT9tKVWL6rL/ecnfsQKizwTAe9VEGLajyCBKUI7mg/HKTr2Xqt5AyZkP1G9iAERx2LTTuECko4l+ZqFP3lCuQrwUZKBbBAbND5N4Xxkd4j0idBvbJhI7/GyoVmtcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779133697; c=relaxed/simple; bh=ka/s4iTWMqKEy8oW+H11xARklRI8UMOhJ1uXVs4AWAg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zkk7Ocrw8CWv7Kalr68xnmWKMCNHEtSdlbrbXX2mFlwsp315/BRAXZ3QxsZSGVs7CHdI/Rk7xKIp113BZlIFwhToIUzMdm0RebmyTmDTCaO3ClnSSX9Uau7vUoIdzu3yIhe8k6LtzOSrxLn7mY2kWewMvBEG2jk6vy8ukGAT81w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=XuGCimcC; arc=none smtp.client-ip=121.127.44.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="XuGCimcC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Cc: To: From; q=dns/txt; s=fe-e1b5cab7be; t=1779133695; bh=FchV9glvh5UhWTEiURTz/glfciz9Vw2jj22qgC9Vt+M=; b=XuGCimcC7YLQIicVcGOs7RbIhRWYHLPeVWV3jpZcBSXJMYSKNd7gqd3EkFLZykoATb609F8y6 5uMFuhYPSCrFmuX6qMIupm7jt9d+2INwjIoBl+cO7aHTQK6hE2+YWWZyg4TqAq+BQtl2WsDhptu UdTR0FcpwDPGEse5kFPobmp4iPJog5JA2gQ0+dYgS5zR3jH9MLvxF+7IdP9qAPpqQU8nG9XHlzG /uH1R5RBwEh+ogBZ3FR/dg01/kSIlUVE/uNfpaGLYXi1wErA/TcWVgBJyk3t+ZTUr6T4sMpQhta 4r9LzSbC4wEUv655Iih7bIoMGXSTE3d2fMWUZrcT7lpw== X-Forward-Email-ID: 6a0b6cf9b74b0ebd362eee90 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.73 X-Forward-Email-Version: 2.8.12 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net From: Jonas Karlman To: Neil Armstrong , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jonas Karlman , linux-rockchip@lists.infradead.org Subject: [PATCH 04/13] drm/meson: dw-hdmi: Drop call to drm_bridge_hpd_notify() Date: Mon, 18 May 2026 19:47:32 +0000 Message-ID: <20260518194744.2483580-5-jonas@kwiboo.se> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260518194744.2483580-1-jonas@kwiboo.se> References: <20260518194744.2483580-1-jonas@kwiboo.se> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Calls to both drm_helper_hpd_irq_event() and drm_bridge_hpd_notify() in the IRQ handler causes multiple hotplug uevents and modesets during an HPD interrupt. Change to only call drm_helper_hpd_irq_event() in IRQ handler to ensure only one hotplug uevent is triggered when the connection status or EDID has changed. The bridge connectors detect() func help ensure that any hpd_notify() func is called for all bridges in the chain. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c index 9aafdc768f2b..30099bf71aad 100644 --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c @@ -521,17 +521,8 @@ static irqreturn_t dw_hdmi_top_thread_irq(int irq, void *dev_id) /* HPD Events */ if (stat & (HDMITX_TOP_INTR_HPD_RISE | HDMITX_TOP_INTR_HPD_FALL) && - dw_hdmi->bridge) { - bool hpd_connected = false; - - if (stat & HDMITX_TOP_INTR_HPD_RISE) - hpd_connected = true; - + dw_hdmi->bridge) drm_helper_hpd_irq_event(dw_hdmi->bridge->dev); - drm_bridge_hpd_notify(dw_hdmi->bridge, - hpd_connected ? connector_status_connected - : connector_status_disconnected); - } return IRQ_HANDLED; } -- 2.54.0